Skip to content

Commit 5fc780f

Browse files
janiszclaude
andauthored
ci: remove scan-images-with-roxctl from build pipeline (#21076)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 9832c48 commit 5fc780f

1 file changed

Lines changed: 1 addition & 74 deletions

File tree

‎.github/workflows/build.yaml‎

Lines changed: 1 addition & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ jobs:
8686
"build_and_push_operator": { "name":[], "arch":[] },
8787
"push_operator_multiarch_manifests": { "name":[] },
8888
"build_and_push_scanner": { "name":[], "goos":[], "arch":[], "registry":[] },
89-
"push_scanner_manifests": { "name":[], "registry":[] },
90-
"scan_images_with_roxctl": { "name":[], "image":[], "exclude":[] }
89+
"push_scanner_manifests": { "name":[], "registry":[] }
9190
}'
9291
9392
# The base matrix
@@ -113,11 +112,6 @@ jobs:
113112
matrix="$(jq '.push_scanner_manifests.name += ["default"]' <<< "$matrix")"
114113
matrix="$(jq '.push_scanner_manifests.registry += ["quay.io/stackrox-io", "quay.io/rhacs-eng"]' <<< "$matrix")"
115114
116-
matrix="$(jq '.scan_images_with_roxctl.name += ["RHACS_BRANDING", "STACKROX_BRANDING"]' <<< "$matrix")"
117-
matrix="$(jq '.scan_images_with_roxctl.image += ["central-db", "collector", "fact", "main", "roxctl", "scanner", "scanner-db", "scanner-db-slim", "scanner-slim", "stackrox-operator", "scanner-v4", "scanner-v4-db"]' <<< "$matrix")"
118-
# TODO(ROX-27191): remove the exclusion once there's a community operator.
119-
matrix="$(jq '.scan_images_with_roxctl.exclude += [{ "name": "STACKROX_BRANDING", "image": "stackrox-operator" }]' <<< "$matrix")"
120-
121115
if ! is_in_PR_context || pr_has_label ci-build-all-arch; then
122116
matrix="$(jq '.pre_build_go_binaries.arch += ["ppc64le", "s390x"]' <<< "$matrix")"
123117
matrix="$(jq '.build_and_push_main.arch += ["ppc64le", "s390x"]' <<< "$matrix")"
@@ -1284,72 +1278,6 @@ jobs:
12841278
gcp-account: ${{ secrets.GCP_SERVICE_ACCOUNT_STACKROX_CI }}
12851279
directory: 'junit-reports'
12861280

1287-
scan-images-with-roxctl:
1288-
if: github.event_name == 'push' ||
1289-
contains(github.event.pull_request.labels.*.name, 'scan-images-with-roxctl')
1290-
needs:
1291-
- build-and-push-db
1292-
- build-and-push-main
1293-
- build-and-push-operator
1294-
- build-and-push-scanner
1295-
- define-job-matrix
1296-
- push-main-manifests
1297-
- push-matching-collector-scanner
1298-
- push-scanner-manifests
1299-
name: Check images for vulnerabilities
1300-
runs-on: ubuntu-latest
1301-
permissions:
1302-
# Needed for stackrox/central-login to create the JWT token.
1303-
id-token: write
1304-
security-events: write
1305-
strategy:
1306-
fail-fast: false
1307-
matrix: ${{ fromJson(needs.define-job-matrix.outputs.matrix).scan_images_with_roxctl }}
1308-
steps:
1309-
- name: Checkout
1310-
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # ratchet:actions/checkout@v6
1311-
with:
1312-
ref: ${{ inputs.commit || github.event.pull_request.head.sha }}
1313-
1314-
- uses: ./.github/actions/job-preamble
1315-
with:
1316-
gcp-account: ${{ secrets.GCP_SERVICE_ACCOUNT_STACKROX_CI }}
1317-
1318-
- name: Central login
1319-
uses: stackrox/central-login@a090772359782ced9df63d091123154ce297ac6a # ratchet:stackrox/central-login@v1
1320-
with:
1321-
endpoint: ${{ vars.ACS_DOGFOODING_CENTRAL_URL }}
1322-
1323-
- name: Install roxctl
1324-
uses: stackrox/roxctl-installer-action@47fb4f5b275066b8322369e6e33fa010915b0d13 # ratchet:stackrox/roxctl-installer-action@v1
1325-
with:
1326-
central-endpoint: ${{ vars.ACS_DOGFOODING_CENTRAL_URL }}
1327-
central-token: ${{ env.ROX_API_TOKEN }}
1328-
1329-
- name: Scan images for vulnerabilities
1330-
env:
1331-
BUILD_TAG: ${{ needs.define-job-matrix.outputs.build-tag }}
1332-
SHORTCOMMIT: ${{ needs.define-job-matrix.outputs.short-commit }}
1333-
GOTAGS: ${{ needs.define-job-matrix.outputs.gotags }}
1334-
run: |
1335-
release_tag="$(make --quiet --no-print-directory tag)"
1336-
if [[ "${{ matrix.image }}" =~ "operator" ]]; then
1337-
release_tag="$(make -C operator --quiet --no-print-directory tag)"
1338-
fi
1339-
1340-
registry="$(./scripts/ci/lib.sh registry_from_branding "${{ matrix.name }}")"
1341-
1342-
roxctl image scan --retries=10 --retry-delay=15 --force --severity=CRITICAL,IMPORTANT --output=sarif \
1343-
--image="${registry}/${{ matrix.image }}:${release_tag}" \
1344-
| tee results.sarif
1345-
1346-
# TODO: re-enable roxctl scan results upload once quota issue has been resolved
1347-
# - name: Upload roxctl scan results to GitHub Security tab
1348-
# uses: github/codeql-action/upload-sarif@v3
1349-
# with:
1350-
# category: ${{ matrix.image }}
1351-
# sarif_file: results.sarif
1352-
13531281
slack-on-build-failure:
13541282
env:
13551283
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -1374,7 +1302,6 @@ jobs:
13741302
- pre-build-ui
13751303
- push-matching-collector-scanner
13761304
- scan-go-binaries
1377-
- scan-images-with-roxctl
13781305
permissions:
13791306
actions: read
13801307
steps:

0 commit comments

Comments
 (0)