refactor: replace blank imports with explicit Init() in central compliance

janisz · claude · janisz · commit 4c0dbf7d85a3 · 2026-04-13T20:48:33.000+02:00
Updated central/compliance/checks/all.go to call explicit Init() functions
for all compliance standards instead of using blank imports. Added
centralChecks.Init() call to central/app/app.go. Removed blank import from
central/compliance/manager/checks.go.

This completes the migration from automatic package-level init() to explicit
initialization for all central compliance checks (76 total check files):
- hipaa_164: 19 checks
- nist800-190: 13 checks
- nist80053: 20 checks
- pcidss32: 24 checks
- remote: wraps node checks

Changes:
- central/compliance/checks/all.go: blank imports → Init() calls
- central/app/app.go: added centralChecks.Init() call
- central/compliance/manager/checks.go: removed blank import

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/central/app/app.go b/central/app/app.go
@@ -1,6 +1,7 @@
 package app
 
 import (
+	centralChecks "github.com/stackrox/rox/central/compliance/checks"
 	"github.com/stackrox/rox/central/graphql/resolvers/loaders"
 	"github.com/stackrox/rox/central/metrics"
 	"github.com/stackrox/rox/pkg/compliance/checks"
@@ -25,4 +26,5 @@ func Run() {
 	metrics.Init()
 	loaders.Init()
 	checks.Init()
+	centralChecks.Init()
 }
diff --git a/central/compliance/checks/all.go b/central/compliance/checks/all.go
@@ -1,10 +1,19 @@
 package checks
 
 import (
-	// Make sure all checks from all standards are registered.
-	_ "github.com/stackrox/rox/central/compliance/checks/hipaa_164"
-	_ "github.com/stackrox/rox/central/compliance/checks/nist800-190"
-	_ "github.com/stackrox/rox/central/compliance/checks/nist80053"
-	_ "github.com/stackrox/rox/central/compliance/checks/pcidss32"
-	_ "github.com/stackrox/rox/central/compliance/checks/remote"
+	"github.com/stackrox/rox/central/compliance/checks/hipaa_164"
+	"github.com/stackrox/rox/central/compliance/checks/nist800-190"
+	"github.com/stackrox/rox/central/compliance/checks/nist80053"
+	"github.com/stackrox/rox/central/compliance/checks/pcidss32"
+	"github.com/stackrox/rox/central/compliance/checks/remote"
 )
+
+// Init registers all central compliance checks.
+// Called explicitly from central/compliance/manager/checks.go instead of package init().
+func Init() {
+	hipaa164.Init()
+	nist800190.Init()
+	nist80053.Init()
+	pcidss32.Init()
+	remote.Init()
+}
diff --git a/central/compliance/manager/checks.go b/central/compliance/manager/checks.go
@@ -1,5 +1,4 @@
 package manager
 
-import (
-	_ "github.com/stackrox/rox/central/compliance/checks" // Make sure all checks are available
-)
+// Compliance checks are now registered explicitly via central/compliance/checks.Init()
+// called from central/app/app.go instead of automatic package init().
