Guard err.Error() calls with require.Error to prevent nil-panic

guzalv · claude · guzalv · commit 36ad77cace4e · 2026-04-10T09:34:05.000+02:00
If CreateComplianceScanConfiguration unexpectedly succeeds for a
duplicate profile, err is nil and err.Error() panics. Add require.Error
before accessing the error message.

Partially generated by AI.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/tests/compliance_operator_v2_test.go b/tests/compliance_operator_v2_test.go
@@ -692,6 +692,7 @@ func TestComplianceV2CreateGetScanConfigurations(t *testing.T) {
 
 	// Verify that the duplicate profile was not created and the error message is correct.
 	_, err = scanConfigService.CreateComplianceScanConfiguration(ctx, duplicateProfileReq)
+	require.Error(t, err, "expected duplicate profile scan config to be rejected")
 	assert.Contains(t, err.Error(), "already uses profile")
 
 	// Also verify that creating with the TP name is rejected (duplicate TP).
@@ -716,6 +717,7 @@ func TestComplianceV2CreateGetScanConfigurations(t *testing.T) {
 		},
 	}
 	_, err = scanConfigService.CreateComplianceScanConfiguration(ctx, duplicateTPReq)
+	require.Error(t, err, "expected duplicate TP scan config to be rejected")
 	assert.Contains(t, err.Error(), "already uses profile")
 
 	query = &v2.RawQuery{Query: ""}
