selectionsort - decrease outer loop iteration and remove extra variable (mgechev#161)

Nirajkashyap · mgechev · commit d66eccef5b7e · 2019-11-08T07:52:52.000-08:00
* decrease outer loop iteration. do not iterate for last element as it is last one and no comarison left * remove extra variable * add debug config for vscode * remove comment * remove lint error * remove vscode config file * Bump js-yaml from 3.13.0 to 3.13.1 (mgechev#160) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.13.0...3.13.1) Signed-off-by: dependabot[bot] <support@github.com>
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,5 @@
 node_modules
+.vscode
 npm-debug.log
 debug
 dist
diff --git a/src/sorting/selectionsort.js b/src/sorting/selectionsort.js
@@ -25,20 +25,17 @@
    */
   var selectionSort = function (array, cmp) {
     cmp = cmp || compare;
-    var min;
     var idx;
     var temp;
-    for (var i = 0; i < array.length; i += 1) {
+    for (var i = 0; i < array.length - 1; i += 1) {
       idx = i;
-      min = array[i];
       for (var j = i + 1; j < array.length; j += 1) {
-        if (cmp(min, array[j]) > 0) {
-          min = array[j];
+        if (cmp(array[idx], array[j]) > 0) {
           idx = j;
         }
       }
       temp = array[i];
-      array[i] = min;
+      array[i] = array[idx];
       array[idx] = temp;
     }
     return array;

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`node_modules`
	`2`	`+.vscode`
`2`	`3`	`npm-debug.log`
`3`	`4`	`debug`
`4`	`5`	`dist`