Skip to content

Commit ddb386b

Browse files
committed
Revert "client.logger.warning wrongly used in migrations"
This is a partial revert of the previous patch. The inline setup of the logger ends up causing issues when this is consumed by other libraries that want control over the logger. Closes-Bug: #1697452 This reverts commit 9a27201. Change-Id: I1d61d4952aef1039e72a2aac629cb13a6a15d7b2
1 parent 4bdc600 commit ddb386b

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

novaclient/v2/client.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,7 @@ def __init__(self,
183183
self.server_external_events = \
184184
server_external_events.ServerExternalEventManager(self)
185185

186-
if not logger:
187-
logger = logging.getLogger(__name__)
188-
if not logger.handlers:
189-
logger.addHandler(logging.StreamHandler())
190-
self.logger = logger
186+
self.logger = logger or logging.getLogger(__name__)
191187

192188
# Add in any extensions...
193189
if extensions:

0 commit comments

Comments
 (0)