Limit memory usage when running qemu-img convert

umago · umago · commit 449cda4fed51 · 2017-01-19T18:01:30.000Z
This patch is limiting the memory address space to 1 GiB when invoking
qemu-img convert. The qemu-img command can be exploited so we better
play on the safe side (See: bug #1449062).

Change-Id: I2088f74b32d1392310c569cfaa7fd368cb737421
Closes-Bug: #1657808
diff --git a/ironic_python_agent/shell/write_image.sh b/ironic_python_agent/shell/write_image.sh
@@ -39,6 +39,9 @@ log "Erasing existing GPT and MBR data structures from ${DEVICE}"
 sgdisk -Z $DEVICE
 
 log "Imaging $IMAGEFILE to $DEVICE"
+
+# limit the memory usage for qemu-img to 1 GiB
+ulimit -v 1048576
 qemu-img convert -t directsync -O host_device $IMAGEFILE $DEVICE
 sync
 
diff --git a/releasenotes/notes/limit-qemu-img-ram-usage-d7b7a16ac5e9c917.yaml b/releasenotes/notes/limit-qemu-img-ram-usage-d7b7a16ac5e9c917.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Limits the memory usage of ``qemu-img convert`` command to 1 GiB to
+    avoid it from causing the host machine to fail due not enough ram.

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +fixes:
 +  - |
 +    Limits the memory usage of ``qemu-img convert`` command to 1 GiB to
 +    avoid it from causing the host machine to fail due not enough ram.