Skip to content

Commit f124370

Browse files
gleichgleich
committed
♻️ Refactor to only pass time in once for test
Signed-off-by: Matthew Gleich <email@mattglei.ch>
1 parent d8ef8b8 commit f124370

1 file changed

Lines changed: 25 additions & 33 deletions

File tree

‎pkg/cmd/gist/list/list_test.go‎

Lines changed: 25 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -119,31 +119,31 @@ func Test_listRun(t *testing.T) {
119119
httpmock.GraphQL(query),
120120
httpmock.StringResponse(fmt.Sprintf(
121121
`{ "data": { "viewer": { "gists": { "nodes": [
122-
{
122+
{
123123
"name": "1234567890",
124124
"files": [{ "name": "cool.txt", "languages": { "name": "None" }, "extension": ".txt" }],
125125
"description": "",
126-
"updatedAt": "%v",
126+
"updatedAt": "%[1]v",
127127
"isPublic": true
128128
},
129-
{
129+
{
130130
"name": "4567890123",
131131
"files": [{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" }],
132132
"description": "",
133-
"updatedAt": "%v",
133+
"updatedAt": "%[1]v",
134134
"isPublic": true
135135
},
136-
{
136+
{
137137
"name": "2345678901",
138138
"files": [
139139
{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" },
140140
{ "name": "gistfile1.txt", "languages": { "name": "None" }, "extension": ".txt" }
141141
],
142142
"description": "tea leaves thwart those who court catastrophe",
143-
"updatedAt": "%v",
143+
"updatedAt": "%[1]v",
144144
"isPublic": false
145145
},
146-
{
146+
{
147147
"name": "3456789012",
148148
"files": [
149149
{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" },
@@ -159,14 +159,11 @@ func Test_listRun(t *testing.T) {
159159
{ "name": "gistfile11.txt", "languages": { "name": "None" }, "extension": ".txt" }
160160
],
161161
"description": "short desc",
162-
"updatedAt": "%v",
162+
"updatedAt": "%[1]v",
163163
"isPublic": false
164164
}
165165
] } } } }`,
166166
timeSixHoursAgo,
167-
timeSixHoursAgo,
168-
timeSixHoursAgo,
169-
timeSixHoursAgo,
170167
)),
171168
)
172169
},
@@ -180,23 +177,22 @@ func Test_listRun(t *testing.T) {
180177
httpmock.GraphQL(query),
181178
httpmock.StringResponse(fmt.Sprintf(
182179
`{ "data": { "viewer": { "gists": { "nodes": [
183-
{
180+
{
184181
"name": "1234567890",
185182
"files": [{ "name": "cool.txt", "languages": { "name": "None" }, "extension": ".txt" }],
186183
"description": "",
187-
"updatedAt": "%v",
184+
"updatedAt": "%[1]v",
188185
"isPublic": true
189186
},
190-
{
187+
{
191188
"name": "4567890123",
192189
"files": [{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" }],
193190
"description": "",
194-
"updatedAt": "%v",
191+
"updatedAt": "%[1]v",
195192
"isPublic": true
196193
}
197194
] } } } }`,
198195
timeSixHoursAgo,
199-
timeSixHoursAgo,
200196
)),
201197
)
202198
},
@@ -210,17 +206,17 @@ func Test_listRun(t *testing.T) {
210206
httpmock.GraphQL(query),
211207
httpmock.StringResponse(fmt.Sprintf(
212208
`{ "data": { "viewer": { "gists": { "nodes": [
213-
{
209+
{
214210
"name": "2345678901",
215211
"files": [
216212
{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" },
217213
{ "name": "gistfile1.txt", "languages": { "name": "None" }, "extension": ".txt" }
218214
],
219215
"description": "tea leaves thwart those who court catastrophe",
220-
"updatedAt": "%v",
216+
"updatedAt": "%[1]v",
221217
"isPublic": false
222218
},
223-
{
219+
{
224220
"name": "3456789012",
225221
"files": [
226222
{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" },
@@ -236,12 +232,11 @@ func Test_listRun(t *testing.T) {
236232
{ "name": "gistfile11.txt", "languages": { "name": "None" }, "extension": ".txt" }
237233
],
238234
"description": "short desc",
239-
"updatedAt": "%v",
235+
"updatedAt": "%[1]v",
240236
"isPublic": false
241237
}
242238
] } } } }`,
243239
timeSixHoursAgo,
244-
timeSixHoursAgo,
245240
)),
246241
)
247242
},
@@ -255,7 +250,7 @@ func Test_listRun(t *testing.T) {
255250
httpmock.GraphQL(query),
256251
httpmock.StringResponse(fmt.Sprintf(
257252
`{ "data": { "viewer": { "gists": { "nodes": [
258-
{
253+
{
259254
"name": "1234567890",
260255
"files": [{ "name": "cool.txt", "languages": { "name": "None" }, "extension": ".txt" }],
261256
"description": "",
@@ -277,31 +272,31 @@ func Test_listRun(t *testing.T) {
277272
httpmock.GraphQL(query),
278273
httpmock.StringResponse(fmt.Sprintf(
279274
`{ "data": { "viewer": { "gists": { "nodes": [
280-
{
275+
{
281276
"name": "1234567890",
282277
"files": [{ "name": "cool.txt", "languages": { "name": "None" }, "extension": ".txt" }],
283278
"description": "",
284-
"updatedAt": "%v",
279+
"updatedAt": "%[1]v",
285280
"isPublic": true
286281
},
287-
{
282+
{
288283
"name": "4567890123",
289284
"files": [{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" }],
290285
"description": "",
291-
"updatedAt": "%v",
286+
"updatedAt": "%[1]v",
292287
"isPublic": true
293288
},
294-
{
289+
{
295290
"name": "2345678901",
296291
"files": [
297292
{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" },
298293
{ "name": "gistfile1.txt", "languages": { "name": "None" }, "extension": ".txt" }
299294
],
300295
"description": "tea leaves thwart those who court catastrophe",
301-
"updatedAt": "%v",
296+
"updatedAt": "%[1]v",
302297
"isPublic": false
303298
},
304-
{
299+
{
305300
"name": "3456789012",
306301
"files": [
307302
{ "name": "gistfile0.txt", "languages": { "name": "None" }, "extension": ".txt" },
@@ -317,14 +312,11 @@ func Test_listRun(t *testing.T) {
317312
{ "name": "gistfile11.txt", "languages": { "name": "None" }, "extension": ".txt" }
318313
],
319314
"description": "short desc",
320-
"updatedAt": "%v",
315+
"updatedAt": "%[1]v",
321316
"isPublic": false
322317
}
323318
] } } } }`,
324319
blankTime,
325-
blankTime,
326-
blankTime,
327-
blankTime,
328320
)),
329321
)
330322
},

0 commit comments

Comments
 (0)