Merge pull request socketio#257 from DevFactory/release/constructors-should-only-call-non-overridable-methods-fix-1

nkzawa · nkzawa · commit 669696fee4b0 · 2015-12-18T11:48:36.000+09:00
Code Quality Improvement - Constructors should only call non-overridable methods
diff --git a/src/main/java/io/socket/client/Manager.java b/src/main/java/io/socket/client/Manager.java
@@ -180,7 +180,7 @@ public Manager reconnectionAttempts(int v) {
         return this;
     }
 
-    public long reconnectionDelay() {
+    public final long reconnectionDelay() {
         return this._reconnectionDelay;
     }
 
@@ -192,7 +192,7 @@ public Manager reconnectionDelay(long v) {
         return this;
     }
 
-    public double randomizationFactor() {
+    public final double randomizationFactor() {
         return this._randomizationFactor;
     }
 
@@ -204,7 +204,7 @@ public Manager randomizationFactor(double v) {
         return this;
     }
 
-    public long reconnectionDelayMax() {
+    public final long reconnectionDelayMax() {
         return this._reconnectionDelayMax;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ public Manager reconnectionAttempts(int v) {`
`180`	`180`	`return this;`
`181`	`181`	`}`
`182`	`182`
`183`		`- public long reconnectionDelay() {`
	`183`	`+ public final long reconnectionDelay() {`
`184`	`184`	`return this._reconnectionDelay;`
`185`	`185`	`}`
`186`	`186`
`@@ -192,7 +192,7 @@ public Manager reconnectionDelay(long v) {`
`192`	`192`	`return this;`
`193`	`193`	`}`
`194`	`194`
`195`		`- public double randomizationFactor() {`
	`195`	`+ public final double randomizationFactor() {`
`196`	`196`	`return this._randomizationFactor;`
`197`	`197`	`}`
`198`	`198`
`@@ -204,7 +204,7 @@ public Manager randomizationFactor(double v) {`
`204`	`204`	`return this;`
`205`	`205`	`}`
`206`	`206`
`207`		`- public long reconnectionDelayMax() {`
	`207`	`+ public final long reconnectionDelayMax() {`
`208`	`208`	`return this._reconnectionDelayMax;`
`209`	`209`	`}`
`210`	`210`