Do not pollute the base sqlmeta class to allow Style to set idName.

phdru · phdru · commit ec2588db59e8 · 2010-02-01T14:45:04.000Z
git-svn-id: http://svn.colorstudy.com/SQLObject/trunk@4090 95a46c32-92d2-0310-94a5-8d71aeb3d4b3
diff --git a/docs/News.txt b/docs/News.txt
@@ -16,6 +16,13 @@ Features & Interface
 * Added TimedeltaCol; currently it's only implemented on PostgreSQL as an
   INTERVAL type.
 
+Small Features
+--------------
+
+* Do not pollute the base sqlmeta class to allow Style to set idName. In
+  the case of inherited idName inherited value takes precedence; To allow
+  Style to set idName resets inherited idName to None.
+
 SQLObject 0.12.1
 ================
 
diff --git a/sqlobject/main.py b/sqlobject/main.py
@@ -853,7 +853,8 @@ def _SO_setupSqlmeta(cls, new_attrs, is_base):
                     del values[key]
             cls.sqlmeta = type('sqlmeta', (superclass,), values)
 
-        cls.sqlmeta.setClass(cls)
+        if not is_base: # Do not pollute the base sqlmeta class
+            cls.sqlmeta.setClass(cls)
 
     _SO_setupSqlmeta = classmethod(_SO_setupSqlmeta)
 
diff --git a/sqlobject/tests/test_basic.py b/sqlobject/tests/test_basic.py
@@ -291,29 +291,17 @@ def test_nonexisting_attr():
     else:
         assert 0, "Expected an AttributeError"
 
-class myid_sqlmeta(sqlmeta):
-    idName = "my_id"
-
 class TestSO12(SQLObject):
-    class sqlmeta(myid_sqlmeta):
-        pass
-    name = StringCol()
-
-def test_sqlmeta_inherited_idName():
-    setupClass(TestSO12)
-    assert TestSO12.sqlmeta.idName == "my_id"
-
-class TestSO13(SQLObject):
     name = StringCol()
     value = IntCol(defaultSQL='1')
 
 def test_defaultSQL():
-    setupClass(TestSO13)
-    test = TestSO13(name="test")
+    setupClass(TestSO12)
+    test = TestSO12(name="test")
     assert test.value == 1
 
 def test_connection_override():
     sqlhub.processConnection = connectionForURI('sqlite:///db1')
-    class TestSO14(SQLObject):
+    class TestSO13(SQLObject):
         _connection = connectionForURI('sqlite:///db2')
-    assert TestSO14._connection.uri() == 'sqlite:///db2'
+    assert TestSO13._connection.uri() == 'sqlite:///db2'
diff --git a/sqlobject/tests/test_sqlmeta_idName.py b/sqlobject/tests/test_sqlmeta_idName.py
@@ -0,0 +1,43 @@
+from sqlobject import *
+from sqlobject.tests.dbtest import *
+
+class myid_sqlmeta(sqlmeta):
+    idName = "my_id"
+
+class TestSqlmeta1(SQLObject):
+    class sqlmeta(myid_sqlmeta):
+        pass
+
+class TestSqlmeta2(SQLObject):
+    class sqlmeta(sqlmeta):
+        style = MixedCaseStyle(longID=True)
+
+class TestSqlmeta3(SQLObject):
+    class sqlmeta(myid_sqlmeta):
+        style = MixedCaseStyle(longID=True)
+
+class TestSqlmeta4(SQLObject):
+    class sqlmeta(myid_sqlmeta):
+        idName = None
+        style = MixedCaseStyle(longID=True)
+
+class longid_sqlmeta(sqlmeta):
+    idName = "my_id"
+    style = MixedCaseStyle(longID=True)
+
+class TestSqlmeta5(SQLObject):
+    class sqlmeta(longid_sqlmeta):
+        pass
+
+class TestSqlmeta6(SQLObject):
+    class sqlmeta(longid_sqlmeta):
+        idName = None
+
+def test_sqlmeta_inherited_idName():
+    setupClass([TestSqlmeta1, TestSqlmeta2])
+    assert TestSqlmeta1.sqlmeta.idName == "my_id"
+    assert TestSqlmeta2.sqlmeta.idName == "TestSqlmeta2ID"
+    assert TestSqlmeta3.sqlmeta.idName == "my_id"
+    assert TestSqlmeta4.sqlmeta.idName == "TestSqlmeta4ID"
+    assert TestSqlmeta5.sqlmeta.idName == "my_id"
+    assert TestSqlmeta6.sqlmeta.idName == "TestSqlmeta6ID"
