Fix #21 flake8 F401: 'name' imported but unused

phdru · phdru · commit 6720c05b668e · 2015-01-07T01:49:19.000+03:00
Some names are imported for real needs like side effects; those imports
are marked with `noqa` flake8 directive.
diff --git a/setup.py b/setup.py
@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 
 from imp import load_source
-from os.path import abspath, dirname, isfile, join
+from os.path import abspath, dirname, join
 
 try:
     from ez_setup import use_setuptools
diff --git a/sqlobject/__init__.py b/sqlobject/__init__.py
@@ -1,11 +1,15 @@
 """SQLObject"""
-from __version__ import version, version_info
 
-from col import *
-from index import *
-from joins import *
-from main import *
-from sqlbuilder import AND, OR, NOT, IN, LIKE, RLIKE, DESC, CONTAINSSTRING, const, func
-from styles import *
-from dbconnection import connectionForURI
-import dberrors
+# Do import for namespace
+# noqa is a directive for flake8 to ignore seemingly unused imports
+
+from __version__ import version, version_info # noqa
+
+from col import * # noqa
+from index import * # noqa
+from joins import * # noqa
+from main import * # noqa
+from sqlbuilder import AND, OR, NOT, IN, LIKE, RLIKE, DESC, CONTAINSSTRING, const, func # noqa
+from styles import * # noqa
+from dbconnection import connectionForURI # noqa
+import dberrors # noqa
diff --git a/sqlobject/cache.py b/sqlobject/cache.py
@@ -8,7 +8,6 @@
 
 import threading
 from weakref import ref
-from time import time as now
 
 class CacheFactory(object):
 
diff --git a/sqlobject/col.py b/sqlobject/col.py
@@ -20,8 +20,6 @@
 
 from array import array
 from itertools import count
-import re
-import sys
 import time
 try:
     import cPickle as pickle
diff --git a/sqlobject/conftest.py b/sqlobject/conftest.py
@@ -8,7 +8,6 @@
 exitfirst = True
 
 import py
-import os
 import sqlobject
 
 try:
diff --git a/sqlobject/converters.py b/sqlobject/converters.py
@@ -1,7 +1,6 @@
 from array import array
 import datetime
 from decimal import Decimal
-import sys
 import time
 from types import ClassType, InstanceType, NoneType
 
diff --git a/sqlobject/dbconnection.py b/sqlobject/dbconnection.py
@@ -1031,12 +1031,13 @@ def dbConnectionForScheme(self, scheme):
 connectionForURI = TheURIOpener.connectionForURI
 dbConnectionForScheme = TheURIOpener.dbConnectionForScheme
 
-# Register DB URI schemas
-import firebird
-import maxdb
-import mssql
-import mysql
-import postgres
-import rdbhost
-import sqlite
-import sybase
+# Register DB URI schemas -- do import for side effects
+# noqa is a directive for flake8 to ignore seemingly unused imports
+import firebird # noqa
+import maxdb # noqa
+import mssql # noqa
+import mysql # noqa
+import postgres # noqa
+import rdbhost # noqa
+import sqlite # noqa
+import sybase # noqa
diff --git a/sqlobject/rdbhost/rdbhostconnection.py b/sqlobject/rdbhost/rdbhostconnection.py
@@ -4,10 +4,6 @@
 Released under the LGPL for use with the SQLObject ORM library.
 """
 
-import re
-from sqlobject import col
-from sqlobject import sqlbuilder
-from sqlobject.converters import registerConverter
 from sqlobject.dbconnection import DBAPI
 from sqlobject.postgres.pgconnection import PostgresConnection
 
diff --git a/sqlobject/sqlite/sqliteconnection.py b/sqlobject/sqlite/sqliteconnection.py
@@ -3,7 +3,7 @@
 import thread
 import urllib
 from sqlobject.dbconnection import DBAPI, Boolean
-from sqlobject import col, sqlbuilder
+from sqlobject import col
 from sqlobject.dberrors import *
 
 sqlite2_Binary = None
diff --git a/sqlobject/sresults.py b/sqlobject/sresults.py
@@ -1,5 +1,4 @@
 import dbconnection
-import joins
 import main
 import sqlbuilder
 
diff --git a/sqlobject/tests/dbtest.py b/sqlobject/tests/dbtest.py
@@ -5,7 +5,6 @@
 
 import logging
 import os
-import re
 import sys
 from py.test import raises
 import sqlobject
diff --git a/sqlobject/tests/test_converters.py b/sqlobject/tests/test_converters.py
@@ -1,5 +1,4 @@
 from datetime import timedelta
-import sys
 
 from sqlobject.converters import registerConverter, sqlrepr, \
      quote_str, unquote_str
diff --git a/sqlobject/tests/test_csvexport.py b/sqlobject/tests/test_csvexport.py
@@ -2,7 +2,6 @@
 
 from sqlobject import *
 from dbtest import *
-import csv
 from StringIO import StringIO
 from sqlobject.util.csvexport import export_csv, export_csv_zip
 
diff --git a/sqlobject/tests/test_events.py b/sqlobject/tests/test_events.py
@@ -4,7 +4,6 @@
 from sqlobject.tests.dbtest import *
 from sqlobject import events
 from sqlobject.inheritance import InheritableSQLObject
-import sys
 
 class EventTester(SQLObject):
     name = StringCol()
diff --git a/sqlobject/views.py b/sqlobject/views.py
@@ -1,6 +1,5 @@
 from sqlbuilder import *
-from main import SQLObject, sqlmeta
-import types, threading
+from main import SQLObject
 
 ####
 
diff --git a/sqlobject/wsgi_middleware.py b/sqlobject/wsgi_middleware.py
@@ -2,7 +2,6 @@
 from paste.wsgilib import catch_errors
 from paste.util import import_string
 import sqlobject
-import threading
 
 def make_middleware(app, global_conf, database=None, use_transaction=False,
                     hub=None):

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import dbconnection`
`2`		`-import joins`
`3`	`2`	`import main`
`4`	`3`	`import sqlbuilder`
`5`	`4`