Use isinstance(..., basestring) instead of isinstance(..., (str, unicode));

phdru · phdru · commit 65e8105518fc · 2007-09-20T14:40:33.000Z
stop emulating basestring, stop using types.StringTypes and type(""). git-svn-id: http://svn.colorstudy.com/SQLObject/trunk@2967 95a46c32-92d2-0310-94a5-8d71aeb3d4b3
diff --git a/sqlobject/col.py b/sqlobject/col.py
@@ -1297,7 +1297,7 @@ def from_python(self, value, state):
             return None
         if isinstance(value, float):
             value = str(value)
-        if isinstance(value, (str, unicode)):
+        if isinstance(value, basestring):
             connection = state.soObject._connection
             if hasattr(connection, "decimalSeparator"):
                 value = value.replace(connection.decimalSeparator, ".")
diff --git a/sqlobject/constraints.py b/sqlobject/constraints.py
@@ -19,7 +19,7 @@ def __init__(self, desc, obj, col, value, *args):
         ValueError.__init__(self, fullDesc, *args)
 
 def isString(obj, col, value):
-    if type(value) is not type(""):
+    if not isinstance(value, str):
         raise BadValue("only allows strings", obj, col, value)
 
 def notNull(obj, col, value):
diff --git a/sqlobject/converters.py b/sqlobject/converters.py
@@ -115,8 +115,8 @@ def StringLikeConverter(value, db):
         assert 0, "Database %s unknown" % db
     return "'%s'" % value
 
-registerConverter(type(""), StringLikeConverter)
-registerConverter(type(u""), StringLikeConverter)
+registerConverter(str, StringLikeConverter)
+registerConverter(unicode, StringLikeConverter)
 registerConverter(array_type, StringLikeConverter)
 registerConverter(buffer_type, StringLikeConverter)
 
diff --git a/sqlobject/dbconnection.py b/sqlobject/dbconnection.py
@@ -521,7 +521,7 @@ def _SO_selectOne(self, so, columnNames):
 
     def _SO_selectOneAlt(self, so, columnNames, condition):
         if columnNames:
-            columns = [isinstance(x, (str, unicode)) and sqlbuilder.SQLConstant(x) or x for x in columnNames]
+            columns = [isinstance(x, basestring) and sqlbuilder.SQLConstant(x) or x for x in columnNames]
         else:
             columns = None
         return self.queryOne(self.sqlrepr(sqlbuilder.Select(columns,
diff --git a/sqlobject/inheritance/__init__.py b/sqlobject/inheritance/__init__.py
@@ -6,13 +6,6 @@
 import iteration
 
 
-try:
-    basestring
-except NameError: # Python 2.2
-    import types
-    basestring = (types.StringType, types.UnicodeType)
-
-
 def tablesUsedDict(obj, db):
     if hasattr(obj, "tablesUsedDict"):
         return obj.tablesUsedDict(db)
@@ -49,7 +42,7 @@ def __init__(self, sourceClass, clause, clauseTables=None,
         #DSM: because if the user uses clauseTables
         #DSM: (and normal string SELECT), he must know what he wants
         #DSM: and will do himself the relationship between classes.
-        if type(clause) is not str:
+        if not isinstance(clause, str):
             tableRegistry = {}
             allClasses = classregistry.registry(
                 sourceClass.sqlmeta.registry).allClasses()
@@ -222,7 +215,7 @@ def __classinit__(cls, new_attrs):
             for column in currentClass.sqlmeta.columnDefinitions.values():
                 if column.name == 'childName':
                     continue
-                if type(column) == ForeignKey:
+                if isinstance(column, ForeignKey):
                     continue
                 setattr(cls.q, column.name,
                     getattr(currentClass.q, column.name))
diff --git a/sqlobject/main.py b/sqlobject/main.py
@@ -1618,7 +1618,7 @@ def _reprItems(self):
         return items
 
     def setConnection(cls, value):
-        if isinstance(value, (str, unicode)):
+        if isinstance(value, basestring):
             value = dbconnection.connectionForURI(value)
         cls._connection = value
     setConnection = classmethod(setConnection)
@@ -1663,7 +1663,7 @@ def getID(obj):
         return obj
     elif type(obj) is type(1L):
         return int(obj)
-    elif type(obj) is type(""):
+    elif isinstance(obj, str):
         try:
             return int(obj)
         except ValueError:
@@ -1676,7 +1676,7 @@ def getObject(obj, klass):
         return klass(obj)
     elif type(obj) is type(1L):
         return klass(int(obj))
-    elif type(obj) is type(""):
+    elif isinstance(obj, str):
         return klass(int(obj))
     elif obj is None:
         return None
diff --git a/sqlobject/manager/command.py b/sqlobject/manager/command.py
@@ -1256,7 +1256,7 @@ def best_upgrade(self, current, dest, target_dbname):
         return upgraders[-1]
 
 def update_sys_path(paths, verbose):
-    if isinstance(paths, (str, unicode)):
+    if isinstance(paths, basestring):
         paths = [paths]
     for path in paths:
         path = os.path.abspath(path)
diff --git a/sqlobject/sqlbuilder.py b/sqlobject/sqlbuilder.py
@@ -80,7 +80,7 @@ class NoDefault:
 safeSQLRE = re.compile(r'^[a-zA-Z_][a-zA-Z0-9_\.]*$')
 def sqlIdentifier(obj):
     # some db drivers return unicode column names
-    return isinstance(obj, types.StringTypes) and bool(safeSQLRE.search(obj.strip()))
+    return isinstance(obj, basestring) and bool(safeSQLRE.search(obj.strip()))
 
 
 def execute(expr, executor):
@@ -584,7 +584,7 @@ def filter(self, filter_clause):
             # None doesn't filter anything, it's just a no-op:
             return self
         clause = self.ops['clause']
-        if isinstance(clause, (str, unicode)):
+        if isinstance(clause, basestring):
             clause = SQLConstant('(%s)' % clause)
 
         if clause == SQLTrueClause:
@@ -849,7 +849,7 @@ def ISNOTNULL(expr):
 class ColumnAS(SQLOp):
     ''' Just like SQLOp('AS', expr, name) except without the parentheses '''
     def __init__(self, expr, name):
-        if isinstance(name, (str, unicode)):
+        if isinstance(name, basestring):
             name = SQLConstant(name)
         SQLOp.__init__(self, 'AS', expr, name)
     def __sqlrepr__(self, db):
@@ -888,7 +888,7 @@ def __sqlrepr__(self, db):
                 return "CONCAT(%s)" % ", ".join(values)
             else:
                 return " || ".join(values)
-        elif isinstance(s, (str, unicode)):
+        elif isinstance(s, basestring):
             s = _quote_percent(sqlrepr(s, db)[1:-1], db)
             return "'%s%s%s'" % (self.prefix, s, self.postfix)
         else:
diff --git a/sqlobject/sresults.py b/sqlobject/sresults.py
@@ -3,8 +3,6 @@
 import main
 import joins
 
-StringType = type('')
-
 class SelectResults(object):
     IterationClass = dbconnection.Iteration
 
@@ -76,7 +74,7 @@ def _mungeOrderBy(self, orderBy):
             desc = True
         else:
             desc = False
-        if isinstance(orderBy, (str, unicode)):
+        if isinstance(orderBy, basestring):
             if orderBy in self.sourceClass.sqlmeta.columns:
                 val = getattr(self.sourceClass.q, self.sourceClass.sqlmeta.columns[orderBy].name)
                 if desc:
@@ -125,7 +123,7 @@ def filter(self, filter_clause):
             # None doesn't filter anything, it's just a no-op:
             return self
         clause = self.clause
-        if isinstance(clause, (str, unicode)):
+        if isinstance(clause, basestring):
             clause = sqlbuilder.SQLConstant('(%s)' % self.clause)
         return self.newClause(sqlbuilder.AND(clause, filter_clause))
 
@@ -236,7 +234,7 @@ def accumulateMany(self, *attributes):
         """
         expressions = []
         for func_name, attribute in attributes:
-            if type(attribute) == StringType:
+            if isinstance(attribute, str):
                 expression = '%s(%s)' % (func_name, attribute)
             else:
                 expression = getattr(sqlbuilder.func, func_name)(attribute)
diff --git a/sqlobject/util/csvexport.py b/sqlobject/util/csvexport.py
@@ -153,7 +153,7 @@ def export_csv_zip(soClasses, file=None, zip=None, filename_prefix='',
     close_zip_when_finished = True
     return_when_finished = False
     if file:
-        if isinstance(file, (str, unicode)):
+        if isinstance(file, basestring):
             close_when_finished = True
             file = open(file, 'wb')
     elif zip:
