Merged revision 4430 from branch 1.1: a bug was fixed in SelectResults slicing

phdru · phdru · commit 53c1f45d71da · 2011-07-18T20:37:08.000Z
that prevented to slice a slice (my_results[:20][1:5]). git-svn-id: http://svn.colorstudy.com/SQLObject/trunk@4431 95a46c32-92d2-0310-94a5-8d71aeb3d4b3
diff --git a/docs/News.txt b/docs/News.txt
@@ -54,6 +54,12 @@ Source code and internals
 
 * All 'mydict.has_key(name)' checks were replaced with 'name in mydict'.
 
+SQLObject 1.0.2
+===============
+
+* A bug was fixed in SelectResults slicing that prevented to slice a
+  slice (my_results[:20][1:5]).
+
 SQLObject 1.0.1
 ===============
 
diff --git a/sqlobject/sresults.py b/sqlobject/sresults.py
@@ -1,7 +1,9 @@
-import sqlbuilder
 import dbconnection
-import main
 import joins
+import main
+import sqlbuilder
+
+__all__ = ['SelectResults']
 
 class SelectResults(object):
     IterationClass = dbconnection.Iteration
@@ -152,8 +154,8 @@ def __getitem__(self, value):
                         end = start
                     else:
                         end = value.stop + self.ops.get('start', 0)
-                        if self.ops.get('end', None) is not None \
-                           and value['end'] < end:
+                        if self.ops.get('end', None) is not None and \
+                                self.ops['end'] < end:
                             # truncated by previous slice:
                             end = self.ops['end']
                 else:
@@ -342,5 +344,3 @@ def _throughToRelatedJoin(self, join):
         clause = sqlbuilder.AND(otherClass.q.id == getattr(intTable, join.otherColumn),
                      getattr(intTable, colName) == query.q.id)
         return otherClass, clause
-
-__all__ = ['SelectResults']
diff --git a/sqlobject/tests/test_slice.py b/sqlobject/tests/test_slice.py
@@ -21,31 +21,30 @@ def counterEqual(self, counters, value):
             return
         assert [c.number for c in counters] == value
 
-    def test_1(self):
+    def test_slice(self):
         self.counterEqual(
             Counter.select(None, orderBy='number'), range(100))
 
-    def test_2(self):
         self.counterEqual(
             Counter.select(None, orderBy='number')[10:20],
             range(10, 20))
 
-    def test_3(self):
         self.counterEqual(
             Counter.select(None, orderBy='number')[20:30][:5],
             range(20, 25))
 
-    def test_4(self):
+        self.counterEqual(
+            Counter.select(None, orderBy='number')[20:30][1:5],
+            range(21, 25))
+
         self.counterEqual(
             Counter.select(None, orderBy='number')[:-10],
             range(0, 90))
 
-    def test_5(self):
         self.counterEqual(
             Counter.select(None, orderBy='number', reversed=True),
             range(99, -1, -1))
 
-    def test_6(self):
         self.counterEqual(
             Counter.select(None, orderBy='-number'),
             range(99, -1, -1))
