other kinds of table schema changes + related tests

Gioee · Gioee · commit 4e7940a1aaa8 · 2024-01-30T12:44:07.000+01:00
diff --git a/src/manager.ts b/src/manager.ts
@@ -45,7 +45,7 @@ export class SQLiteManager {
     }
   }
 
-  queryBuilder(op?: AT, column?: SQLiteManagerColumn, newColumn?: string): string {
+  queryBuilder(op?: AT | string, column?: SQLiteManagerColumn, newColumn?: string): string {
     let query = ''
 
     if (this.table.columns) {
@@ -62,6 +62,7 @@ export class SQLiteManager {
         query += ');'
       } else {
         if (typeof op != 'undefined' && column) {
+          let rand: string
           switch (op) {
             case AT.RENAME_TABLE:
               this.query += 'ALTER TABLE "' + this.table.name + '" RENAME TO "' + column.name + '";\n'
@@ -74,6 +75,19 @@ export class SQLiteManager {
               break
             case AT.RENAME_COLUMN:
               if (newColumn) this.query += 'ALTER TABLE "' + this.table.name + '" RENAME COLUMN "' + column.name + '" TO "' + newColumn + '";\n'
+              break
+            default:
+              rand = Math.floor(Math.random() * 1000000000000).toString()
+              this.query += '\n\nPRAGMA foreign_keys = OFF;\n'
+              this.query += 'BEGIN TRANSACTION;\n'
+              this.query += 'ALTER TABLE "' + this.table.name + '" RENAME TO sqlitemanager_temp_table_' + rand + ';\n'
+              this.create = true
+              this.query += this.queryBuilder()
+              this.create = false
+              this.query += '\nDROP TABLE sqlitemanager_temp_table_' + rand + ';\n'
+              this.query += 'COMMIT;\n'
+              this.query += 'PRAGMA foreign_keys = ON;\n'
+
               break
           }
         }
@@ -183,7 +197,7 @@ export class SQLiteManager {
       this.table.columns[i].type = type
     }
 
-    return this.queryBuilder()
+    return this.queryBuilder('', {} as SQLiteManagerColumn)
   }
 
   changeColumnConstraints(name: string, constraints: SQLiteManagerConstraints): string {
@@ -193,7 +207,7 @@ export class SQLiteManager {
       this.table.columns[i].constraints = constraints
     }
 
-    return this.queryBuilder()
+    return this.queryBuilder('', {} as SQLiteManagerColumn)
   }
 
   private findColumn(name: string): number | undefined {
diff --git a/test/manager.test.ts b/test/manager.test.ts
@@ -55,13 +55,18 @@ describe('Create a table', () => {
 
     expect(renTable).toContain('ALTER TABLE "' + testTable.name + '" RENAME TO "' + testTable2.name + '";')
 
-    /* const risCh: string = manager.changeColumnType(testTable.columns[2].name, SQLiteManagerType.TEXT)
-
-    expect(risCh).toContain(SQLiteManagerType[SQLiteManagerType.TEXT])
-    expect(risCh).not.toContain(SQLiteManagerType[SQLiteManagerType.INTEGER])
-
-    const risCnstr: string = manager.changeColumnConstraints(testTable.columns[2].name, testTable.columns[2].constraints)
+    const risCh: string = manager.changeColumnType(testTable.columns[2].name, SQLiteManagerType.TEXT)
 
-    expect(risCnstr).toContain('NOT NULL UNIQUE') */
+    expect(risCh).toContain('PRAGMA foreign_keys = OFF;')
+    expect(risCh).toContain('BEGIN TRANSACTION;')
+    expect(risCh).toContain('ALTER TABLE "' + testTable.name + '" RENAME TO sqlitemanager_temp_table_')
+    expect(risCh).toContain('CREATE TABLE "' + testTable.name + '" ("')
+    expect(risCh).toContain('"' + testTable.columns[2].name + '" TEXT')
+    expect(risCh).toContain('DROP TABLE sqlitemanager_temp_table_')
+    expect(risCh).toContain('COMMIT;')
+    expect(risCh).toContain('PRAGMA foreign_keys = ON;')
+
+    const risCnstr: string = manager.changeColumnConstraints(testTable.columns[2].name, testTable2.columns[2].constraints)
+    expect(risCnstr).toContain('"' + testTable.columns[2].name + '" TEXT UNIQUE')
   })
 })
