Repository navigation
Can't focus Browse Data tables dropdown #908
Description
Details for the issue
Previously, after selecting a table and closing the dropdown, it remained focused, so you could hit the up/down arrow keys to change the table. Now, I can't focus it at all, even with multiple tab key presses.
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- DB4S has a bug
- DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- Windows: ( version: ___ )
- Linux: ( distro: ___ )
- Mac OS: ( version: Siera )
- Other: ___
I'm using DB4S version:
- 3.9.1
- 3.9.0
- Other: Nightly 20.12.2016
I have also:
- Tried out the nightly version: https://github.com/sqlitebrowser/sqlitebrowser#windows
- Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
justinclift commentedon Dec 20, 2016
Interesting. Does the nightly build from yesterday have the same problem? If not, then it narrows the change down to something from yesterday, so easier to investigate. 😄
revolter commentedon Dec 20, 2016
No, it doesn't. Looks like tab index was removed from most of the controls.
justinclift commentedon Dec 20, 2016
Interesting. Nothing from yesterday's changes is really jumping out at me as a smoking gun.
Unless maybe loadPragmas() is having some kind of unintended side effect.
Hmmm, going to assign to @MKleusberg, as it's likely his new code doing it. 😉
revolter commentedon Dec 20, 2016
Neither does the 1st of December Nightly work, so it's probably not something recent. A
git bisectmight help.justinclift commentedon Dec 20, 2016
Ahhh, I thought you meant "No, it doesn't." in response to "Does it have the same problem?".
But you're meaning it does have the same problem?
revolter commentedon Dec 20, 2016
I'm dumb. I wanted to say that it has the problem too. I thought that maybe c221536 is the problem, but the 16th of August Nightly is working ok.
justinclift commentedon Dec 20, 2016
Interesting. You should be able to find out the exact day it started using this manual er... bisect-via-download approach. 😄
revolter commentedon Dec 20, 2016
I'll see if I can continue this at home 😆
Add keyboard shortcut for browse table combo box
MKleusberg commentedon Dec 28, 2016
The tab stops and their order are stored in src/MainWindow.ui (somewhere at the bottom of the file). But I can't see any problem there and they haven't been touched lately.
What I noticed though is this: when I open a database and switch to the Browse Table tab and I can press Tab as much as I want and nothing ever happens. However, as soon as I click on one of the buttons, the combo box or the table view the Tab key starts to work again. Looks like this is how Qt is handling the Tab key on dialogs with a tab widget (any puns on this coincidence are very welcome btw). Is this the same for OS X? I've also pushed a commit which add the Alt+T shortcut to focus the combo box which should help a bit :)
revolter commentedon Dec 28, 2016
That's what I knew about the tab stops and noticed too.
I remember trying this but it still didn't start working.
Will take a look on 4th of January so use the same pc + os version combination.
(there would be awesome if GitHub had a reminder feature)
justinclift commentedon Dec 28, 2016
@revolter OSX → Applications → Reminders.app 😀
chrisjlocke commentedon Dec 28, 2016
Add keyboard shortcut for browse table combo box
revolter commentedon Jan 5, 2017
@MKleusberg I did the following:
Browse Databut nothing happened.
I somehow got it working but it behaved very weird:
I got the tab key to toggle the focus between controls, but when I kept it on the
New Recordand clicked the tables dropdown, the blue outline got removed, as it should, because the dropdown was focused. But when I closed the dropdown, the blue focus outline moved back to theNew Recordbutton instead of remaining on the dropdown.