Repository navigation
Link on "edit pragmas" -> User Version is incorrect #897
Description
Details for the issue
The link on the "edit pragmas' tab for the "User Version" pragma is wrong
Clicking it takes you to http://www.sqlite.org/pragma.html#pragma_schema_version when it should take you to http://www.sqlite.org/pragma.html#pragma_user_version instead
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- DB4S has a bug
- DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- Windows: ( version: ___ )
- Linux: ( distro: ___ )
- Mac OS: ( version: 10.12.1 )
- Other: ___
I'm using DB4S version:
- 3.9.1
- 3.9.0
- Other: ___
I have also:
- Tried out the nightly version: https://github.com/sqlitebrowser/sqlitebrowser#windows
- Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
justinclift commentedon Dec 7, 2016
Thanks @mgrandi, good catch. 😄
revolter commentedon Dec 8, 2016
I noticed this too a couple of weeks ago but looks like I forgot to open an issue. I thought I fixed it too :-?. It looks like the link is in the translation files, so it isn't hard to fix.
Fix link to SQLite documentation in the user version pragma label
MKleusberg commentedon Dec 19, 2016
I've just pushed a commit which fixes this issue :) Iulian is right by the way: the link is also included in the translation files as well (even though it originally comes from the form file), which I didn't see at first. So there's a second commit now which updates all the translation files to hopefully include the fixed link, too.
@mgrandi Can you test tomorrow's nightly build (or any later one) to check if the bug is fixed in there? :)
mgrandi commentedon Dec 19, 2016
sure , i'll do it tomorrow
revolter commentedon Dec 20, 2016
And I didn't know it's in the
.uifile too. Then, why is it in the translations files? If it's the same. Shouldn't we remove it from those altogether?mgrandi commentedon Dec 20, 2016
i downloaded https://nightlies.sqlitebrowser.org/osx/DB%20Browser%20for%20SQLite_20161220.dmg and it seems that all of the links in the edit pragmas tab are not actually clickable anymore (as in they don't open the browser)
EDIT: oh, it seems that they are disabled when not actively editing a database but it isn't obvious that the 'links' are disabled. I created a new database and i can verify that User Version points to the right URL now
MKleusberg commentedon Dec 28, 2016
Thanks for reporting back, @mgrandi ! 😃
I'm going to close this issue then. If anybody is bothered too much by the way the disabled links look, I think this should be a separate issue and unfortunately a little more thinking 😃
Fix link to SQLite documentation in the user version pragma label