Export of database table does not honour quote setting #845

Activity

1. justinclift commented on Oct 25, 2016

   

   justinclift

   on Oct 25, 2016

   Last edited by justinclift

   Member

   More actions

   Oh, interesting. Something doesn't seem correct there.

   It'd be really useful for us to add some kind of automatic testing for this to catch regressions. Not sure how to achieve it though.
2. justinclift

   added

   bugConfirmed bugs or reports that are very likely to be bugs.Confirmed bugs or reports that are very likely to be bugs.

   windows

   on Oct 25, 2016
3. chrisjlocke commented on Oct 26, 2016

   

   chrisjlocke

   on Oct 26, 2016

   MemberAuthor

   More actions

   32bit was the same, and on a different computer, so its not just me... ;)
   Haven't tried older versions to pick out where it went wrong. I'm sure it used to work...
   Looked (briefly) through the code, but without debug info, its hard to find out whats going on .... it should work. Guess I'll add some...
4. prutz1311 commented on Nov 2, 2016

   

   prutz1311

   on Nov 2, 2016

   Contributor

   More actions

   It seems like it has to do with these lines

   sqlitebrowser/src/ExportDataDialog.cpp

   Line 92 in 60e4cb7

   std::string special_chars = newlineStr.toStdString() + sepChar.toLatin1() + quoteChar.toLatin1();

   and

   sqlitebrowser/src/ExportDataDialog.cpp

   Lines 113 to 116 in 60e4cb7

   	if(content.toStdString().find_first_of(special_chars) != std::string::npos)
   	stream << quoteChar << content.replace(quoteChar, quotequoteChar) << quoteChar;
   	else
   	stream << content;

   , that is, it quotes the contents of a field only if there are characters to be escaped. For example, if you have the following data:
   
   you can export like this:

   id,flag
   a,"E""E"
   b,D D
   c,C C
   d,B B
   e,A A

   So maybe we should introduce something like chars_to_quote alongside with special_chars?
5. justinclift commented on Nov 3, 2016

   

   justinclift

   on Nov 3, 2016

   Member

   More actions

   Interesting thought. 😄

   Thinking about this more, it sounds like Chris wants an option to "quote all fields", even if the quotes are not strictly needed.

   Hmmm... trying to think of a use for that though... not sure what it would be useful for? 😄
6. chrisjlocke commented on Nov 3, 2016

   

   chrisjlocke

   on Nov 3, 2016

   Last edited by chrisjlocke

   MemberAuthor

   More actions

   Aah, might just be me then. I was under the mis-conception that fields with spaces in would need quoting (not just escaping quote characters). Thats why 'A' would not need quoting, but 'A A' would. I must just be having a brain fart then. I'll close this then, and revisit it if its an issue. 😄
7. chrisjlocke

   closed this as completedon Nov 3, 2016
8. justinclift

   removed

   bugConfirmed bugs or reports that are very likely to be bugs.Confirmed bugs or reports that are very likely to be bugs.

   windows

   on Nov 3, 2016
9. justinclift commented on Nov 3, 2016

   

   justinclift

   on Nov 3, 2016

   Member

   More actions

   Cool. 😄