Skip to content

Default font size on OSX is too small #818

Closed

Description

@OneMHz

Details for the issue

In the latest version (3.9.1) for Mac, the font on the SQL Editor is very small and I can't see a way to change it.

I have a very large monitor, but it isn't a HiDPI display. On the built-in retina display, the font is more readable, but still tiny.

Useful extra information

screen shot 2016-10-12 at 8 49 36 am

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: 10.12 Sierra )
  • Other: ___

I'm using DB4S version:

  • 3.9.1
  • 3.9.0
  • Other: ___

I have also:

Activity

  1. justinclift commented on Oct 12, 2016

    @justinclift
    Member

    As a thought, have you tried adjusting things in Preferences → SQL?
    screen shot 2016-10-12 at 16 57 38
    In theory, the "SQL editor font" and the font size field below it should control that.

    If that's not working for you, let us know so we can investigate. 😄

  2. OneMHz commented on Oct 12, 2016

    @OneMHz
    Author

    Well, I'm an idiot. I thought I went through all of the tabs. Shows me for reporting yesterday's issue today before trying again.

  3. justinclift commented on Oct 12, 2016

    @justinclift
    Member

    No worries at all. We all do things like that occasionally. 😉

  4. revolter commented on Oct 12, 2016

    @revolter
    Member

    I remember I had the same problem when I first installed DB4S. Could we bump up the default size?

  5. OneMHz commented on Oct 12, 2016

    @OneMHz
    Author

    I think part of it was that I saw font settings on the data browser tab and tried them and then had my attention pulled away. Might be useful to group the font settings into one area/tab?

    Unrelated, has anyone else had an issue with the data browser font and background color resetting to black on black when the app starts up?

  6. revolter commented on Oct 12, 2016

    @revolter
    Member

    For sure! Here it is: #737. I also noticed it too while working on another issue. Needs to be solved.

  7. justinclift commented on Oct 12, 2016

    @justinclift
    Member

    Ahhh, so the black on black thing wasn't just a one-off something. Seems like there's something about Sierra which is triggering it.

    We'll probably need to raise the priority of it then, as Sierra is now in use by people.

  8. justinclift commented on Oct 12, 2016

    @justinclift
    Member

    @revolter If you want to increase the default font size, go for it. 😄

  9. revolter commented on Oct 12, 2016

    @revolter
    Member

    As a curiosity, @OneMHz, what font size did you use?

  10. OneMHz commented on Oct 12, 2016

    @OneMHz
    Author

    It was on 9. I bumped it to 12. Part of me thinks it could do with 13 or 14 even, but the rest of me thinks I'm getting to old for my own good if I need that big a font.

  11. revolter commented on Oct 12, 2016

    @revolter
    Member

    I was thinking to bump it up to 12 too. I'll wait for more opinions then I'll do it, thanks!

  12. MKleusberg commented on Oct 12, 2016

    @MKleusberg
    Member

    I have it on 8 and it is still quite large?! Using the Bitstream Vera Sans Mono font. Writing text on a computer screen is so weirdly complicated.. ^^

  13. revolter commented on Oct 12, 2016

    @revolter
    Member

    Hmm, I use 12 on a MacBook Pro Retina and an older iMac and it's not too small and not too large :-?

  14. justinclift commented on Oct 12, 2016

    @justinclift
    Member

    Heh Heh Heh, it might be practical to #ifdef the default to be OS specific.

  15. 31 remaining items

  16. justinclift commented on Oct 14, 2016

    @justinclift
    Member

    No worries. 😄

    With DB4S there are two settings for font size in Preferences, each affecting different things.

    To change the font size for the Browse Data tab, go to Preferences → Data Browser → Font → Font size:
    screen shot 2016-10-14 at 01 44 31
    To change the font size for the Execute SQL tab, go to Preferences → SQL → SQL editor font size:
    screen shot 2016-10-14 at 01 45 19
    Does that help?

  17. whamsy commented on Oct 14, 2016

    @whamsy

    @justinclift I did go through the thread and figured that out from an earlier comment of yours. Thanks a lot for posting it again though :)

    I was just wondering since there appeared to be a shortcut to decrease font size (in the Execute SQL tab), was there anything similar to increase font size as well.

  18. justinclift commented on Oct 14, 2016

    @justinclift
    Member

    Ironically... I didn't know/remember about the ⌘+- key combination. 😉

    Testing it here now though... and yep it works. At a guess, it might be something we inherit from one of the widgets we embed (QScintilla). But not sure.

    Trying out ⌘++, it works for me if I use the + key on the number pad (I'm using a full sized PC keyboard via usb). But it doesn't work for me using the + key on the main keyboard. 😦

  19. chrisjlocke commented on Oct 14, 2016

    @chrisjlocke
    Member

    it works for me if I use the + key on the number pad but it doesn't work for me using the + key on the main keyboard

    There's a similar quirk in Windows. With date picker controls (eg:
    image
    You can click on the day and use the + and - to go forward/back a day.... unless you use the +/- on the main keyboard, when it does nothing. Annoyingly it doesn't work on my laptop either. 👎

  20. justinclift commented on Oct 17, 2016

    @justinclift
    Member

    @chrisjlocke I'd like to close this issue, as the default font size on OSX has been adjusted.

    If you pick new font size for Windows, we can change it as well. 😄

  21. ghellquist commented on Dec 9, 2016

    @ghellquist

    Hmm.
    The code has been changed, but default value is still 9 when I run the program, version 3.9.1.
    Could there be some error in build system, not setting Q_OS_MAC correctly? (Or is this simply not yet in version 3.9.1)

    (Code is in Settings.cpp, line 200 and forward).

    
        // editor/fontsize or log/fontsize?
        if((group == "editor" || group == "log") && name == "fontsize")
    #ifdef Q_OS_MAC
    	// Use 12 pt size as the default on OSX
            return 12;
    #else
            return 9;
    #endif
    
  22. justinclift commented on Dec 9, 2016

    @justinclift
    Member

    @ghellquist Yeah, this was added after the 3.9.1 release, so (in theory) it should be in the nightly builds from a few weeks after that release.

  23. ghellquist commented on Dec 9, 2016

    @ghellquist
  24. justinclift commented on Dec 9, 2016

    @justinclift
    Member

    No worries at all. Sorry if I was a bit abrupt, it's been one of those days... 😦

    The download locations for our nightly builds are on the front page of our repo if that helps. 😄

  25. ghellquist commented on Dec 9, 2016

    @ghellquist
  26. justinclift commented on Jan 27, 2017

    @justinclift
    Member

    Closing this now, as it seems to be fixed. 😄

    (if that's not the case, this is welcome to be reopened)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions