Repository navigation
Large spacing in 'cannot create indexes' dialog #771
Description
Details for the issue
Added a field to my database, and DB4S struggled to put back some indexes. Bit weird, as there was no reason why it shouldn't have been able to do it - I was adding a field, not deleting any. Aah well, no biggie. However, the dialog was a bit 'caca' with a huge gap.
This was with the nightly, so not sure if its in 3.9 ... will try again and have a look...
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- DB4S has a bug
- DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- Windows
- Linux: ( distro: ___ )
- Mac OS
- Other: ___
I'm using DB4S version:
- 3.9.0
- 3.8.0
- Other: 3.9.99
I have also:
- Tried out the nightly version: https://github.com/sqlitebrowser/sqlitebrowser#windows
- Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
chrisjlocke commentedon Sep 9, 2016
I assume there is no log as to why recreating these indexes failed? Running the statements in the above dialog worked flawlessly. No errors (after the table was recreated by DB4S) appeared in the SQL log...
justinclift commentedon Sep 9, 2016
Interesting. This kind of thing suggests that writing to a log somewhere is probably a good idea.
If you can reproduce the problem, try starting DB4S from the command line (eg from DOS window, Powershell, etc). Sometimes debug messages turn up there, so it's probably a useful thing to check, just in case. 😄
Fix altering tables with multiple indices
MKleusberg commentedon Oct 13, 2016
I think this bug should be fixed with the latest commit. DB4S now removes any whitespace from the SQL commands shown in the message box and this sort of whitespace is the only reason I can imagine the message box looking like this.
Also we now put a semicolon at the end of each SQL command. Before, those two commands weren't separated by one and that might have been the cause of the message box to begin with.
So in short: the whitespace should be gone. Also you hopefully won't be able to confirm this so easily because that error shouldn't appear anymore 😉
chrisjlocke commentedon Oct 13, 2016
Ex cellent! The 'we can't recreate the indexes' was popping up a lot, and guess (in hindsight) I can see why now, as those tables would have had more than one index...
MKleusberg commentedon Oct 13, 2016
I had exactly the same thought ^^ It all makes sense now.
Do you have the time to do one little test or two with the next nightly build, so we can be sure it's safe to close this issue?
chrisjlocke commentedon Oct 13, 2016
Will gladly test tomorrows nightly. 😀
revolter commentedon Oct 21, 2016
@chrisjlocke Did you manage to test this? 😄
chrisjlocke commentedon Oct 21, 2016
I've tested the nightlies, and can't reproduce the error, so thats a good thing! Consider it closed, and I'll yell if it comes up again! 😉
Fix altering tables with multiple indices