You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ever since commit 8a91308, I cannot build sqlitebrowser:
> git checkout 8a9130883b9e89d57d33b6c3a0ee8ee59ce9957b
Previous HEAD position was e7b1233... Fix bug introduced in 684958b29ce3d26684d9142d73df773b11189d54
HEAD is now at 8a91308... Update installer variables on Windows, update Qt5 path
user@fly:~/bin/sqlitebrowser> cmake .
-- Could NOT find Antlr2 (missing: ANTLR2_LIBRARIES ANTLR2_INCLUDE_DIRS)
-- Found Qt4: /usr/local/bin/qmake-qt4 (found version "4.8.7")
-- Found Qt4: /usr/local/bin/qmake-qt4 (found version "4.8.7")
CMake Warning (dev) at CMakeLists.txt:271 (add_executable):
Policy CMP0037 is not set: Target names should not be reserved and should
match a validity pattern. Run "cmake --help-policy CMP0037" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
The target name "DB Browser for SQLite" is reserved or not valid for
certain CMake features, such as generator expressions, and may result in
undefined behavior.
This warning is for project developers. Use -Wno-dev to suppress it.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/user/bin/sqlitebrowser
user@fly:~/bin/sqlitebrowser> make
make[1]: don't know how to make CMakeFiles/DB\. Stop
make[1]: stopped in /home/user/bin/sqlitebrowser
*** Error code 2
Stop.
make: stopped in /home/user/bin/sqlitebrowser
commit e7b1233 does not resolve the issue, either.
On dragonflybsd master:
DragonFly v4.7.0.270.gc211e-DEVELOPMENT #21: Mon Aug 29 13:07:08 PDT 2016
As a thought, would you be ok to try the build with qmake instead of cmake?
That's a curiosity thing on my part, just to understand if qmake works ok on DragonFly BSD. 😄
Regardless of that, I've just pushed a commit to the master branch which should fix the CMake issue. In theory. If you have the time/inclination to test that, it would be cool. 😄
Activity
Rename main CMake project name variable back to "sqlitebrowser".
justinclift commentedon Aug 31, 2016
As a thought, would you be ok to try the build with
qmakeinstead ofcmake?That's a curiosity thing on my part, just to understand if
qmakeworks ok on DragonFly BSD. 😄Regardless of that, I've just pushed a commit to the
masterbranch which should fix the CMake issue. In theory. If you have the time/inclination to test that, it would be cool. 😄jungle-boogie commentedon Aug 31, 2016
Hi @justinclift,
Prior to doing the git pull, I attempted t use qmake:
/usr/local/lib/qt5/bin/qmakejungle-boogie commentedon Aug 31, 2016
Hi @justinclift,
cmake build also fails after a
git pullcmake .justinclift commentedon Aug 31, 2016
Damn. 😦
Just to double check, did you reset & clean the git tree before attempting those? eg:
That's just me hoping the build failed due to left over files from the previous run. 😁
If that's definitely not the case, then what happens if you roll the git repo back a few commits, to just before the change I made? eg:
jungle-boogie commentedon Aug 31, 2016
Hi @justinclift,
You saved the day! resetting head and cleaning it worked with qmake! I'll close this issue and see what happens on #755 tomorrow!
Thanks,
sean
justinclift commentedon Aug 31, 2016
Excellent. 😄
Rename main CMake project name variable back to "sqlitebrowser".