Skip to content

Too many margin #620

Closed
Closed

Description

@dridk

I suggest to remove some margin arround the treeview. It's not clear actually and it looks like 90's app.
I did it for my Qt apps, and it looks better : http://dridk.github.io/cuterest/

Activity

  1. justinclift commented on Jun 9, 2016

    @justinclift
    Member

    Hmmm, looking at your screenshot... not seeing what you mean?

  2. dridk commented on Jun 11, 2016

    @dridk
    ContributorAuthor

    I mean layout margin as you can see here :
    gc1

  3. dridk commented on Jun 11, 2016

    @dridk
    ContributorAuthor

    gc1
    In Red, margin to remove. Tree view should fill all the content

  4. justinclift commented on Jul 30, 2016

    @justinclift
    Member

    Adding this 3.10.0 milestone, as it wouldn't hurt for us to at least investigate the possibility. 😄

  5. MKleusberg commented on Feb 2, 2017

    @MKleusberg
    Member

    Just pushed a commit that reduces the margin in there. There's more we could do to make this look better but I'm not sure we should. One reason is that this would mean the Database Structure tab would start looking different from the rest of the application. Another reason is that Qt does all sorts of things to make applications appear in different ways on different platforms and I'm not sure how much we want to interfere with that.

    That being said, what does everyone think of the reduced margin? 😃

  6. justinclift commented on Apr 6, 2017

    @justinclift
    Member

    Looking at this again now, and the reduced margin seems fine to me. 😄

  7. justinclift commented on Apr 6, 2017

    @justinclift
    Member

    @dridk Do you have a few minutes to try out a recent nightly build, and let us know if the reduced margin is now how you were meaning? 😄

  8. chrisjlocke commented on Apr 6, 2017

    @chrisjlocke
    Member

    this would mean the Database Structure tab would start looking different from the rest of the application.

    The other areas are now looking 'different' to the database structure tab. So the docked SQL Log, DB Schema, etc, now have the extra margin.

    Personally, I prefer 'some' margin.

    So this is how it is currently (latest nightly)

    image

    In my opinion, this would look odd:

    image

    (with no right margin)
    But it looks better with no left margin... although now you've got a big gap in the middle between the two tab controls.

    In the same vein, losing the left margin on the 'browse data' tab looks slightly better (which you can't replicate for the right margin)

    image

    Although you don't exactly gain a lot of screen space by doing it!

  9. justinclift commented on Apr 6, 2017

    @justinclift
    Member

    Hmmm, yeah not sure. On OSX with the latest source, the margins still seem to be there:
    screen shot 2017-04-06 at 17 28 03

  10. justinclift commented on Nov 22, 2017

    @justinclift
    Member

    Do we still need to do something for this issue? I'm kind of thinking "no". 😄

  11. chrisjlocke commented on Nov 22, 2017

    @chrisjlocke
    Member

    As above in my comment, some areas look slightly better if you remove one side of the margin, but weird on others. Its something we can look at later... when we do a full UI revamp maybe!
    I vote to close for now, but at least place on the back burner (or at least near a small candle.....)

  12. justinclift commented on Nov 22, 2017

    @justinclift
    Member

    Meh, let's close it. We have enough other things to get done anyway. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions