Repository navigation
Support JPEG BLOBs #579
Description
What is required to support JPEG in BLOB typed columns?
I see there's PNG and BMP, both huge files especially if you store stuff in DB (=you have many rows), what's the reason for no JPEG yet?
The JPEG encoder/decoder at http://www.ijg.org/ works nicely, I just integrated it myself in Java JNI few weeks ago.
Activity
justinclift commentedon Apr 27, 2016
@MKleusberg Thoughts?
MKleusberg commentedon Apr 30, 2016
We're supporting whatever image formats are supported by Qt. Qt does support JPEG and on my (Linux) system DB4S therefore supports JPEG, too. However, the Qt developers have moved most images formats out of their library and into plugins. So for our Windows release, we'd need to distribute these plugins, too (or at least the JPEG one, that is). I hope this makes sense 😀 So in effect, this is a distribution issue, not a code issue. Could be that the JPEG plugin is linked into the nightly builds, too; so that might be worth giving a try as well.
justinclift commentedon Apr 30, 2016
Ahhh, that's interesting.
@TWiStErRob Which OS are you using? 😄
TWiStErRob commentedon Apr 30, 2016
Windows 7 SP1 x64, and I can confirm that the nightly build handles the JPEG BLOBs and the latest release doesn't.
Nightly: 3.8.99 QT 4.8.7 SQLite 3.12.0
Latest: 3.8.0 QT 5.5.1 SQLite 3.9.2
MKleusberg commentedon Apr 30, 2016
@justinclift This might also be interesting for your instructions for compiling on Windows. It'd be nice to have an extra directory called 'imageformats' inside the app dir. In this directory you have to copy some or all of the DLLs in ...\Qt Directory\Qt Version\plugins\imageformats.
TWiStErRob commentedon Apr 30, 2016
Looking at the extensions list in the import dialog:
3.8.0:
3.8.99:
justinclift commentedon Apr 30, 2016
@MKleusberg Doesn't sound like it'll be a problem. I'll just need to understand better what needs to be added, and where. 😄
Is this something extra we need to add/tick/enable for the Qt installation step (Qt install step in development here):
https://github.com/justinclift/sqlitebrowser/wiki/Win64-setup-—-Step-7-—-Install-Qt
Or is it more of something to do prior/post compiling of DB4S?
https://github.com/justinclift/sqlitebrowser/wiki/Win64-setup-—-Step-13-—-Compile-DB4S-using-MSVC
@TWiStErRob As a thought, if you're interested in compiling DB4S on Windows, it'd be super useful having someone go through those instructions and test them out for Win 7. I'm writing them up using Win 8.1, so I've been assuming they'll work on Win 7 the same. But it would be good to have someone actually check, to make sure. 😉
Note, I'm still going through those docs (right now, working on Step 8), replacing/fixing screenshots, tweaking wording, etc. So, feel free to point out or ask things as needed.
justinclift commentedon Apr 30, 2016
@MKleusberg Hmmm, reading over your comment again... it's more something we need to add to the packaging step isn't it? If so, we can probably add it into the NSIS package script, so it works "out of the box" for everyone.
TWiStErRob commentedon Apr 30, 2016
Holy-moly I thought this was the full docs for that :) Sorry, but I don't have time right now, and I'm planning to update to Windows 10 soon, so you're probably better off setting up a VM.
justinclift commentedon Apr 30, 2016
Sure, no worries at all. 😉
(and yeah, it turns out to be a fairly involved process) 😧
justinclift commentedon Aug 18, 2016
Hmmm, if the solution to fixing it is as easy as shown in the answer here, we can probably do this for 3.9.0:
https://stackoverflow.com/questions/6724606/include-the-jpeg-plugin-in-my-application
7 remaining items
justinclift commentedon Nov 7, 2017
Just investigated this for OSX. It turns out that on OSX we already bundle the required image format plugins, as we're using the Qt provided
macdeployqttool. That automatically includes all of the image format plugins.This is what's included with our 3.10.1 release:
Note that it's including the DDS, TIFF, and WEBP formats which we're skipping on Windows at the moment.
I guess the question is should we start including the TIFF and WEBP ones now (in Windows)?
MKleusberg commentedon Nov 11, 2017
Hmm, maybe not include them and add them if somebody asks for them? But I guess nobody will really use them, especially inside databases.
Does JPEG work on OS X then? Or are they just bundled but not loaded?
TWiStErRob commentedon Nov 15, 2017
hint 😉, hint 😉; sorry I didn't have any computer time recently
I would probably be using WebP if my Android target allowed it, but my minimum supported level is too low as of now. Note: Did you think anyone would use JPEG?
MKleusberg commentedon Nov 17, 2017
Fair enough 😉 WEBP might be useful for somebody 😄 No idea about the licence thing though.
@justinclift Is it working on OS X? Or do we need to add some extra code, too?
justinclift commentedon Nov 17, 2017
Haven't actually tested the WEBP extension, as I just assumed it would be working. The JPEG one definitely does. 😄
We don't need to write any extra code. Instead, we just need to add text to the About dialog mentioning the two projects (TIFF, WEBP) and a link to them. I think that'll satisfy their licence requirements.
For OSX I still need to update our build script to delete the DDS extension during the process. We really don't want to ship things with security holes. 😄
Hmmm... it might be better to update our OSX Qt build to use Qt 5.9.2 instead. I don't think there's any strong reason for us to keep with 5.7 on that platform, unlike Windows where we need it for XP compatibility.
This is probably something I'll get done tonight. 😄
justinclift commentedon Nov 17, 2017
Just updated the OSX build box to use Qt 5.9.2, and ran the nightly build script to make sure it works. That fixes the DDS extensions security problem.
Next steps:
justinclift commentedon Nov 17, 2017
Tried adjusting the About dialog to include the TIFF and WebP license info, but it was just way too much text and didn't feel like the right approach.
Instead of that, we now have a new "LICENSE-PLUGINS" text file in the top directory with the plugin license info in it and a brief description of what it's for. That should satisfy their license requirements and also not be confusing for people. 😄
justinclift commentedon Nov 17, 2017
Ahhh, just realised that new license info text file will need to be bundled with the OSX and Windows installs too. I'll look into that tomorrow.
MKleusberg commentedon Nov 17, 2017
Cool, that sounds like progress 😃
Glad it's working on OS X. I was afraid we need to add some more code to point the plugin loader to the app dir or something.
justinclift commentedon Nov 17, 2017
Just updated the CMake build file to include the TIFF and WebP formats on Windows. Tomorrow I'll look into updating that to include the new plugin license file too. Same will need to be done on OSX. Shouldn't be too hard for either. 😄
justinclift commentedon Nov 18, 2017
The OSX builds now include both the LICENSE and LICENSE-PLUGINS text files in the .dmg (rebuilt todays nightlies, just to make 100% sure).
Windows ones next. That'll be a CMake change... might put it off until tomorrow though. 😄
justinclift commentedon Nov 19, 2017
Just updated the CMake build file for Windows, so the LICENSE and LICENSE-PLUGINS files are now installed in the DB4S directory (under "licenses") along with the rest of our file set. They're also removed when uninstalling too (checked, just to be sure).
In theory, I think that's everything that needs to be done for this issue. If someone has time to check the nightly builds from tomorrow onwards on Win32/64 and verify JPEG is working + the license files are included in the install dir, that would be great. 😄
@TWiStErRob @chrisjlocke @karim Would any of you have time to check that? 😄
justinclift commentedon Dec 9, 2017
Closing this as the image support is definitely now working in OSX and Windows, which is "good enough". 😄