Repository navigation
Edit box is not updated at all (as in 'Browse Data') when in 'Execute SQL' #481
Description
To reproduce:
Type some SELECT into the SQL and execute it (BTW, CTRL-ENTER does not work for that, only F5 -- this is another issue).
The result will show up in a grid box, but going to the cells will not update the Edit Box (even though in read-only mode just like a View)
Activity
justinclift commentedon Jan 6, 2016
Oh, that's not good. @MKleusberg, another one for you. 😉
Thanks for continuing to test and report stuff @tonypdmtr. 😄
MKleusberg commentedon Jan 27, 2017
Just tested this using the latest version and it seems to work. I think we've fixed this quite some time ago to be honest. Are we ok to close this issue? 😃
justinclift commentedon Jan 27, 2017
Hmmm, not sure. @tonypdmtr ?
tonypdmtr commentedon Jan 28, 2017
Still does not work with the keyboard -- moving from cell to cell does not update the edit box. It only with mouse clicks.
The CTRL-ENTER issue is OK.
(BTW, what happened to the statically built daily releases?)
justinclift commentedon Jan 28, 2017
@tonypdmtr Thanks for checking. 😄
We dropped the statically built window's nightlies a few months ago, when we switched to supporting Qt5 only. The static builds relied on Qt4, so that approach no longer worked.
Thus new nightlies. Dynamic build though.
The build script we use for Windows is here, if that's useful:
https://gist.github.com/justinclift/11cc926f214e882c8162f97c53929c07
If you have ideas on how to tweak/change it to make things better, we're open to improvements. 😄
Note - It looks more complicated than it is, as it runs through twice. Once for Win32, and once for Win64.
justinclift commentedon May 17, 2017
@tonypdmtr Reading through your original report for this... I think we might have been misunderstanding it.
When running a SQL query in the "Execute SQL" tab on yesterdays's nightly OSX build, the results show up in the window pane below. I didn't personally think the result pane was hooked up to the "Edit Database Cell" er.. dockable window thing 😉 at all, but you're right. When I click on one of the results with the mouse, it shows up in the "Edit Database Cell" window:
But, moving around the result pane cells with the keyboard doesn't change what's shown in the "Edit Database Cell".
I guess we need to think over whether things from the result pane should be shown in the "Edit Database Cell" or not, then either fully unhook things (eg so mouse click doesn't show results there), or properly-hook-things up (eg including the keyboard).
What're your thoughts on the direction we should go? I'm trying to figure out how/where/why it'd be useful to have them editable. 😄
tonypdmtr commentedon May 17, 2017
Well, I didn't say it should be editable. However, the reason IMO you need the read-only edit box is because long cell contents are easier to read that way, rather than directly from the grid cell.
justinclift commentedon May 17, 2017
Ahhh, that makes good sense. Hadn't thought of it that way at all.
Yeah, we should probably hook up the keyboard keys with the Edit Database Cell contents there too then.
Add selecting fields in Execute SQL tab for Edit Cell dock via keyboard
MKleusberg commentedon May 19, 2017
Thanks for the detailed explanation, @tonypdmtr 😄 I've just changed the code to allow include selection via keyboard, however it's not that easy as you can see here. On some platforms you'll need to press Enter to trigger the action, i.e. first change the selection by using the arrow keys, then press Enter to show the contents. I'm not sure either what they mean by "depends on the platform"
Anyway, what do you reckon? Is the new approach (it'll be in the next nightly build) workable? Or should we add extra code to make it happen without the Enter key being needed? And if so, how should we handle multi-selection when multiple fields are selected?
tonypdmtr commentedon May 21, 2017
Indeed, now ENTER is needed all the time for both keyboard and mouse. (This feels awkward to me. It's certainly worse for mouse users as they now have to use both mouse and keyboard.)
I'm not sure of the previous mouse behavior but didn't it update the edit box with each mouse click? If so, then perhaps the mouse click event could be 'manually' called whenever the grid cell is changed by keyboard, no? (I suppose there is some way to detect that, I don't know QT.)
Regarding multi-selection, the edit box should always show the most recently accessed grid cell contents.
sky5walk commentedon Dec 28, 2018
I still have this bug with nightly v181222?
I have to hit [Enter] or [Left-mouse-Double-Click] to update the cell editor.
Make the Edit Cell Dock to update with the selected cell in SQL results
mgrojo commentedon Dec 28, 2018
I've made the same signal/slot connection as for the Browse Data table. Both tables behave now the same. Don't know if there could be any unwanted side effect but I haven't found any. @sky5walk Please, test with tomorrow's build and report any nuisance.
sky5walk commentedon Dec 29, 2018
181229 nightly works 😄
mgrojo commentedon Dec 29, 2018
Thanks. I think this can be closed, then.
Make the Edit Cell Dock to update with the selected cell in SQL results