shortcut Strg + Enter doesn't work in 64-bit version

Details for the issue

I've downloaded and installed first 64-bit then 32-bit Version today.
Version 3.11.2

Typing Strg+Enter in SQL-Editor starts execution in 32-bit Version but is ignored in 64-bit Version whereas Strg+R works fine in both. Why is that?

running on Win 7, but I've encountered this on other win-systems as well.

Useful extra information

I'm opening this issue because:

DB4S is crashing
[ x] DB4S has a bug
DB4S needs a feature
DB4S has another problem

I'm using DB4S on:

[ x] Windows: ( version: 7 )
Linux: ( distro: ___ )
Mac OS: ( version: ___ )
Other: ___

I'm using DB4S version:

[x ] 3.11.2
3.11.1
3.10.1
Other: ___

I have also:

Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20

That's a bit unclear. Which key is "Strg"? 😄

Strg is German for Ctrl (or more technically, Steuerung means control)

Interesting. Haven't tested this to confirm, but first potential guesses (without checking) are:

Something to do with the Qt versions for our 32 and 64 bit builds being different?
Possibly some key combination thing messed up in the German translation (?). Not sure why it would only be on the 64-bit version though. 😦

@horst-p-w-neubauer

Interesting. Haven't tested this to confirm, but first potential guesses (without checking) are:

Something to do with the Qt versions for our 32 and 64 bit builds being different?

Probably. Or maybe missing translation files. @horst-p-w-neubauer are the general button labels in dialogue translated? How is the Control key translated in standard entries like in standard contextual menus.

Possibly some key combination thing messed up in the German translation (?). Not sure why it would only be on the 64-bit version though. 😦

What we have seen at other issues is: if you translate the key names, you have to match the translation used by Qt. And Spanish, at least once they've changed the abbreviated translation for the Shift key.

It's all translated zu German.

Funny, If I Change the setting to English Ctrl+Enter works fine. Thx for this idea!

@horst-p-w-neubauer

No worries @horst-p-w-neubauer. It probably means there's something with our german translation strings that needs looking at. 😄

It might be something @FriedrichFroebel has time to investigate at some point. 🙏

@justinclift

@justinclift, is there a way I can contribute to this project. It seems not to be open for everybody - but maybe I just have some troubles with the security stuff.

@horst-p-w-neubauer

@horst-p-w-neubauer - hop on gitter and we can find someone to walk you through details/roadblocks. Sounds like your multilingual skills could be most useful.

thanks I seem to have found a way to fork and create a pull request

I found the same behavior in 6 other languages
in these 7 languages Ctrl+Return doesn't work in the sql-tab:
Arabic, Chinese(China), Frensh, German, Italian, Korean, Portuguese

in these 10 languages Ctrl+Return works proper in the sql-tab
Chinese(Taiwan), Czech, 2xEnglish, Japanese, Polish, Russian, Spanish, Turkish, Ukrainian

this may help locate the issue:
Chinese(China) translates in sqlb-zh.ts to

    <message>
        <location filename="../MainWindow.ui" line="1497"/>
        <source>Ctrl+Return</source>
        <translation>Ctrl+å›žè½¦</translation>
    </message>

as Chinese(Taiwan) doesn't

    <message>
        <location filename="../MainWindow.ui" line="1497"/>
        <source>Ctrl+Return</source>
        <translation>Ctrl+Return</translation>
    </message>

```If checked the complete list. All those who don't work translate the shortcut. the working ones don't transalte.

the same with other translated shortcuts.
e.g. Ctrl+P in TableBrowser.ui
translated in German to Strp+P - doesn't work
There is no difference in Shortcuts comming from .ui files to those, comming fom .cpp file
if the shortcut gets translated - it doesn't work
e.g. Ctrl+W in MainWindow.cpp
translated in German to Ctrl+P - doesn't work

Shortcuts working without explicit translation but show translated on UI:

I found the same behavior in 6 other languages

Good work! 😄

We'll need to get this fixed (as much as practical) for the 3.12.0 release.

@mgrojo

thx for analyzing, @mgrojo
As there are remappings - I'd vote for clearing .ts files from all non regular key-expressions and resetting them. And explainig it on wiki/Translations.

Agreed and made into a pull request #2235.

Removed all translations of key shortcuts.

Avoid unchanged translation of keyboard shortcuts to work around prob…

Removed all translations of key shortcuts.

@horst-p-w-neubauer

@horst-p-w-neubauer, can we close this? The only remaining step is merging it to the 3.12.x branch, but this can be done at the same time including everything we want to release, if they haven't resulted in any issue.

Removed all translations of key shortcuts.

Closing this as I'm pretty sure it's complete. 😄

Removed all translations of key shortcuts.

Navigation Menu

Repository navigation

shortcut Strg + Enter doesn't work in 64-bit version #2178

Details for the issue

Useful extra information

I'm opening this issue because:

I'm using DB4S on:

I'm using DB4S version:

I have also:

10 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

shortcut Strg + Enter doesn't work in 64-bit version #2178

Description

Details for the issue

Useful extra information

I'm opening this issue because:

I'm using DB4S on:

I'm using DB4S version:

I have also:

Activity

justinclift commented on Apr 7, 2020

chrisjlocke commented on Apr 7, 2020

justinclift commented on Apr 7, 2020

mgrojo commented on Apr 7, 2020

horst-p-w-neubauer commented on Apr 8, 2020

horst-p-w-neubauer commented on Apr 8, 2020

justinclift commented on Apr 10, 2020

horst-p-w-neubauer commented on Apr 17, 2020

scottfurry commented on Apr 17, 2020

horst-p-w-neubauer commented on Apr 17, 2020

horst-p-w-neubauer commented on Apr 22, 2020

horst-p-w-neubauer commented on Apr 22, 2020

horst-p-w-neubauer commented on Apr 22, 2020

horst-p-w-neubauer commented on Apr 23, 2020

justinclift commented on Apr 26, 2020

10 remaining items

mgrojo commented on May 9, 2020

mgrojo commented on May 24, 2020

justinclift commented on Jun 8, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions