Repository navigation
[Nightly] Renaming table fails with error copying data #1725
Description
Details for the issue
What did you do?
Modified a table by renaming it
What did you expect to see?
No error
What did you see instead?
The table 'currentUsage' is the original name. Originally I tried renaming it to something else, but for the purpose of this issue, I appended a 'u' to the end, as shown in the screenshot.
So simply, the copying code is looking at the old name, not the new name,
Useful extra information
@MKleusberg attacked this code recently following a couple of other issues, and I thought I'd tested this, but the 'error copying data' is a new issue...
The info below often helps, please fill it out if you're able to. :)
What operating system are you using?
- Windows: ( version: 10___ )
What is your DB4S version?
- Version 3.11.99 (Jan 24 2019)
Did you also
- Try out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
- Search for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
[-]Renaming table fails with error copying data[/-][+][Nightly] Renaming table fails with error copying data[/+]MKleusberg commentedon Feb 9, 2019
Works fine for me 😕 Can you paste the full table schema here? And did you change anything besides the table name?
chrisjlocke commentedon Feb 10, 2019
When you're testing, does your table have a primary key? Tables with no primary keys set seem to rename OK. Tables with the first field as a primary key (specifically an INTEGER) seem to fail.
(had to experiment a lot to work that out...!)
https://screencast-o-matic.com/watch/cqn66c3KZ6 (apologies for the cheesy music - it wanted to do that, not me!)
Fix alterTable() function
MKleusberg commentedon Feb 15, 2019
You are right - I didn't check with a primary key. But I believe I know what was causing the problem and I already committed a fix. This one will need some good testing though 😄
justinclift commentedon Feb 15, 2019
The other test builds are finished, so I'll rerun todays standard nightly build script for Win64. That'll give something for testing sooner, in case it's useful. 😄
MKleusberg commentedon Feb 15, 2019
Awesome 👍 Lots of building and lots of cherry-picking for today then 😉
justinclift commentedon Feb 15, 2019
Yep. 😉
chrisjlocke commentedon Feb 15, 2019
🍒🍒🍒 🌸 💥
justinclift commentedon Feb 15, 2019
Just watched the screencast (above). That was done well, really clear, etc.
Music wasn't tooooooooooo cheesy either. 😄
chrisjlocke commentedon Feb 15, 2019
I got quite used to the music and liked it after a while! 😆 🙉
justinclift commentedon Feb 15, 2019
Updated Win64 build for today is online:
chrisjlocke commentedon Feb 15, 2019
Thanks @justinclift for creating the builds.
Renaming a table now works, but a few 'issues' if that table belongs to a view. Have reported that in that thread.
Added a field, and removed a field, and that all worked too.
Thanks @MKleusberg.