Skip to content

Compile errors with MSVC 2017 #1592

Closed
Closed

Description

@justinclift

Trying to build master at the moment, using MSVC 2017.

One (so far) error is occurring. This is when compiling using MSVC from the command line:

> devenv /Build Release sqlitebrowser.sln /project "PACKAGE"

The error:

...
UniConversion.cpp
ViewStyle.cpp
XPM.cpp
mocs_compilation.cpp
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(70): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2325): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2325): error C2238: unexpected token(s) preceding ';'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2329): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2334): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2334): error C2059: syntax error: '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2338): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2341): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2341): error C2059: syntax error: '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2345): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2348): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2348): error C2059: syntax error: '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2352): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2357): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2357): error C2059: syntax error: '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2361): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2365): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2365): error C2059: syntax error: '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2369): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2371): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2371): error C2059: syntax error: '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2375): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2377): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2377): error C2059: syntax error: '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2381): error C2059: syntax error: 'constant'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2383): error C2143: syntax error: missing ';' before '}'
c:\git_repos\sqlitebrowser\libs\qscintilla\qt4qt5\qsci\qsciscintillabase.h(2383): error C2059: syntax error: '}'
...

This note is also displayed, which seems like it might be important:

...
sqlitetablemodel.cpp(967): warning C4267: '+=': conversion from 'size_t' to 'int', possible loss of data
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(297): warning C4267: 'argument': conversion from 'size_t' to 'const unsigned int', possible loss of data
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(316): note: see reference to class template instantiation 'QtPrivate::AreArgumentsCompatible<unsigned __int64,unsigned int>' being compiled
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(317): note: see reference to class template instantiation 'QtPrivate::CheckCompatibleArguments<QtPrivate::List<size_t,size_t>,QtPrivate::List<unsigned int,unsigned int>>' being compiled
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobject.h(241): note: see reference to class template instantiation 'QtPrivate::CheckCompatibleArguments<QtPrivate::List<int,size_t,size_t>,QtPrivate::List<int,unsigned int,unsigned int>>' being compiled
sqlitetablemodel.cpp(35): note: see reference to function template instantiation 'QMetaObject::Connection QObject::connect<void(__cdecl RowLoader::* )(int,size_t,size_t),void(__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)>(const RowLoader *,Func1,const SqliteTableModel *,Func2,Qt::ConnectionType)' being compiled
        with
        [
            Func1=void (__cdecl RowLoader::* )(int,size_t,size_t),
            Func2=void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(134): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(133): note: while compiling class template member function 'void QtPrivate::FunctorCall<QtPrivate::IndexesList<0,1,2>,SignalArgs,R,void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)>::call(SlotRet (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int),Obj *,void **)'
        with
        [
            SignalArgs=QtPrivate::List<int,size_t,size_t>,
            R=void,
            SlotRet=void,
            Obj=SqliteTableModel
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(167): note: see reference to function template instantiation 'void QtPrivate::FunctorCall<QtPrivate::IndexesList<0,1,2>,SignalArgs,R,void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)>::call(SlotRet (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int),Obj *,void **)' being compiled
        with
        [
            SignalArgs=QtPrivate::List<int,size_t,size_t>,
            R=void,
            SlotRet=void,
            Obj=SqliteTableModel
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(167): note: see reference to class template instantiation 'QtPrivate::FunctorCall<QtPrivate::IndexesList<0,1,2>,SignalArgs,R,void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)>' being compiled
        with
        [
            SignalArgs=QtPrivate::List<int,size_t,size_t>,
            R=void
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(396): note: see reference to function template instantiation 'void QtPrivate::FunctionPointer<void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)>::call<Args,R>(void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int),Obj *,void **)' being compiled
        with
        [
            Args=QtPrivate::List<int,size_t,size_t>,
            R=void,
            Obj=SqliteTableModel
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(396): note: see reference to function template instantiation 'void QtPrivate::FunctionPointer<void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)>::call<Args,R>(void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int),Obj *,void **)' being compiled
        with
        [
            Args=QtPrivate::List<int,size_t,size_t>,
            R=void,
            Obj=SqliteTableModel
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(390): note: while compiling class template member function 'void QtPrivate::QSlotObject<Func2,QtPrivate::List<int,size_t,size_t>,void>::impl(int,QtPrivate::QSlotObjectBase *,QObject *,void **,bool *)'
        with
        [
            Func2=void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobjectdefs_impl.h(405): note: see reference to function template instantiation 'void QtPrivate::QSlotObject<Func2,QtPrivate::List<int,size_t,size_t>,void>::impl(int,QtPrivate::QSlotObjectBase *,QObject *,void **,bool *)' being compiled
        with
        [
            Func2=void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)
        ]
C:\dev\Qt\5.11.2\msvc2017_64\include\QtCore/qobject.h(253): note: see reference to class template instantiation 'QtPrivate::QSlotObject<Func2,QtPrivate::List<int,size_t,size_t>,void>' being compiled
        with
        [
            Func2=void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)
        ]
sqlitetablemodel.cpp(35): note: see reference to function template instantiation 'QMetaObject::Connection QObject::connect<void(__cdecl RowLoader::* )(int,size_t,size_t),void(__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)>(const RowLoader *,Func1,const SqliteTableModel *,Func2,Qt::ConnectionType)' being compiled
        with
        [
            Func1=void (__cdecl RowLoader::* )(int,size_t,size_t),
            Func2=void (__cdecl SqliteTableModel::* )(int,unsigned int,unsigned int)
        ]
RowLoader.cpp
...

Anyone have ideas? 😄

Activity

  1. justinclift commented on Oct 27, 2018

    @justinclift
    MemberAuthor

    Ping @MKleusberg @mgrojo @karim, as this might be your kind of thing. 😄

  2. FriedrichFroebel commented on Oct 27, 2018

    @FriedrichFroebel
    Contributor

    For the error it seems like this is the same as #1459.

  3. justinclift commented on Oct 27, 2018

    @justinclift
    MemberAuthor

    Well spotted. I have CMake 3.11.4 installed. Will drop back to an earlier version and try again. Thanks @FriedrichFroebel. 😄

  4. justinclift commented on Oct 27, 2018

    @justinclift
    MemberAuthor

    Yep. CMake 3.10.3 worked for the compiling.

    Hitting problems with linking at the end:

    ...
    qrc_translations.cpp
    qrc_CaCerts.cpp
    mocs_compilation.cpp
    Generating Code...
    sqlitetablemodel.obj : error LNK2001: unresolved external symbol sqlite3_prepare_v2
    RowLoader.obj : error LNK2001: unresolved external symbol sqlite3_prepare_v2
    RemoteDatabase.obj : error LNK2001: unresolved external symbol sqlite3_prepare_v2
    ExportDataDialog.obj : error LNK2001: unresolved external symbol sqlite3_prepare_v2
    ImportCsvDialog.obj : error LNK2001: unresolved external symbol sqlite3_prepare_v2
    MainWindow.obj : error LNK2001: unresolved external symbol sqlite3_prepare_v2
    sqlitedb.obj : error LNK2001: unresolved external symbol sqlite3_prepare_v2
    ExportDataDialog.obj : error LNK2019: unresolved external symbol sqlite3_column_count referenced in function "private: bool __cdecl ExportDataDialog::exportQue
    yCsv(class QString const &,class QString const &)" (?exportQueryCsv@ExportDataDialog@@AEAA_NAEBVQString@@0@Z)
    sqlitedb.obj : error LNK2001: unresolved external symbol sqlite3_column_count
    ExportDataDialog.obj : error LNK2019: unresolved external symbol sqlite3_column_name referenced in function "private: bool __cdecl ExportDataDialog::exportQuer
    Csv(class QString const &,class QString const &)" (?exportQueryCsv@ExportDataDialog@@AEAA_NAEBVQString@@0@Z)
    sqlitetablemodel.obj : error LNK2001: unresolved external symbol sqlite3_column_name
    sqlitetablemodel.obj : error LNK2001: unresolved external symbol sqlite3_step
    RowLoader.obj : error LNK2001: unresolved external symbol sqlite3_step
    RemoteDatabase.obj : error LNK2001: unresolved external symbol sqlite3_step
    ExportDataDialog.obj : error LNK2001: unresolved external symbol sqlite3_step
    ImportCsvDialog.obj : error LNK2001: unresolved external symbol sqlite3_step
    MainWindow.obj : error LNK2001: unresolved external symbol sqlite3_step
    sqlitedb.obj : error LNK2001: unresolved external symbol sqlite3_step
    ExportDataDialog.obj : error LNK2019: unresolved external symbol sqlite3_column_blob referenced in function "private: bool __cdecl ExportDataDialog::exportQuer
    Csv(class QString const &,class QString const &)" (?exportQueryCsv@ExportDataDialog@@AEAA_NAEBVQString@@0@Z)
    sqlitedb.obj : error LNK2001: unresolved external symbol sqlite3_column_blob
    RowLoader.obj : error LNK2001: unresolved external symbol sqlite3_column_blob
    ExportDataDialog.obj : error LNK2019: unresolved external symbol sqlite3_column_double referenced in function "private: bool __cdecl ExportDataDialog::exportQu
    ryJson(class QString const &,class QString const &)" (?exportQueryJson@ExportDataDialog@@AEAA_NAEBVQString@@0@Z)
    ExportDataDialog.obj : error LNK2019: unresolved external symbol sqlite3_column_int64 referenced in function "private: bool __cdecl ExportDataDialog::exportQue
    yJson(class QString const &,class QString const &)" (?exportQueryJson@ExportDataDialog@@AEAA_NAEBVQString@@0@Z)
    RemoteDatabase.obj : error LNK2019: unresolved external symbol sqlite3_column_text referenced in function "private: void __cdecl RemoteDatabase::gotReply(class
    QNetworkReply *)" (?gotReply@RemoteDatabase@@AEAAXPEAVQNetworkReply@@@Z)
    ExportDataDialog.obj : error LNK2001: unresolved external symbol sqlite3_column_text
    MainWindow.obj : error LNK2001: unresolved external symbol sqlite3_column_text
    sqlitedb.obj : error LNK2001: unresolved external symbol sqlite3_column_text
    RowLoader.obj : error LNK2001: unresolved external symbol sqlite3_column_text
    ExportDataDialog.obj : error LNK2019: unresolved external symbol sqlite3_column_bytes referenced in function "private: bool __cdecl ExportDataDialog::exportQue
    yCsv(class QString const &,class QString const &)" (?exportQueryCsv@ExportDataDialog@@AEAA_NAEBVQString@@0@Z)
    

    Not sure what the problem really is. Obviously something to do with the SQLCipher part of things, but unsure why yet. Hopefully it's just something simple like needing extra library paths due to using OpenSSL 1.1 instead of the older OpenSSL 1.0.

    Need to get sleep now, but I'll pick with up in the morning. If someone wants to have a go meanwhile (please do!), these are the bits I'm working with:

    Newer dependencies

    Source

  5. MKleusberg commented on Oct 27, 2018

    @MKleusberg
    Member

    It looks like it doesn't find the SQLCipher library. Because none of the mentioned functions refers to anything from OpenSSL I guess that wasn't the problem. If you haven't changed it, the cmake file seems to be looking for it in C:\git_repos\SQLCipher-Win64. Also the order of the libraries passed to the linker might matter. But hard to guess 😄

  6. justinclift commented on Oct 27, 2018

    @justinclift
    MemberAuthor

    Yeah, that was one of the things I was thinking too. When compiling earlier in the day I was using a different path, but changed it to match c:\git_repos\SQLCipher-Win64 shortly after hitting problems. Just to minimise differences.

    Hmmm, I might try dropping the compiled sqlcipher pieces into a few different directories, and see if it suddenly starts finding them.

    Should probably also grab the various Win debugging tools people have pointed out over time, such as WinDbg and similar.

  7. MKleusberg commented on Oct 30, 2018

    @MKleusberg
    Member

    Is there something like a build log? Qt Creator for example has one in the 'Compile Output' panel. Could be interesting to see what call to the linker cmake is generating for us.

  8. justinclift commented on Oct 31, 2018

    @justinclift
    MemberAuthor

    Good thinking. I should have time to investigate it tomorrow or maybe the weekend (moving house again atm, so time limited). 😉

  9. karim commented on Nov 12, 2018

    @karim
    Member

    @justinclift I managed to build SQLCipher with MSVC 2017.

    sqlcipher

    I followed your instructions here https://github.com/sqlitebrowser/sqlitebrowser/wiki/Win64-setup-%E2%80%94-Compiling-SQLCipher and it is very helpful.

    I also found an easier way to do it. Instead of manually editing Makefile.msc we can send all these options in the commandline.

    nmake /f Makefile.msc sqlcipher.dll USE_AMALGAMATION=1 NO_TCL=1 SQLITE3DLL=sqlcipher.dll SQLITE3LIB=sqlcipher.lib SQLITE3EXE=sqlcipher.exe LTLINKOPTS="C:\dev\OpenSSL-Win64\lib\libeay32.lib" OPT_FEATURE_FLAGS="-DSQLITE_TEMP_STORE=2 -DSQLITE_HAS_CODEC=1 -DSQLCIPHER_CRYPTO_OPENSSL=1 -IC:\dev\OpenSSL-Win64\include"

    Run this command without editing Makefile.msc and it will create sqlcipher.lib that you can link with DB4S. Then cmake -G "Visual Studio 15 2017 Win64" -Wno-dev -Dsqlcipher=1 after it and you shouldn't have any problems.

  10. justinclift commented on Nov 12, 2018

    @justinclift
    MemberAuthor

    That's fantastic @karim, thank you heaps. 😄

    Which version of OpenSSL is that with?

    We've been using OpenSSL 1.0.x for the released builds so far, but (ideally) we should be able to get OpenSSL 1.1.x working for this and future builds. In my above - failing - attempt with MSVC 2017 I tried OpenSSL 1.1.0i. I wonder if using a newer version contributed to the failure?

  11. karim commented on Nov 12, 2018

    @karim
    Member

    Yes, I'm also using OpenSSL 1.0.x (1.0.2p) because 1.1x didn't work for me. From this thread https://forum.qt.io/topic/71244/using-qsslsocket-with-custom-openssl

    Qt loads the OpenSSL libs on demand. Where the DLL name is hardcoded and the methods are resolved "manually".

    OpenSSL 1.0.x and 1.1.x are not compatible I think. The DLL names have changed and Qt can't find them. To make OpenSSL 1.1.x and above work we have to compile Qt from source. 😃

  12. chrisjlocke commented on Nov 12, 2018

    @chrisjlocke
    Member

    The DLL names have changed and Qt can't find them.

    I assume its not as simple as renaming the DLLs, so we're using 1.1.x but renamed to the 1.0.x names for Qt to find?

  13. karim commented on Nov 12, 2018

    @karim
    Member

    I assume its not as simple as renaming the DLLs

    I think renaming doesn't work because there are some changes that made both version incompatible, hence the new names.

    OpenSSL 1.0.2 is still supported for one more year. It is getting security updates and bug fixes, but no new features. We can continue using it till a newer version of Qt is built with OpenSSL 1.1.x.

  14. justinclift commented on Nov 23, 2018

    @justinclift
    MemberAuthor

    Got all the bits downloaded to a local testing VM, including MSVC in local cache mode so it doesn't need to be downloaded again.

    This time, using your SQLCipher compile line @karim it worked! Yay!

    Next I'll muck around with the SQLCipher pieces a bit more, so the changes are in the Makefile.msc, then get MSVC 2017 onto our build server and try for a 3.11.0 beta1 release. 😄

  15. karim commented on Nov 23, 2018

    @karim
    Member

    Next I'll muck around with the SQLCipher pieces a bit more, so the changes are in the Makefile.msc

    Why? I think you can just use a the commandline to override the default settings in the Makefile.msc. This way you don't need your fork of SQLCipher and you can use the original repo as-is.

    I see in your fork that you added other options (like -DSQLITE_ENABLE_JSON1=1) and I guess you can just add them to OPT_FEATURE_FLAGS in the commandline.

    Something like...

    nmake /f Makefile.msc sqlcipher.dll USE_AMALGAMATION=1 NO_TCL=1 SQLITE3DLL=sqlcipher.dll SQLITE3LIB=sqlcipher.lib SQLITE3EXE=sqlcipher.exe LTLINKOPTS="C:\dev\OpenSSL-Win64\lib\libeay32.lib" OPT_FEATURE_FLAGS="-DSQLITE_TEMP_STORE=2 -DSQLITE_HAS_CODEC=1 -DSQLITE_ENABLE_FTS5=1 -DSQLITE_ENABLE_FTS3_PARENTHESIS=1 -DSQLITE_ENABLE_JSON1=1 -DSQLCIPHER_CRYPTO_OPENSSL=1 -IC:\dev\OpenSSL-Win64\include"

  16. 38 remaining items

  17. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    Just pushed an untested commit (655dd49) that might correctly exclude those files for the Win32 builds. Now running the Win32 build process again to find out. 😉

  18. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    Watching the batch file output as it's building, that error seems to be fixed. The Win32 binaries should be online in ~20 mins or so. 😄

  19. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    Updated Win32 & Win64 builds are online now. I haven't started the OSX builds yet, but will do so sometime later today.

  20. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    Just realised we should be able to cherry-pick the commits from this Issue across to the v3.11.x branch, which should then be ready for the beta1 release. 😄

    Ahhh. Assuming the OSX builds already contain the translation files, which they might not. I'll check that in a bit, after the nightly build server completes it's OSX builds (in progress presently).

    Also, still need to check the Accessibility plugin situation for both OSX and Windows.

  21. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    New OSX nightlies are online now too.

  22. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    Looking through the plugins in the Qt 5.11.2 directory for MSVC 2017, I'm not seeing anything obvious for Accessibility. Not sure what to copy, so sounds like further research is needed.

    There is a plugins/printsupport/windowsprintersupport.dll plugin though. Anyone know if that might be needed for @mgrojo's printing stuff added a while back?

  23. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    In the Qt 5.11.2 directory, there seems to be some Accessibility related files:

    • Qt5AccessibilitySupport.lib
    • Qt5AccessibilitySupport.prl

    Along with the corresponding debugging versions:

    • Qt5AccessibilitySupportd.lib
    • Qt5AccessibilitySupportd.prl

    Kind of thinking the Accessibility bits might be bundled into Qt directly, and not need further plugin files added to our final binaries. But not sure.

    @francipvb Any idea? We have building with Qt 5.11.2 now working for Windows, but I'm not sure if some kind of extra plugins need to be bundled along with the installer. 😄

  24. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    There is a plugins/printsupport/windowsprintersupport.dll plugin though. Anyone know if that might be needed for @mgrojo's printing stuff added a while back?

    Ignore that. It turns out we're already bundling it. 😄

  25. justinclift commented on Nov 26, 2018

    @justinclift
    MemberAuthor

    Looking in our OSX installer now:

    • The bearer plugin is already there, which explains why no-one was reporting the network error on OSX.
    • The standard DB4S translation files are included in the bundle under Contents/MacOS/translations/. No sign of the standard Qt translation files though, so it looks like we'll need to include them on OSX next too.

    Guess that's the next task for today. I'll make a new issue for tracking that, and close this as the MSVC 2017 compile error problem is definitely solved thanks to @karim. 😄

  26. francipvb commented on Nov 26, 2018

    @francipvb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions