You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just tried to build this project on macOS for the first time, I found there are different ways to build for different OSes e.g I saw both cmake, qmake, and make.
I tried make a build folder and use CMake (on macOS) but it didn't work (it didn't find Qt5.make), while it's instructed way for Ubuntu Linux. How can I use CMake on macOS? or better for building on all supported OSes?
As a thought, have you seen the macOS/OSX section of BUILDING.md?
In theory, the instructions there should work cut-n-paste style.
It's been a fair while since I've personally tried them out though, so there's a chance they may need a bit of tweaking/updating to get current (not sure).
I got same build issue at raised in #1439, QScintilla is rebuilt even it existed (via brew install qscintilla2). Build errors are naming issues between qsciscintillabase.h and Scintilla.h, identifiers used in an enum also defined with #define, for example:
@tiendq This problem should be finally solved now. Compiling should work fine with cmake when using the latest DB4S version from our master branch. I'm going to close this issue then. If you should still have any problems with this, even with the latest version, you can always reopen this issue 😄
@justinclift Yes, I copied it from terminal :). Qt was installed by brew and the path actually has many folders inside, they contains .cmake files for each Qt components.
We have a (very old, slow) mac mini used as our nightly build server. In theory I should be able to investigate this in depth using that, then update our docs as appropriate.
It won't be this week though, as my schedule has become rather full very quickly. And it's just the start of the week! 😖
@tiendq I'll leave this to @justinclift since I don't have access to a Mac to try this out myself. As for the qscintilla question: it actually should prefer the system installation of qscintilla over the version we include in our repository - so in theory it should just work. If it doesn't that means we may need to adjust the HINTS lines in the cmake/FindQScintilla.cmake file to include the path brew uses.
@MKleusberg Providing path information (as I did) is actually the way it needs to work with Qt on macOS (see this). I would make a PR for this small change in docs. Regarding qscintilla, if it's what you prefer I'd find to make it work with system installation too.
Thanks, @tiendq! A PR for that would be awesome 😄 With the qscintilla library, any way to make it work with the system installation is welcomed, be it automatically or via a command line parameter.
Activity
justinclift commentedon Oct 3, 2018
As a thought, have you seen the macOS/OSX section of BUILDING.md?
In theory, the instructions there should work cut-n-paste style.
It's been a fair while since I've personally tried them out though, so there's a chance they may need a bit of tweaking/updating to get current (not sure).
justinclift commentedon Oct 3, 2018
If you really want CMake on OSX it should work, but there might be some environment variables that need setting first.
tiendq commentedon Oct 3, 2018
@justinclift I did, if not how I know it uses
qmake.tiendq commentedon Oct 4, 2018
I got same build issue at raised in #1439,
QScintillais rebuilt even it existed (viabrew install qscintilla2). Build errors are naming issues betweenqsciscintillabase.handScintilla.h, identifiers used in an enum also defined with#define, for example:My system is macOS 10.12.6 and clang-900.0.39.2
justinclift commentedon Oct 4, 2018
Ouch. This isn't something I can help with personally, so hopefully one of our other Community members has the time/interest to investigate. 😄
MKleusberg commentedon Dec 2, 2018
@tiendq This problem should be finally solved now. Compiling should work fine with cmake when using the latest DB4S version from our master branch. I'm going to close this issue then. If you should still have any problems with this, even with the latest version, you can always reopen this issue 😄
MKleusberg commentedon Dec 2, 2018
Oh, just saw that you were already informed in issue #1439 😉
tiendq commentedon Dec 3, 2018
@MKleusberg I could build with CMake now, but there are still 2 issues:
Qtpath need to be supplied in CMake command, it should be added in the building instruction.mkdir build cd build cmake -DCMAKE_PREFIX_PATH=/usr/local/opt/qt/lib/cmake .. makebuild/sqlitebrowser(though it works well) but nobuild/src/DB Browser for SQLite.applike usingqmakeI also want to know if I could use
qscintilla2installed bybrewinstead of building its source inlibs.justinclift commentedon Dec 3, 2018
@tiendq With that "Qt path need to be supplied in CMake command ...", is the example
cmake -DCMAKE ...line definitely correct?Asking because it has
cmakeinside what looks like aQtinstallation. Should it beqmake(the Qt alternative to CMake) instead? 😄tiendq commentedon Dec 3, 2018
@justinclift Yes, I copied it from terminal :). Qt was installed by
brewand the path actually has many folders inside, they contains.cmakefiles for each Qt components.justinclift commentedon Dec 3, 2018
No worries. 😄
We have a (very old, slow) mac mini used as our nightly build server. In theory I should be able to investigate this in depth using that, then update our docs as appropriate.
It won't be this week though, as my schedule has become rather full very quickly. And it's just the start of the week! 😖
MKleusberg commentedon Dec 4, 2018
@tiendq I'll leave this to @justinclift since I don't have access to a Mac to try this out myself. As for the qscintilla question: it actually should prefer the system installation of qscintilla over the version we include in our repository - so in theory it should just work. If it doesn't that means we may need to adjust the
HINTSlines in thecmake/FindQScintilla.cmakefile to include the path brew uses.tiendq commentedon Dec 4, 2018
@MKleusberg Providing path information (as I did) is actually the way it needs to work with Qt on macOS (see this). I would make a PR for this small change in docs. Regarding
qscintilla, if it's what you prefer I'd find to make it work with system installation too.MKleusberg commentedon Dec 5, 2018
Thanks, @tiendq! A PR for that would be awesome 😄 With the qscintilla library, any way to make it work with the system installation is welcomed, be it automatically or via a command line parameter.