App crash when you open an sqlite file #1175

Activity

1. chrisjlocke commented on Oct 16, 2017

   

   chrisjlocke

   on Oct 16, 2017

   Member

   More actions

   Just to confirm, have you tried other databases?* I assume the databases are local and not on a network?

   * Just in case its not just one database thats upsetting it...
2. goczhunor commented on Oct 25, 2017

   

   goczhunor

   on Oct 25, 2017 via email

   Author

   More actions

   No just sqlite exported from iOS decices. If you do it how I explained in the report it reproduces almost every time.

   …

   On 2017. Oct 16., at 12:29, Chris Locke ***@***.***> wrote: Just to confirm, have you tried other databases?* I assume the databases are local and not on a network? * Just in case its not just one database thats upsetting it... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
3. justinclift

   added

   crash

   osx

   on Oct 25, 2017
4. justinclift

   self-assigned this

   on Oct 25, 2017
5. SourceTrigger commented on Nov 18, 2017

   

   SourceTrigger

   on Nov 18, 2017

   Contributor

   More actions

   The Bug is on ExtendedTableWidget Drop Event :)
   It's only crash, if no database is open and you drop a File to empty ExtendedTableWidget.
   There is no check, if index is valid. Result is a crash on mac.

   void ExtendedTableWidget::dropEvent(QDropEvent* event)
   {
       QModelIndex index = indexAt(event->pos());
   
       if (!index.isValid()) // Need to check
           return;
   
       model()->dropMimeData(event->mimeData(), Qt::CopyAction, index.row(), index.column(), QModelIndex());
       event->acceptProposedAction();
   }

   You can implement an emit Signal to open Database if currently no once open on this position.
6. justinclift

   added

   response requested

   on Nov 19, 2017
7. justinclift commented on Nov 19, 2017

   

   justinclift

   on Nov 19, 2017

   Member

   More actions

   @SourceTrigger Excellent, that seems like it'll be helpful. 😄

   How familiar are you with Git and/or GitHub? Just wondering if you want to create a Pull Request with the fix, which is super easy for us to merge in and gives you official credit in the contributors list. 😄
8. SourceTrigger commented on Nov 20, 2017

   

   SourceTrigger

   on Nov 20, 2017

   Contributor

   More actions

   Hello, I have made a suggestion as to how a solution might look like.

   #1236
9. justinclift commented on Dec 6, 2017

   

   justinclift

   on Dec 6, 2017

   Member

   More actions

   @goczhunor This should be fixed now, thanks to @SourceTrigger. Any interest in trying the latest nightly build, and confirm if it does or doesn't work now from your point of view? 😄

       https://nightlies.sqlitebrowser.org/latest/
10. goczhunor commented on Dec 7, 2017

    

    goczhunor

    on Dec 7, 2017 via email

    Last edited by justinclift

    Author

    More actions

    Hello, I updated the application and tested out with some sqlite databases downloaded from my iOS application. I have tried to drag and drop many sqlite files into the application and this time it never crashed so the bug seems to be fixed now. I also tried to close the db first and drag and drop it after and it is all good. I tested it on my MacBook Pro 15" (Mid 2015) with MacOS High Sierra version 10.13.1. I assume it will work in other OS versions as well. Thank you for your support and for the great fix :).
11. justinclift commented on Dec 7, 2017

    

    justinclift

    on Dec 7, 2017

    Member

    More actions

    Fantastic! Thanks for testing it and letting us know @goczhunor. 😄
12. justinclift

    closed this as completedon Dec 7, 2017
13. justinclift

    removed

    response requested

    on Dec 7, 2017