Repository navigation
Incorrect encoding for tooltip #1107
Description
Details for the issue
When I type COUNT( at SQL tab, tooltip with ??? characters instead of russian text pops out:
There should be COUNT(X) Функция count(X) возвращает количесвто строк, в которых X не равно NULL в группе. message.
BTW, there is a typo in this text: количесвто should be количество.
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- DB4S has a bug
- DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- Windows: ( version: 7 SP1 x64 )
- Linux: ( distro: ___ )
- Mac OS: ( version: ___ )
- Other: ___
I'm using DB4S version:
- 3.10.0
- 3.10.0-beta*
- 3.9.1
- Other: ___
I have also:
- Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
- Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
justinclift commentedon Aug 28, 2017
Thanks @Vort, that does look like a bug. 😄
We probably won't have time to look at it for a few days though. 😦
With the typo, I'll get that fixed later today.
MKleusberg commentedon Sep 1, 2017
The problem seems to be with Scintilla. Here they say, it can be fixed by using a different font but with the two fonts I've tried so far I didn't have any luck.
justinclift commentedon Sep 1, 2017
Oops, I forgot to fix the typo too.
Fix typo in Russian translation
justinclift commentedon Sep 1, 2017
Typo now fixed: ddd08a4
Fix typo in Russian translation
to302 commentedon Oct 31, 2017
ko_KR has same problem. (version 3.10.99)
mgrojo commentedon Nov 1, 2017
The same problem is reproduced in Spanish with accented characters. I'm looking into this, but the Scintilla code related to encoding is specially convoluted. I can make the tooltip to present correctly in Spanish, but then, the text encoding in the editor is broken...
mgrojo commentedon Nov 1, 2017
Wow, I didn't know that my comment in the commit would close the Issue. Nevertheless I've tested it for Spanish, Russian and Korean and is working for me.
justinclift commentedon Nov 1, 2017
@mgrojo Yeah, that automatically-close-the-issue based on keywords has caught everyone else out a few times too already. 😉
@Vort @to302 Would you have time to try the nightly build tomorrow? Thanks to @mgrojo this should be fixed now. 😄
Vort commentedon Nov 2, 2017
Fixed. Thanks.
justinclift commentedon Nov 2, 2017
Thanks for checking @Vort. Good stuff @mgrojo. 😄
MKleusberg commentedon Nov 2, 2017
Glad this is finally fixed 😄 Just wanted to mention that we should probably send this to upstream QScintilla too but apparently they just fixed it yesterday: https://www.riverbankcomputing.com/static/Downloads/QScintilla/ChangeLog-2.10.2.dev1711012104. Maybe they are watching us 😆
mgrojo commentedon Nov 2, 2017
Maybe they are watching us, but I sent them yesterday a patch 😅 I didn't want that my fix was lost for other users or for future updates of our QScintilla copy. Glad they have so soon applied it.
MKleusberg commentedon Nov 2, 2017
Cool, good thinking 😃
Fixed incorrect display of SQL calltips containing non-US-ASCII chara…
Fixed incorrect display of SQL calltips containing non-US-ASCII chara…