Repository navigation
case insensitive autocomplete #1046
Description
Details for the issue
I'd love to have autocomplete on table names case insenstive. as My tables usually begin with uppercase char, I'd like if they would come up in autocomplete even if I start writing their name with lowercase.
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- DB4S has a bug
- [ x] DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- [ x] Windows: ( version: ___ )
- Linux: ( distro: ___ )
- Mac OS: ( version: ___ )
- Other: ___
I'm using DB4S version:
- [x ] 3.9.1
- 3.9.0
- Other: ___
I have also:
- Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
- Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
chrisjlocke commentedon Jun 22, 2017
Wow, never knew that before. Most of my tables are normally always lowercase, so haven't come across this before. Can undertand why that would be undesirable.
justinclift commentedon Jun 22, 2017
@mglatz This sounds like a reasonable idea. Not sure how easy or difficult it would be to add, but it wouldn't surprise me if we just needed to enable some option when we initialise our QScintilla bits (which we use for this).
This sounds like it might be the right kind of thing:
Hmmm, it seems like we already set that to
false:sqlitebrowser/src/sqltextedit.cpp
Line 107 in 6c9c56a
So maybe that's not the option we need for this... 😉
Someone else will probably know more about this stuff. 😄
chrisjlocke commentedon Jun 22, 2017
It does say though, "Note that setting a lexer may change the case sensitivity." which is then what happens in line 118.
sqlitebrowser/src/sqltextedit.cpp
Line 118 in 6c9c56a
Maybe the
setAutoCompletionCaseSensitivity(false);could be put after that line, or debug what the case sensitivity is, to see if its been changed.justinclift commentedon Jun 22, 2017
Ahhh. We could move the whole
if {}clause to after line 129.As in, I can do that right now in our master branch, if someone wants to check the nightly build tomorrow. (?) 😄
justinclift commentedon Jun 22, 2017
... or I could just test it myself right away. Hmmm, gimme a few mins... 😄
justinclift commentedon Jun 22, 2017
Nope, that didn't work. The autocomplete didn't notice tables starting with a capital letter, so it seems like this will need more careful attention to figure out. 😉
I'll leave it to someone else instead, as my focus is elsewhere for now.
Make SQL auto completion case insensitive
MKleusberg commentedon Jun 22, 2017
This should be fixed in the next nightly build. @mglatz Can you download and try the nightly build tomorrow or some later day to confirm it's working for you? There's currently a bug in our nightlies which causes them to crash more frequently though - we'll try to fix that as soon as possible, too 😉
chrisjlocke commentedon Jun 27, 2017
I can confirm this now works.
Prodding @mglatz ... ;) 🎋
mglatz commentedon Jun 27, 2017
wow thanks! :)
chrisjlocke commentedon Jun 27, 2017
If you can confirm it works OK for you, @mglatz, I'll close this issue. 🍾
mglatz commentedon Jun 27, 2017
it works on latest nightly (3.9.99 x64)
chrisjlocke commentedon Jun 27, 2017
Thanks for reporting back! 👍
mglatz commentedon Jul 31, 2017
I think this no longer works on 3.9.99 beta. can anyone confirm? thanks
justinclift commentedon Jul 31, 2017
Oh, interesting. Does it work with the 3.10.0-beta1 release from a few days ago?
chrisjlocke commentedon Jul 31, 2017
Works for me on Win 10 x64 for the 3.10.0.beta...
mglatz commentedon Jul 31, 2017
Turns out I did not have the proper version installed (beta), but one of earlier builds. In Beta (3.9.100) it works. Sorry for confusion.
justinclift commentedon Jul 31, 2017
No worries at all. 😄