Remove "NULL" in margin of editor in Edit dialog for empty cells

MKleusberg · MKleusberg · commit f81da0d29c8b · 2020-06-03T17:04:46.000+02:00
When clicking on a cell with a NULL value while, the Edit dialog switches into text mode and shows an empty text with "NULL" written in the line number margin. When then changing to an empty string cell, the text in the editor did not change (it is still empty after all). This prevented an action from triggering which meant that the "NULL" text in the line number marging was not removed. See issue #2204.
diff --git a/src/EditDialog.cpp b/src/EditDialog.cpp
@@ -210,6 +210,8 @@ void EditDialog::loadData(const QByteArray& bArrdata)
     case XML:
         // Can be stored in any widget, except the ImageViewer
 
+        sciEdit->clearTextInMargin();
+
         switch (editMode) {
         case TextEditor:
         case JsonEditor:
@@ -859,10 +861,8 @@ void EditDialog::editTextChanged()
         if (dataType == Null && isModified && dataLength != 0)
             dataType = Text;
 
-        if (dataType != Null) {
-            sciEdit->clearTextInMargin();
+        if (dataType != Null)
             ui->labelType->setText(tr("Type of data currently in cell: Text / Numeric"));
-        }
         ui->labelSize->setText(tr("%n character(s)", "", dataLength));
     }
 }
