Fixes some problems reported by Coverity

mgrojo · mgrojo · commit bef856ef45d6 · 2019-08-02T17:19:28.000+02:00
- Unchecked dynamic_cast
- Uninitialized scalar field
- Uninitialized pointer field
- Big parameter passed by value
diff --git a/src/AddRecordDialog.cpp b/src/AddRecordDialog.cpp
@@ -82,7 +82,7 @@ class EditDelegate: public QStyledItemDelegate {
 
     void setEditorData(QWidget *editor, const QModelIndex &index) const override {
 
-        NullLineEdit* lineEditor = dynamic_cast<NullLineEdit*>(editor);
+        NullLineEdit* lineEditor = static_cast<NullLineEdit*>(editor);
         // Set the editor in the null state (unless the user has actually written NULL)
         if (index.model()->data(index, Qt::UserRole).isNull() &&
             index.model()->data(index, Qt::DisplayRole) == Settings::getValue("databrowser", "null_text"))
@@ -94,7 +94,7 @@ class EditDelegate: public QStyledItemDelegate {
     }
     void setModelData(QWidget *editor, QAbstractItemModel *model, const QModelIndex &index) const override {
 
-        NullLineEdit* lineEditor = dynamic_cast<NullLineEdit*>(editor);
+        NullLineEdit* lineEditor = static_cast<NullLineEdit*>(editor);
         // Restore NULL text (unless the user has already modified the value)
         if (lineEditor->isNull() && !lineEditor->isModified()) {
             model->setData(index, Settings::getValue("databrowser", "null_text"), Qt::DisplayRole);
diff --git a/src/ExtendedScintilla.cpp b/src/ExtendedScintilla.cpp
@@ -22,13 +22,15 @@
 
 ExtendedScintilla::ExtendedScintilla(QWidget* parent) :
     QsciScintilla(parent),
+    showErrorIndicators(true),
     findReplaceDialog(new FindReplaceDialog(this))
 {
     // This class does not set any lexer, that must be done in the child classes.
 
     // Enable UTF8
     setUtf8(true);
 
+
     // Enable brace matching
     setBraceMatching(QsciScintilla::SloppyBraceMatch);
 
diff --git a/src/FindReplaceDialog.cpp b/src/FindReplaceDialog.cpp
@@ -7,6 +7,7 @@
 FindReplaceDialog::FindReplaceDialog(QWidget* parent)
     : QDialog(parent),
       ui(new Ui::FindReplaceDialog),
+      foundIndicatorNumber(0),
       findInProgress(false)
 {
     // Create UI
diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
@@ -869,7 +869,7 @@ void MainWindow::populateTable()
     QApplication::restoreOverrideCursor();
 }
 
-void MainWindow::applyBrowseTableSettings(BrowseDataTableSettings storedData, bool skipFilters)
+void MainWindow::applyBrowseTableSettings(const BrowseDataTableSettings& storedData, bool skipFilters)
 {
     // We don't want to pass storedData by reference because the functions below would change the referenced data in their original
     // place, thus modifiying the data this function can use. To have a static description of what the view should look like we want
diff --git a/src/MainWindow.h b/src/MainWindow.h
@@ -184,7 +184,7 @@ class MainWindow : public QMainWindow
 
     sqlb::ObjectIdentifier currentlyBrowsedTableName() const;
 
-    void applyBrowseTableSettings(BrowseDataTableSettings storedData, bool skipFilters = false);
+    void applyBrowseTableSettings(const BrowseDataTableSettings& storedData, bool skipFilters = false);
     void toggleTabVisible(QWidget* tabWidget, bool show);
     void restoreOpenTabs(QString tabs);
     QString saveOpenTabs();

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`FindReplaceDialog::FindReplaceDialog(QWidget* parent)`
`8`	`8`	`: QDialog(parent),`
`9`	`9`	`ui(new Ui::FindReplaceDialog),`
	`10`	`+ foundIndicatorNumber(0),`
`10`	`11`	`findInProgress(false)`
`11`	`12`	`{`
`12`	`13`	`// Create UI`
Original file line number	Diff line number	Diff line change
`@@ -869,7 +869,7 @@ void MainWindow::populateTable()`
`869`	`869`	`QApplication::restoreOverrideCursor();`
`870`	`870`	`}`
`871`	`871`
`872`		`-void MainWindow::applyBrowseTableSettings(BrowseDataTableSettings storedData, bool skipFilters)`
	`872`	`+void MainWindow::applyBrowseTableSettings(const BrowseDataTableSettings& storedData, bool skipFilters)`
`873`	`873`	`{`
`874`	`874`	`// We don't want to pass storedData by reference because the functions below would change the referenced data in their original`
`875`	`875`	`// place, thus modifiying the data this function can use. To have a static description of what the view should look like we want`