Fix possible crash when removing constraints from table definition

MKleusberg · MKleusberg · commit 7c1454e78523 · 2021-05-21T19:49:03.000+02:00
This fixes a possible crash when trying to remove a table constraint from a table definition. The issue was introduced in commit 4e1d1ff. See issue #2670.
diff --git a/src/sql/sqlitetypes.cpp b/src/sql/sqlitetypes.cpp
@@ -505,7 +505,7 @@ void Table::removeConstraints(const StringVector& vStrFields, Constraint::Constr
     for(auto it = m_constraints.begin();it!=m_constraints.end();)
     {
         if((*it)->columnList() == vStrFields && (*it)->type() == type)
-            m_constraints.erase(it++);
+            it = m_constraints.erase(it);
         else
             ++it;
     }

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@ void Table::removeConstraints(const StringVector& vStrFields, Constraint::Constr`
`505`	`505`	`for(auto it = m_constraints.begin();it!=m_constraints.end();)`
`506`	`506`	`{`
`507`	`507`	`if((it)->columnList() == vStrFields && (it)->type() == type)`
`508`		`- m_constraints.erase(it++);`
	`508`	`+ it = m_constraints.erase(it);`
`509`	`509`	`else`
`510`	`510`	`++it;`
`511`	`511`	`}`