Add "Hex dump files" as an export option when data source is hex editor

mgrojo · mgrojo · commit 749e7ed78c91 · 2018-09-29T18:54:09.000+02:00
When the data source is the hex editor we are able to save whatever data type as shown in the widget, so additionally to set the filters according to the data type a "Hex dump files (*.txt)" filter option is added. If the user selects this option for saving, the hexadecimal dump of the widget content is saved to the file. Note that the check must be performed using the selected filter by the user and not the file ending, which would be the same for text data exported as plain text. The Null case is disregarded as it is useless for exporting. See issues #1438 and #1485
diff --git a/src/EditDialog.cpp b/src/EditDialog.cpp
@@ -364,8 +364,7 @@ void EditDialog::exportData()
         break;
     }
     case Binary:
-    case Null:
-        filters << tr("Binary files (*.bin)") << tr("Text files (*.txt)");
+        filters << tr("Binary files (*.bin)");
         break;
     case Text:
         // Base the XML case on the mode, not the data type since XML detection is currently not implemented.
@@ -380,14 +379,22 @@ void EditDialog::exportData()
     case SVG:
         filters << tr("SVG files (*.svg)");
         break;
+    case Null:
+        return;
     }
 
+    if (dataSource == HexBuffer)
+        filters << tr("Hex dump files (*.txt)");
+
     filters << tr("All files (*)");
 
+    QString selectedFilter = filters.first();
     QString fileName = FileDialog::getSaveFileName(
                 this,
                 tr("Choose a filename to export data"),
-                filters.join(";;"));
+                filters.join(";;"),
+                /* defaultFileName */ QString(),
+                &selectedFilter);
     if(fileName.size() > 0)
     {
         QFile file(fileName);
@@ -397,7 +404,7 @@ void EditDialog::exportData()
           case HexBuffer:
               // Data source is the hex buffer
               // If text option has been selected, the readable representation of the content is saved to file.
-              if (fileName.endsWith(".txt", Qt::CaseInsensitive))
+              if (selectedFilter == tr("Hex dump files (*.txt)"))
                   file.write(hexEdit->toReadableString().toUtf8());
               else
                   file.write(hexEdit->data());
