Avoid multiple error messages when deleting cell values

MKleusberg · MKleusberg · commit 50b48bc7567e · 2021-05-22T09:55:49.000+02:00
When multiple cells are selected pressing the Delete key tries to set all of them to an empty string. In case of a unique constraint or similar constraints this throws an error. This commit copies the behaviour of the set to NULL menu action in that it aborts at the first error to avoid multiple error messages. See issue #2704.
diff --git a/src/ExtendedTableWidget.cpp b/src/ExtendedTableWidget.cpp
@@ -951,7 +951,10 @@ void ExtendedTableWidget::keyPressEvent(QKeyEvent* event)
             } else {
                 // When pressing Delete only set the value to empty string
                 for(const QModelIndex& index : selectedIndexes())
-                    model()->setData(index, "");
+                {
+                    if(!model()->setData(index, ""))
+                        return;
+                }
             }
         }
     } else if(event->modifiers().testFlag(Qt::ControlModifier) && (event->key() == Qt::Key_PageUp || event->key() == Qt::Key_PageDown)) {

Original file line number	Diff line number	Diff line change
`@@ -951,7 +951,10 @@ void ExtendedTableWidget::keyPressEvent(QKeyEvent* event)`
`951`	`951`	`} else {`
`952`	`952`	`// When pressing Delete only set the value to empty string`
`953`	`953`	`for(const QModelIndex& index : selectedIndexes())`
`954`		`- model()->setData(index, "");`
	`954`	`+ {`
	`955`	`+ if(!model()->setData(index, ""))`
	`956`	`+ return;`
	`957`	`+ }`
`955`	`958`	`}`
`956`	`959`	`}`
`957`	`960`	`} else if(event->modifiers().testFlag(Qt::ControlModifier) && (event->key() == Qt::Key_PageUp \|\| event->key() == Qt::Key_PageDown)) {`