fix: implement where tester of tlp

hanyisong · hanyisong · commit c8d0e63e3f87 · 2022-08-29T18:08:50.000+08:00
diff --git a/src/sqlancer/databend/ast/DatabendUnaryPostfixOperation.java b/src/sqlancer/databend/ast/DatabendUnaryPostfixOperation.java
@@ -18,6 +18,10 @@ public DatabendUnaryPostfixOperation(Node<DatabendExpression> expr, DatabendUnar
         setNegate(negate);
     }
 
+    public DatabendUnaryPostfixOperation(Node<DatabendExpression> expr, DatabendUnaryPostfixOperator op) {
+        super(expr,op);
+    }
+
     public enum DatabendUnaryPostfixOperator implements BinaryOperatorNode.Operator {
         IS_NULL("IS NULL"){
             @Override
diff --git a/src/sqlancer/databend/ast/DatabendUnaryPrefixOperation.java b/src/sqlancer/databend/ast/DatabendUnaryPrefixOperation.java
@@ -17,6 +17,10 @@ public DatabendUnaryPrefixOperation(Node<DatabendExpression> expr, DatabendUnary
         setNegate(negate);
     }
 
+    public DatabendUnaryPrefixOperation(Node<DatabendExpression> expr, DatabendUnaryPrefixOperator op) {
+        super(expr,op);
+    }
+
     void setNegate(boolean negate){
         this.negate = negate;
     }
@@ -26,18 +30,11 @@ public Node<DatabendExpression> getExpression() {
         return getExpr();
     }
 
-    @Override
-    public String getOperatorRepresentation() {
-        return null;
-    }
-
 //    @Override
 //    public OperatorKind getOperatorKind() {
 //        return OperatorKind.PREFIX;
 //    }
 
-
-
     public enum DatabendUnaryPrefixOperator implements BinaryOperatorNode.Operator {
         NOT("NOT", DatabendDataType.BOOLEAN, DatabendDataType.INT) {
             @Override
diff --git a/src/sqlancer/databend/gen/DatabendIndexGenerator.java b/src/sqlancer/databend/gen/DatabendIndexGenerator.java
diff --git a/src/sqlancer/databend/gen/DatabendNoRECExpressionGenerator.java b/src/sqlancer/databend/gen/DatabendNoRECExpressionGenerator.java
@@ -1,8 +1,8 @@
 package sqlancer.databend.gen;
 
-import com.google.common.collect.RangeMap;
 import sqlancer.Randomly;
 import sqlancer.common.ast.newast.NewBetweenOperatorNode;
+import sqlancer.common.ast.newast.NewFunctionNode;
 import sqlancer.common.ast.newast.NewInOperatorNode;
 import sqlancer.common.ast.newast.Node;
 import sqlancer.common.gen.TypedExpressionGenerator;
@@ -14,7 +14,6 @@
 import sqlancer.databend.ast.DatabendUnaryPrefixOperation.DatabendUnaryPrefixOperator;
 import sqlancer.databend.ast.DatabendBinaryLogicalOperation.DatabendBinaryLogicalOperator;
 import sqlancer.databend.ast.DatabendBinaryComparisonOperation.DatabendBinaryComparisonOperator;
-
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -24,6 +23,7 @@ public class DatabendNoRECExpressionGenerator extends
         TypedExpressionGenerator<Node<DatabendExpression>, DatabendColumn, DatabendDataType> {
 
     private final DatabendGlobalState globalState;
+    private boolean allowAggregateFunctions;
 
     public DatabendNoRECExpressionGenerator(DatabendGlobalState globalState) {
         this.globalState = globalState;
@@ -89,7 +89,6 @@ Node<DatabendExpression> generateBooleanExpression(int depth) {
 
     Node<DatabendExpression> getPostfix(int depth) {
         DatabendUnaryPostfixOperator randomOp = DatabendUnaryPostfixOperator.getRandom();
-//        System.out.println("getPostfix:" + generateExpression(Randomly.fromOptions(randomOp.getInputDataTypes()), depth));
         return new DatabendUnaryPostfixOperation(
                 generateExpression(Randomly.fromOptions(randomOp.getInputDataTypes()), depth),
                 randomOp,Randomly.getBoolean());
@@ -152,17 +151,17 @@ Node<DatabendExpression> getLike(int depth, DatabendDataType dataType) {
 
     @Override
     public Node<DatabendExpression> generatePredicate() {
-        return null;
+        return generateExpression(DatabendDataType.BOOLEAN);
     }
 
     @Override
     public Node<DatabendExpression> negatePredicate(Node<DatabendExpression> predicate) {
-        return null;
+        return new DatabendUnaryPrefixOperation(predicate,DatabendUnaryPrefixOperator.NOT);
     }
 
     @Override
-    public Node<DatabendExpression> isNull(Node<DatabendExpression> expr) {
-        return null;
+    public Node<DatabendExpression> isNull(Node<DatabendExpression> predicate) {
+        return new DatabendUnaryPostfixOperation(predicate,DatabendUnaryPostfixOperator.IS_NULL);
     }
 
 //    public Node<DatabendExpression> generateConstant(boolean isNullable) { //TODO 极小概率生成NULL值
@@ -213,4 +212,44 @@ protected DatabendDataType getRandomType() {
     protected boolean canGenerateColumnOfType(DatabendDataType type) {
         return false;
     }
+
+    public enum DatabendAggregateFunction {
+        MAX(1), MIN(1), AVG(1), COUNT(1),SUM(1), STDDEV_POP(1),
+        COVAR_POP(1), COVAR_SAMP(2);
+        //, STRING_AGG(1), STDDEV_SAMP(1),VAR_SAMP(1), VAR_POP(1)
+
+        private int nrArgs;
+
+        DatabendAggregateFunction(int nrArgs) {
+            this.nrArgs = nrArgs;
+        }
+
+        public static DatabendAggregateFunction getRandom() {
+            return Randomly.fromOptions(values());
+        }
+
+        public int getNrArgs() {
+            return nrArgs;
+        }
+
+    }
+
+    public NewFunctionNode<DatabendExpression, DatabendAggregateFunction> generateArgsForAggregate(
+            DatabendAggregateFunction aggregateFunction) {
+        return new NewFunctionNode<DatabendExpression, DatabendAggregateFunction>(
+                generateExpressions(aggregateFunction.getNrArgs()), aggregateFunction);
+    }
+
+    public Node<DatabendExpression> generateAggregate() {
+        DatabendAggregateFunction aggrFunc = DatabendAggregateFunction.getRandom();
+        return generateArgsForAggregate(aggrFunc);
+    }
+
+    public Node<DatabendExpression> generateHavingClause() {
+        this.allowAggregateFunctions = true;
+        Node<DatabendExpression> expression = generateExpression(DatabendDataType.BOOLEAN);
+        this.allowAggregateFunctions = false;
+        return expression;
+    }
+
 }
diff --git a/src/sqlancer/databend/test/DatabendQueryPartitioningBase.java b/src/sqlancer/databend/test/DatabendQueryPartitioningBase.java
@@ -17,6 +17,7 @@
 import sqlancer.databend.DatabendSchema.DatabendColumn;
 import sqlancer.databend.DatabendSchema.DatabendTable;
 import sqlancer.databend.DatabendSchema.DatabendTables;
+import sqlancer.databend.gen.DatabendNoRECExpressionGenerator;
 
 import java.sql.SQLException;
 import java.util.ArrayList;
@@ -29,7 +30,7 @@ public class DatabendQueryPartitioningBase
 
     DatabendSchema s;
     DatabendTables targetTables;
-    DatabendExpressionGenerator gen;
+    DatabendNoRECExpressionGenerator gen;
     DatabendSelect select;
 
     public DatabendQueryPartitioningBase(DatabendGlobalState state) {
@@ -50,7 +51,7 @@ public static String canonicalizeResultValue(String value) {
     public void check() throws SQLException {
         s = state.getSchema();
         targetTables = s.getRandomTableNonEmptyTables();
-        gen = new DatabendExpressionGenerator(state).setColumns(targetTables.getColumns());
+        gen = new DatabendNoRECExpressionGenerator(state).setColumns(targetTables.getColumns());
         initializeTernaryPredicateVariants();
         select = new DatabendSelect();
         select.setFetchColumns(generateFetchColumns());
diff --git a/src/sqlancer/databend/test/DatabendQueryPartitioningHavingTester.java b/src/sqlancer/databend/test/DatabendQueryPartitioningHavingTester.java
@@ -5,6 +5,7 @@
 import sqlancer.common.ast.newast.Node;
 import sqlancer.common.oracle.TestOracle;
 import sqlancer.databend.DatabendErrors;
+import sqlancer.databend.DatabendSchema;
 import sqlancer.databend.DatabendToStringVisitor;
 import sqlancer.databend.ast.DatabendExpression;
 import sqlancer.databend.DatabendProvider.DatabendGlobalState;
@@ -25,7 +26,7 @@ public DatabendQueryPartitioningHavingTester(DatabendGlobalState state) {
     public void check() throws SQLException {
         super.check();
         if (Randomly.getBoolean()) {
-            select.setWhereClause(gen.generateExpression());
+            select.setWhereClause(gen.generateExpression(DatabendSchema.DatabendDataType.BOOLEAN));
         }
         boolean orderBy = Randomly.getBoolean();
         if (orderBy) {
