fix the false positive in CODDTest for SQLite

DerZc · DerZc · commit b8dbd9de91c5 · 2025-03-22T15:12:59.000+08:00
diff --git a/src/sqlancer/sqlite3/oracle/SQLite3CODDTestOracle.java b/src/sqlancer/sqlite3/oracle/SQLite3CODDTestOracle.java
@@ -94,6 +94,9 @@ public SQLite3CODDTestOracle(SQLite3GlobalState globalState) {
     public void check() throws SQLException {
         reproducer = null;
 
+        joinsInExpr = null;
+        tablesFromOuterContext.clear();
+
         useSubqueryAsFoldedExpr = useSubquery();
         useCorrelatedSubqueryAsFoldedExpr = useCorrelatedSubquery();
 
@@ -168,8 +171,7 @@ else if (auxiliaryQueryResult.size() == 1 && auxiliaryQueryResult.get(auxiliaryQ
             foldedResult = getQueryResult(foldedQueryString, state);
         }
         // one column
-        else if (auxiliaryQueryResult.size() == 1 && Randomly.getBooleanWithRatherLowProbability()) {
-        // else if (auxiliaryQueryResult.size() == 1 && false) {
+        else if (auxiliaryQueryResult.size() == 1 && Randomly.getBooleanWithRatherLowProbability() && testInOperator()) {
             // original query
             List<SQLite3Column> columns = s.getRandomTableNonEmptyTables().getColumns();
             SQLite3ColumnName selectedColumn = new SQLite3ColumnName(Randomly.fromList(columns), null);
@@ -277,9 +279,11 @@ private SQLite3Select genSelectExpression(SQLite3Table tempTable, SQLite3Express
         gen = new SQLite3ExpressionGenerator(state).setColumns(columns);
         List<SQLite3Table> tables = randomTables.getTables();
         List<Join> joinStatements = new ArrayList<>();
-        if ((!useSubqueryAsFoldedExpr || (useSubqueryAsFoldedExpr && useCorrelatedSubqueryAsFoldedExpr)) && this.joinsInExpr != null) {
-            joinStatements.addAll(this.joinsInExpr);
-            this.joinsInExpr = null;
+        if (!useSubqueryAsFoldedExpr || (useSubqueryAsFoldedExpr && useCorrelatedSubqueryAsFoldedExpr)) {
+            if (this.joinsInExpr != null) {
+                joinStatements.addAll(this.joinsInExpr);
+                this.joinsInExpr = null;
+            }
         }
         else if (Randomly.getBoolean()) {
             joinStatements = genJoinExpression(gen, tables, Randomly.getBooleanWithRatherLowProbability() ? specificCondition : null, false);
@@ -950,6 +954,9 @@ public boolean testDerivedTable() {
     public boolean testInsert() {
         return false;
     }
+    public boolean testInOperator() {
+        return false;
+    }
 
     @Override
     public String getLastQueryString() {
