Update the Checkstyle version

mrigger · mrigger · commit a1aa0ff994e9 · 2022-01-19T22:52:00.000+01:00
diff --git a/pom.xml b/pom.xml
@@ -203,6 +203,13 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>3.1.2</version>
+        <dependencies>
+          <dependency>
+            <groupId>com.puppycrawl.tools</groupId>
+            <artifactId>checkstyle</artifactId>
+            <version>9.2.1</version>
+          </dependency>
+        </dependencies>
         <configuration>
           <configLocation>configs/checkstyle.xml</configLocation>
         </configuration>
diff --git a/src/sqlancer/mysql/ast/MySQLConstant.java b/src/sqlancer/mysql/ast/MySQLConstant.java
@@ -164,12 +164,12 @@ public MySQLConstant castAs(CastType type) {
                     try {
                         String substring = value.substring(0, i);
                         long val = Long.parseLong(substring);
-                        return MySQLConstant.createIntConstant(val, type == CastType.SIGNED ? true : false);
+                        return MySQLConstant.createIntConstant(val, type == CastType.SIGNED);
                     } catch (NumberFormatException e) {
                         // ignore
                     }
                 }
-                return MySQLConstant.createIntConstant(0, type == CastType.SIGNED ? true : false);
+                return MySQLConstant.createIntConstant(0, type == CastType.SIGNED);
             } else {
                 throw new AssertionError();
             }
diff --git a/src/sqlancer/oceanbase/ast/OceanBaseConstant.java b/src/sqlancer/oceanbase/ast/OceanBaseConstant.java
@@ -282,11 +282,11 @@ public OceanBaseConstant castAs(CastType type) {
                     try {
                         String substring = value.substring(0, i);
                         long val = Long.parseLong(substring);
-                        return OceanBaseConstant.createIntConstant(val, type == CastType.SIGNED ? true : false);
+                        return OceanBaseConstant.createIntConstant(val, type == CastType.SIGNED);
                     } catch (NumberFormatException e) {
                     }
                 }
-                return OceanBaseConstant.createIntConstant(0, type == CastType.SIGNED ? true : false);
+                return OceanBaseConstant.createIntConstant(0, type == CastType.SIGNED);
             } else {
                 throw new AssertionError();
             }

Original file line number	Diff line number	Diff line change
`@@ -164,12 +164,12 @@ public MySQLConstant castAs(CastType type) {`
`164`	`164`	`try {`
`165`	`165`	`String substring = value.substring(0, i);`
`166`	`166`	`long val = Long.parseLong(substring);`
`167`		`- return MySQLConstant.createIntConstant(val, type == CastType.SIGNED ? true : false);`
	`167`	`+ return MySQLConstant.createIntConstant(val, type == CastType.SIGNED);`
`168`	`168`	`} catch (NumberFormatException e) {`
`169`	`169`	`// ignore`
`170`	`170`	`}`
`171`	`171`	`}`
`172`		`- return MySQLConstant.createIntConstant(0, type == CastType.SIGNED ? true : false);`
	`172`	`+ return MySQLConstant.createIntConstant(0, type == CastType.SIGNED);`
`173`	`173`	`} else {`
`174`	`174`	`throw new AssertionError();`
`175`	`175`	`}`
Original file line number	Diff line number	Diff line change
`@@ -282,11 +282,11 @@ public OceanBaseConstant castAs(CastType type) {`
`282`	`282`	`try {`
`283`	`283`	`String substring = value.substring(0, i);`
`284`	`284`	`long val = Long.parseLong(substring);`
`285`		`- return OceanBaseConstant.createIntConstant(val, type == CastType.SIGNED ? true : false);`
	`285`	`+ return OceanBaseConstant.createIntConstant(val, type == CastType.SIGNED);`
`286`	`286`	`} catch (NumberFormatException e) {`
`287`	`287`	`}`
`288`	`288`	`}`
`289`		`- return OceanBaseConstant.createIntConstant(0, type == CastType.SIGNED ? true : false);`
	`289`	`+ return OceanBaseConstant.createIntConstant(0, type == CastType.SIGNED);`
`290`	`290`	`} else {`
`291`	`291`	`throw new AssertionError();`
`292`	`292`	`}`