Use AbstractSchema.matchesViewName() for view detection everywhere

mrigger · claude · mrigger · commit 9a9b5f345aa2 · 2026-04-09T00:09:46.000+08:00
Replace inlined tableName.startsWith("v") with the existing
matchesViewName() helper across all 15 schema classes, ensuring
a single source of truth for view name detection.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/sqlancer/clickhouse/ClickHouseSchema.java b/src/sqlancer/clickhouse/ClickHouseSchema.java
@@ -216,7 +216,7 @@ public static ClickHouseSchema fromConnection(SQLConnection con, String database
         for (String tableName : tableNames) {
             List<ClickHouseColumn> databaseColumns = getTableColumns(con, tableName);
             List<TableIndex> indexes = Collections.emptyList();
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             ClickHouseTable t = new ClickHouseTable(tableName, databaseColumns, indexes, isView);
             for (ClickHouseColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/cockroachdb/CockroachDBSchema.java b/src/sqlancer/cockroachdb/CockroachDBSchema.java
@@ -292,7 +292,7 @@ public static CockroachDBSchema fromConnection(SQLConnection con, String databas
         for (String tableName : tableNames) {
             List<CockroachDBColumn> databaseColumns = getTableColumns(con, tableName);
             List<TableIndex> indexes = getIndexes(con, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             CockroachDBTable t = new CockroachDBTable(tableName, databaseColumns, indexes, isView);
             for (CockroachDBColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/databend/DatabendSchema.java b/src/sqlancer/databend/DatabendSchema.java
@@ -321,7 +321,7 @@ public static DatabendSchema fromConnection(SQLConnection con, String databaseNa
         List<String> tableNames = getTableNames(con, databaseName);
         for (String tableName : tableNames) {
             List<DatabendColumn> databaseColumns = getTableColumns(con, tableName, databaseName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             DatabendTable t = new DatabendTable(tableName, databaseColumns, isView);
             for (DatabendColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/datafusion/DataFusionSchema.java b/src/sqlancer/datafusion/DataFusionSchema.java
@@ -37,7 +37,7 @@ public static DataFusionSchema fromConnection(SQLConnection con, String database
 
         for (String tableName : tableNames) {
             List<DataFusionColumn> databaseColumns = getTableColumns(con, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             DataFusionTable t = new DataFusionTable(tableName, databaseColumns, isView);
             for (DataFusionColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/doris/DorisSchema.java b/src/sqlancer/doris/DorisSchema.java
@@ -569,7 +569,7 @@ public static DorisSchema fromConnection(SQLConnection con, String databaseName)
                 continue;
             }
             List<DorisColumn> databaseColumns = getTableColumns(con, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             DorisTable t = new DorisTable(tableName, databaseColumns, isView);
             for (DorisColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/duckdb/DuckDBSchema.java b/src/sqlancer/duckdb/DuckDBSchema.java
@@ -231,7 +231,7 @@ public static DuckDBSchema fromConnection(SQLConnection con, String databaseName
                 continue; // TODO: unexpected?
             }
             List<DuckDBColumn> databaseColumns = getTableColumns(con, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             List<TableIndex> indexes = getIndexes(con, tableName);
             DuckDBTable t = new DuckDBTable(tableName, databaseColumns, indexes, isView);
             for (DuckDBColumn c : databaseColumns) {
diff --git a/src/sqlancer/hive/HiveSchema.java b/src/sqlancer/hive/HiveSchema.java
@@ -59,7 +59,7 @@ public static HiveSchema fromConnection(SQLConnection con, String databaseName)
         List<String> tableNames = getTableNames(con);
         for (String tableName : tableNames) {
             List<HiveColumn> databaseColumns = getTableColumns(con, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             HiveTable t = new HiveTable(tableName, databaseColumns, isView);
             for (HiveColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/hsqldb/HSQLDBSchema.java b/src/sqlancer/hsqldb/HSQLDBSchema.java
@@ -29,7 +29,7 @@ public static HSQLDBSchema fromConnection(SQLConnection connection, String datab
                 continue; // TODO: unexpected?
             }
             List<HSQLDBSchema.HSQLDBColumn> databaseColumns = getTableColumns(connection, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             HSQLDBSchema.HSQLDBTable t = new HSQLDBSchema.HSQLDBTable(tableName, databaseColumns, isView);
             for (HSQLDBSchema.HSQLDBColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/postgres/PostgresSchema.java b/src/sqlancer/postgres/PostgresSchema.java
@@ -250,7 +250,7 @@ public static PostgresSchema fromConnection(SQLConnection con, String databaseNa
                         boolean isPartitioned = "p".equals(rs.getString("relkind"));
                         // TODO: also check insertable
                         // TODO: insert into view?
-                        boolean isView = tableName.startsWith("v"); // tableTypeStr.contains("VIEW") ||
+                        boolean isView = matchesViewName(tableName); // tableTypeStr.contains("VIEW") ||
                                                                     // tableTypeStr.contains("LOCAL TEMPORARY") &&
                                                                     // !isInsertable;
                         PostgresTable.TableType tableType = getTableType(tableTypeSchema);
diff --git a/src/sqlancer/presto/PrestoSchema.java b/src/sqlancer/presto/PrestoSchema.java
@@ -27,7 +27,7 @@ public static PrestoSchema fromConnection(SQLConnection con, String databaseName
         List<String> tableNames = getTableNames(con);
         for (String tableName : tableNames) {
             List<PrestoColumn> databaseColumns = getTableColumns(con, databaseName, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             PrestoTable t = new PrestoTable(tableName, databaseColumns, isView);
             for (PrestoColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/questdb/QuestDBSchema.java b/src/sqlancer/questdb/QuestDBSchema.java
@@ -268,7 +268,7 @@ public static QuestDBSchema fromConnection(SQLConnection con, String databaseNam
                 continue; // TODO: unexpected?
             }
             List<QuestDBColumn> databaseColumns = getTableColumns(con, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             QuestDBTable t = new QuestDBTable(tableName, databaseColumns, isView);
             for (QuestDBColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/spark/SparkSchema.java b/src/sqlancer/spark/SparkSchema.java
@@ -54,7 +54,7 @@ public static SparkSchema fromConnection(SQLConnection con, String databaseName)
         List<String> tableNames = getTableNames(con);
         for (String tableName : tableNames) {
             List<SparkColumn> databaseColumns = getTableColumns(con, tableName);
-            boolean isView = tableName.toLowerCase().startsWith("v");
+            boolean isView = matchesViewName(tableName);
             SparkTable t = new SparkTable(tableName, databaseColumns, isView);
             for (SparkColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/tidb/TiDBSchema.java b/src/sqlancer/tidb/TiDBSchema.java
@@ -313,7 +313,7 @@ public static TiDBSchema fromConnection(SQLConnection con, String databaseName)
                 continue;
             }
             List<TableIndex> indexes = getIndexes(con, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             TiDBTable t = new TiDBTable(tableName, databaseColumns, indexes, isView);
             for (TiDBColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/yugabyte/ycql/YCQLSchema.java b/src/sqlancer/yugabyte/ycql/YCQLSchema.java
@@ -216,7 +216,7 @@ public static YCQLSchema fromConnection(SQLConnection con, String databaseName)
                 continue;
             }
             List<YCQLColumn> databaseColumns = getTableColumns(con, databaseName, tableName);
-            boolean isView = tableName.startsWith("v");
+            boolean isView = matchesViewName(tableName);
             YCQLTable t = new YCQLTable(tableName, databaseColumns, isView);
             for (YCQLColumn c : databaseColumns) {
                 c.setTable(t);
diff --git a/src/sqlancer/yugabyte/ysql/YSQLSchema.java b/src/sqlancer/yugabyte/ysql/YSQLSchema.java
@@ -81,7 +81,7 @@ public static YSQLSchema fromConnection(SQLConnection con, String databaseName)
                         boolean isInsertable = rs.getBoolean("is_insertable_into");
                         // TODO: also check insertable
                         // TODO: insert into view?
-                        boolean isView = tableName.startsWith("v"); // tableTypeStr.contains("VIEW") ||
+                        boolean isView = matchesViewName(tableName); // tableTypeStr.contains("VIEW") ||
                         // tableTypeStr.contains("LOCAL TEMPORARY") &&
                         // !isInsertable;
                         YSQLTable.TableType tableType = getTableType(tableTypeSchema);

Original file line number	Diff line number	Diff line change
`@@ -569,7 +569,7 @@ public static DorisSchema fromConnection(SQLConnection con, String databaseName)`
`569`	`569`	`continue;`
`570`	`570`	`}`
`571`	`571`	`List<DorisColumn> databaseColumns = getTableColumns(con, tableName);`
`572`		`- boolean isView = tableName.startsWith("v");`
	`572`	`+ boolean isView = matchesViewName(tableName);`
`573`	`573`	`DorisTable t = new DorisTable(tableName, databaseColumns, isView);`
`574`	`574`	`for (DorisColumn c : databaseColumns) {`
`575`	`575`	`c.setTable(t);`
Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ public static DuckDBSchema fromConnection(SQLConnection con, String databaseName`
`231`	`231`	`continue; // TODO: unexpected?`
`232`	`232`	`}`
`233`	`233`	`List<DuckDBColumn> databaseColumns = getTableColumns(con, tableName);`
`234`		`- boolean isView = tableName.startsWith("v");`
	`234`	`+ boolean isView = matchesViewName(tableName);`
`235`	`235`	`List<TableIndex> indexes = getIndexes(con, tableName);`
`236`	`236`	`DuckDBTable t = new DuckDBTable(tableName, databaseColumns, indexes, isView);`
`237`	`237`	`for (DuckDBColumn c : databaseColumns) {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public static HSQLDBSchema fromConnection(SQLConnection connection, String datab`
`29`	`29`	`continue; // TODO: unexpected?`
`30`	`30`	`}`
`31`	`31`	`List<HSQLDBSchema.HSQLDBColumn> databaseColumns = getTableColumns(connection, tableName);`
`32`		`- boolean isView = tableName.startsWith("v");`
	`32`	`+ boolean isView = matchesViewName(tableName);`
`33`	`33`	`HSQLDBSchema.HSQLDBTable t = new HSQLDBSchema.HSQLDBTable(tableName, databaseColumns, isView);`
`34`	`34`	`for (HSQLDBSchema.HSQLDBColumn c : databaseColumns) {`
`35`	`35`	`c.setTable(t);`