Avoid redundant field initializers

mrigger · mrigger · commit 60abb071f34f · 2020-07-01T23:00:29.000+02:00
diff --git a/configs/pmd-rules.xml b/configs/pmd-rules.xml
@@ -80,7 +80,6 @@
 		<exclude name="AvoidInstantiatingObjectsInLoops" />
 		<exclude name="InefficientStringBuffering" />
 		<exclude name="InsufficientStringBufferDeclaration" />
-		<exclude name="RedundantFieldInitializer" />
 		<exclude name="ConsecutiveAppendsShouldReuse" />
 		<exclude name="UseStringBufferForStringAppends" />
 		<exclude name="SimplifyStartsWith" />
diff --git a/src/sqlancer/Main.java b/src/sqlancer/Main.java
@@ -482,7 +482,7 @@ private static void startProgressMonitor() {
         scheduler.scheduleAtFixedRate(new Runnable() {
 
             private long timeMillis = System.currentTimeMillis();
-            private long lastNrQueries = 0;
+            private long lastNrQueries;
             private long lastNrDbs;
 
             {
diff --git a/src/sqlancer/mysql/MySQLExpectedValueVisitor.java b/src/sqlancer/mysql/MySQLExpectedValueVisitor.java
@@ -22,7 +22,7 @@
 public class MySQLExpectedValueVisitor implements MySQLVisitor {
 
     private final StringBuilder sb = new StringBuilder();
-    private int nrTabs = 0;
+    private int nrTabs;
 
     private void print(MySQLExpression expr) {
         MySQLToStringVisitor v = new MySQLToStringVisitor();
diff --git a/src/sqlancer/postgres/PostgresOptions.java b/src/sqlancer/postgres/PostgresOptions.java
@@ -21,7 +21,7 @@
 public class PostgresOptions {
 
     @Parameter(names = "--bulk-insert")
-    public boolean allowBulkInsert = false;
+    public boolean allowBulkInsert;
 
     @Parameter(names = "--oracle", converter = DBMSConverter.class)
     public List<PostgresOracle> oracle = Arrays.asList(PostgresOracle.QUERY_PARTITIONING);
diff --git a/src/sqlancer/postgres/PostgresProvider.java b/src/sqlancer/postgres/PostgresProvider.java
@@ -56,7 +56,7 @@
 // IN
 public final class PostgresProvider extends ProviderAdapter<PostgresGlobalState, PostgresOptions> {
 
-    public static boolean generateOnlyKnown = false;
+    public static boolean generateOnlyKnown;
 
     private PostgresGlobalState globalState;
 
diff --git a/src/sqlancer/sqlite3/SQLite3ExpectedValueVisitor.java b/src/sqlancer/sqlite3/SQLite3ExpectedValueVisitor.java
@@ -38,7 +38,7 @@
 public class SQLite3ExpectedValueVisitor implements SQLite3Visitor {
 
     private final StringBuilder sb = new StringBuilder();
-    private int nrTabs = 0;
+    private int nrTabs;
 
     private void print(SQLite3Expression expr) {
         SQLite3ToStringVisitor v = new SQLite3ToStringVisitor();
diff --git a/src/sqlancer/sqlite3/SQLite3Options.java b/src/sqlancer/sqlite3/SQLite3Options.java
@@ -31,7 +31,7 @@ public class SQLite3Options {
 
     @Parameter(names = {
             "--test-dbstats" }, description = "Test the DBSTAT Virtual Table (see https://www.sqlite.org/dbstat.html)", arity = 1)
-    public boolean testDBStats = false;
+    public boolean testDBStats;
 
     @Parameter(names = { "--test-generated-columns" }, description = "Test generated columns", arity = 1)
     public boolean testGeneratedColumns = true;
@@ -61,14 +61,14 @@ public class SQLite3Options {
 
     @Parameter(names = {
             "--test-soundex" }, description = "Test the soundex function, which can be enabled using a compile-time option.", arity = 1)
-    public boolean testSoundex = false;
+    public boolean testSoundex;
 
     @Parameter(names = { "--test-match" }, description = "Allow the generation of the MATCH operator", arity = 1)
     public boolean testMatch = true;
 
     @Parameter(names = {
             "--test-distinct-in-view" }, description = "DISTINCT in views might cause occasional false positives in NoREC and TLP", arity = 1)
-    public boolean testDistinctInView = false;
+    public boolean testDistinctInView;
 
     @Parameter(names = "--oracle", converter = DBMSConverter.class)
     public SQLite3Oracle oracle = SQLite3Oracle.NoREC;
@@ -83,19 +83,19 @@ public class SQLite3Options {
 
     @Parameter(names = {
             "--print-statements" }, description = "Specifies whether to print SQL statements to stdout", arity = 1)
-    public boolean printStatements = false;
+    public boolean printStatements;
 
     @Parameter(names = {
             "--execute-queries" }, description = "Specifies whether the query in the fuzzer should be executed", arity = 1)
     public boolean executeQuery = true;
 
     @Parameter(names = {
             "--print-successful-statements" }, description = "Specifies whether to print SQL statements to stdout", arity = 1)
-    public boolean executeStatementsAndPrintSuccessfulOnes = false;
+    public boolean executeStatementsAndPrintSuccessfulOnes;
 
     @Parameter(names = {
             "--exit-after-first-database" }, description = "Specifies whether to stop SQLancer after creating and executing the test oracle on the first database", arity = 1)
-    public boolean exitAfterFirstDatabase = false;
+    public boolean exitAfterFirstDatabase;
 
     public enum SQLite3Oracle {
         PQS {
diff --git a/src/sqlancer/sqlite3/SQLite3Provider.java b/src/sqlancer/sqlite3/SQLite3Provider.java
@@ -54,7 +54,7 @@
 public class SQLite3Provider extends ProviderAdapter<SQLite3GlobalState, SQLite3Options> {
 
     public static boolean allowFloatingPointFp = true;
-    public static boolean mustKnowResult = false;
+    public static boolean mustKnowResult;
 
     private SQLite3StateToReproduce state;
     private String databaseName;

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ private static void startProgressMonitor() {`
`482`	`482`	`scheduler.scheduleAtFixedRate(new Runnable() {`
`483`	`483`
`484`	`484`	`private long timeMillis = System.currentTimeMillis();`
`485`		`- private long lastNrQueries = 0;`
	`485`	`+ private long lastNrQueries;`
`486`	`486`	`private long lastNrDbs;`
`487`	`487`
`488`	`488`	`{`