Let files end with a newline and enforce this in checkstyle

mrigger · mrigger · commit 5e4176c67cf2 · 2020-05-25T22:53:20.000+02:00
diff --git a/checkstyle.xml b/checkstyle.xml
@@ -62,7 +62,7 @@
 
     <!-- Checks whether files end with a new line.                        -->
     <!-- See https://checkstyle.org/config_misc.html#NewlineAtEndOfFile -->
-    <!-- TODO: <module name="NewlineAtEndOfFile"/> -->
+    <module name="NewlineAtEndOfFile"/>
 
     <!-- Checks that property files contain the same keys.         -->
     <!-- See https://checkstyle.org/config_misc.html#Translation -->
diff --git a/src/sqlancer/AbstractAction.java b/src/sqlancer/AbstractAction.java
@@ -4,4 +4,4 @@
 
 public interface AbstractAction<G> {
 	public Query getQuery(G globalState) throws SQLException;
-}
+}
diff --git a/src/sqlancer/GlobalState.java b/src/sqlancer/GlobalState.java
@@ -81,4 +81,4 @@ public void setDatabaseName(String databaseName) {
 		this.databaseName = databaseName;
 	}
 
-}
+}
diff --git a/src/sqlancer/StatementExecutor.java b/src/sqlancer/StatementExecutor.java
@@ -79,4 +79,4 @@ public void executeStatements() throws SQLException {
 			total--;
 		}
 	}
-}
+}
diff --git a/src/sqlancer/clickhouse/gen/ClickhouseExpressionGenerator.java b/src/sqlancer/clickhouse/gen/ClickhouseExpressionGenerator.java
@@ -152,4 +152,4 @@ public String getTextRepresentation() {
 
 	}
 
-}
+}
diff --git a/src/sqlancer/clickhouse/test/ClickhouseQueryPartitioningWhereTester.java b/src/sqlancer/clickhouse/test/ClickhouseQueryPartitioningWhereTester.java
@@ -41,4 +41,4 @@ public void check() throws SQLException {
 		TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);
 	}
 
-}
+}
diff --git a/src/sqlancer/cockroachdb/test/CockroachDBQueryPartitioningGroupByTester.java b/src/sqlancer/cockroachdb/test/CockroachDBQueryPartitioningGroupByTester.java
@@ -49,4 +49,4 @@ List<CockroachDBExpression> generateFetchColumns() {
 		return columns;
 	}
 
-}
+}
diff --git a/src/sqlancer/duckdb/gen/DuckDBExpressionGenerator.java b/src/sqlancer/duckdb/gen/DuckDBExpressionGenerator.java
@@ -436,4 +436,4 @@ public Node<DuckDBExpression> generateAggregate() {
 		return generateArgsForAggregate(aggrFunc);
 	}
 
-}
+}
diff --git a/src/sqlancer/duckdb/test/DuckDBQueryPartitioningDistinctTester.java b/src/sqlancer/duckdb/test/DuckDBQueryPartitioningDistinctTester.java
@@ -42,4 +42,4 @@ public void check() throws SQLException {
 		TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);
 	}
 
-}
+}
diff --git a/src/sqlancer/duckdb/test/DuckDBQueryPartitioningGroupByTester.java b/src/sqlancer/duckdb/test/DuckDBQueryPartitioningGroupByTester.java
@@ -53,4 +53,4 @@ List<Node<DuckDBExpression>> generateFetchColumns() {
 		return columns;
 	}
 
-}
+}
diff --git a/src/sqlancer/duckdb/test/DuckDBQueryPartitioningWhereTester.java b/src/sqlancer/duckdb/test/DuckDBQueryPartitioningWhereTester.java
@@ -43,4 +43,4 @@ public void check() throws SQLException {
 		TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);
 	}
 
-}
+}
diff --git a/src/sqlancer/mysql/MySQLOptions.java b/src/sqlancer/mysql/MySQLOptions.java
@@ -5,4 +5,4 @@
 @Parameters
 public class MySQLOptions {
 
-}
+}
diff --git a/src/sqlancer/postgres/PostgresOptions.java b/src/sqlancer/postgres/PostgresOptions.java
@@ -62,4 +62,4 @@ public TestOracle create(PostgresGlobalState globalState) throws SQLException {
 
 	}
 
-}
+}
diff --git a/src/sqlancer/postgres/ast/PostgresPostfixText.java b/src/sqlancer/postgres/ast/PostgresPostfixText.java
@@ -34,4 +34,4 @@ public PostgresConstant getExpectedValue() {
 	public PostgresDataType getExpressionType() {
 		return type;
 	}
-}
+}
diff --git a/src/sqlancer/postgres/test/PostgresQueryPartitioningWhereTester.java b/src/sqlancer/postgres/test/PostgresQueryPartitioningWhereTester.java
@@ -39,4 +39,4 @@ public void check() throws SQLException {
 				thirdQueryString, combinedString, Randomly.getBoolean(), state, errors);
 		TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);
 	}
-}
+}
diff --git a/src/sqlancer/sqlite3/ast/SQLite3Constant.java b/src/sqlancer/sqlite3/ast/SQLite3Constant.java
@@ -606,4 +606,4 @@ public boolean isReal() {
 		return getDataType() == SQLite3DataType.REAL;
 	}
 
-}
+}
diff --git a/src/sqlancer/sqlite3/ast/SQLite3UnaryOperation.java b/src/sqlancer/sqlite3/ast/SQLite3UnaryOperation.java
@@ -152,4 +152,4 @@ public OperatorKind getOperatorKind() {
 		return OperatorKind.PREFIX;
 	}
 
-}
+}
diff --git a/src/sqlancer/sqlite3/queries/SQLite3QueryPartitioningDistinctTester.java b/src/sqlancer/sqlite3/queries/SQLite3QueryPartitioningDistinctTester.java
@@ -38,4 +38,4 @@ public void check() throws SQLException {
 		TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);
 	}
 
-}
+}
diff --git a/src/sqlancer/sqlite3/queries/SQLite3QueryPartitioningGroupByTester.java b/src/sqlancer/sqlite3/queries/SQLite3QueryPartitioningGroupByTester.java
@@ -49,4 +49,4 @@ List<SQLite3Expression> generateFetchColumns() {
 		return columns;
 	}
 
-}
+}
diff --git a/src/sqlancer/sqlite3/queries/SQLite3QueryPartitioningWhereTester.java b/src/sqlancer/sqlite3/queries/SQLite3QueryPartitioningWhereTester.java
@@ -41,4 +41,4 @@ public void check() throws SQLException {
 		TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);
 	}
 
-}
+}
diff --git a/src/sqlancer/tidb/TiDBExpressionGenerator.java b/src/sqlancer/tidb/TiDBExpressionGenerator.java
@@ -176,4 +176,4 @@ public List<TiDBExpression> generateOrderBys() {
 		return newExpressions;
 	}
 
-}
+}
diff --git a/src/sqlancer/tidb/ast/TiDBBinaryArithmeticOperation.java b/src/sqlancer/tidb/ast/TiDBBinaryArithmeticOperation.java
@@ -2,6 +2,7 @@
 
 import sqlancer.Randomly;
 import sqlancer.ast.BinaryOperatorNode;
+import sqlancer.ast.BinaryOperatorNode.Operator;
 import sqlancer.tidb.ast.TiDBBinaryArithmeticOperation.TiDBBinaryArithmeticOperator;
 
 public class TiDBBinaryArithmeticOperation extends BinaryOperatorNode<TiDBExpression, TiDBBinaryArithmeticOperator>
@@ -35,4 +36,4 @@ public TiDBBinaryArithmeticOperation(TiDBExpression left, TiDBExpression right,
 		super(left, right, op);
 	}
 
-}
+}
diff --git a/src/sqlancer/tidb/ast/TiDBUnaryPostfixOperation.java b/src/sqlancer/tidb/ast/TiDBUnaryPostfixOperation.java
@@ -37,4 +37,4 @@ public OperatorKind getOperatorKind() {
 		return OperatorKind.POSTFIX;
 	}
 
-}
+}
diff --git a/src/sqlancer/tidb/ast/TiDBUnaryPrefixOperation.java b/src/sqlancer/tidb/ast/TiDBUnaryPrefixOperation.java
@@ -40,4 +40,4 @@ public OperatorKind getOperatorKind() {
 		return OperatorKind.PREFIX;
 	}
 
-}
+}
diff --git a/src/sqlancer/tidb/test/TiDBQueryPartitioningWhereTester.java b/src/sqlancer/tidb/test/TiDBQueryPartitioningWhereTester.java
@@ -43,4 +43,4 @@ public void check() throws SQLException {
 		TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);
 	}
 
-}
+}
diff --git a/src/sqlancer/tidb/visitor/TiDBToStringVisitor.java b/src/sqlancer/tidb/visitor/TiDBToStringVisitor.java
@@ -189,4 +189,4 @@ public void visit(TiDBCase op) {
 		}
 		sb.append(" END )");
 	}
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -81,4 +81,4 @@ public void setDatabaseName(String databaseName) {`
`81`	`81`	`this.databaseName = databaseName;`
`82`	`82`	`}`
`83`	`83`
`84`		`-}`
	`84`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -79,4 +79,4 @@ public void executeStatements() throws SQLException {`
`79`	`79`	`total--;`
`80`	`80`	`}`
`81`	`81`	`}`
`82`		`-}`
	`82`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -152,4 +152,4 @@ public String getTextRepresentation() {`
`152`	`152`
`153`	`153`	`}`
`154`	`154`
`155`		`-}`
	`155`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -41,4 +41,4 @@ public void check() throws SQLException {`
`41`	`41`	`TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);`
`42`	`42`	`}`
`43`	`43`
`44`		`-}`
	`44`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -49,4 +49,4 @@ List<CockroachDBExpression> generateFetchColumns() {`
`49`	`49`	`return columns;`
`50`	`50`	`}`
`51`	`51`
`52`		`-}`
	`52`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -436,4 +436,4 @@ public Node<DuckDBExpression> generateAggregate() {`
`436`	`436`	`return generateArgsForAggregate(aggrFunc);`
`437`	`437`	`}`
`438`	`438`
`439`		`-}`
	`439`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -42,4 +42,4 @@ public void check() throws SQLException {`
`42`	`42`	`TestOracle.assumeResultSetsAreEqual(resultSet, secondResultSet, originalQueryString, combinedString, state);`
`43`	`43`	`}`
`44`	`44`
`45`		`-}`
	`45`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -53,4 +53,4 @@ List<Node<DuckDBExpression>> generateFetchColumns() {`
`53`	`53`	`return columns;`
`54`	`54`	`}`
`55`	`55`
`56`		`-}`
	`56`	`+}`