Pull up isPrimaryKey() and hasPrimaryKey() into abstract base classes

mrigger · claude · mrigger · commit 3cdb5c51ce00 · 2026-04-10T22:18:43.000+08:00
Add isPrimaryKey() to AbstractTableColumn (default false) and hasPrimaryKey() to AbstractTable, replacing duplicate implementations in MySQL, OceanBase, and TiDB. Add @OverRide to all database-specific isPrimaryKey() methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
diff --git a/src/sqlancer/cockroachdb/CockroachDBSchema.java b/src/sqlancer/cockroachdb/CockroachDBSchema.java
@@ -182,6 +182,7 @@ public CockroachDBColumn(String name, CockroachDBCompositeDataType columnType, b
             this.isNullable = isNullable;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
diff --git a/src/sqlancer/common/schema/AbstractTable.java b/src/sqlancer/common/schema/AbstractTable.java
@@ -95,6 +95,10 @@ public boolean isView() {
         return isView;
     }
 
+    public boolean hasPrimaryKey() {
+        return columns.stream().anyMatch(c -> c.isPrimaryKey());
+    }
+
     public String getFreeColumnName() {
         int i = 0;
         if (Randomly.getBooleanWithRatherLowProbability()) {
diff --git a/src/sqlancer/common/schema/AbstractTableColumn.java b/src/sqlancer/common/schema/AbstractTableColumn.java
@@ -12,6 +12,10 @@ public AbstractTableColumn(String name, T table, U type) {
         this.type = type;
     }
 
+    public boolean isPrimaryKey() {
+        return false;
+    }
+
     public String getName() {
         return name;
     }
diff --git a/src/sqlancer/databend/DatabendSchema.java b/src/sqlancer/databend/DatabendSchema.java
@@ -148,6 +148,7 @@ public DatabendColumn(String name, DatabendCompositeDataType columnType, boolean
             this.isNullable = isNullable;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
diff --git a/src/sqlancer/duckdb/DuckDBSchema.java b/src/sqlancer/duckdb/DuckDBSchema.java
@@ -132,6 +132,7 @@ public DuckDBColumn(String name, DuckDBCompositeDataType columnType, boolean isP
             this.isNullable = isNullable;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
diff --git a/src/sqlancer/mariadb/MariaDBSchema.java b/src/sqlancer/mariadb/MariaDBSchema.java
@@ -51,6 +51,7 @@ public int getPrecision() {
             return precision;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
diff --git a/src/sqlancer/mysql/MySQLSchema.java b/src/sqlancer/mysql/MySQLSchema.java
@@ -76,6 +76,7 @@ public int getPrecision() {
             return precision;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
@@ -194,10 +195,6 @@ public MySQLEngine getEngine() {
             return engine;
         }
 
-        public boolean hasPrimaryKey() {
-            return getColumns().stream().anyMatch(c -> c.isPrimaryKey());
-        }
-
     }
 
     public static final class MySQLIndex extends TableIndex {
diff --git a/src/sqlancer/oceanbase/OceanBaseSchema.java b/src/sqlancer/oceanbase/OceanBaseSchema.java
@@ -81,6 +81,7 @@ public int getPrecision() {
             return precision;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
@@ -195,10 +196,6 @@ public OceanBaseTable(String tableName, List<OceanBaseColumn> columns, List<Ocea
             super(tableName, columns, indexes, false);
         }
 
-        public boolean hasPrimaryKey() {
-            return getColumns().stream().anyMatch(c -> c.isPrimaryKey());
-        }
-
     }
 
     public static final class OceanBaseIndex extends TableIndex {
diff --git a/src/sqlancer/presto/PrestoSchema.java b/src/sqlancer/presto/PrestoSchema.java
@@ -453,6 +453,7 @@ public PrestoColumn(String name, PrestoCompositeDataType columnType, boolean isP
             this.isNullable = isNullable;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
diff --git a/src/sqlancer/sqlite3/schema/SQLite3Schema.java b/src/sqlancer/sqlite3/schema/SQLite3Schema.java
@@ -78,6 +78,7 @@ public SQLite3Column(String rowId, SQLite3DataType columnType, boolean isInteger
             this.generated = generated;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
diff --git a/src/sqlancer/tidb/TiDBSchema.java b/src/sqlancer/tidb/TiDBSchema.java
@@ -170,6 +170,7 @@ public TiDBColumn(String name, TiDBCompositeDataType columnType, boolean isPrima
             this.hasDefault = hasDefault;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }
@@ -297,10 +298,6 @@ public TiDBTable(String tableName, List<TiDBColumn> columns, List<TableIndex> in
             super(tableName, columns, indexes, isView);
         }
 
-        public boolean hasPrimaryKey() {
-            return getColumns().stream().anyMatch(c -> c.isPrimaryKey());
-        }
-
     }
 
     public static TiDBSchema fromConnection(SQLConnection con, String databaseName) throws SQLException {
diff --git a/src/sqlancer/yugabyte/ycql/YCQLSchema.java b/src/sqlancer/yugabyte/ycql/YCQLSchema.java
@@ -126,6 +126,7 @@ public YCQLColumn(String name, YCQLCompositeDataType columnType, boolean isPrima
             this.isNullable = isNullable;
         }
 
+        @Override
         public boolean isPrimaryKey() {
             return isPrimaryKey;
         }

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,7 @@ public CockroachDBColumn(String name, CockroachDBCompositeDataType columnType, b`
`182`	`182`	`this.isNullable = isNullable;`
`183`	`183`	`}`
`184`	`184`
	`185`	`+ @Override`
`185`	`186`	`public boolean isPrimaryKey() {`
`186`	`187`	`return isPrimaryKey;`
`187`	`188`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,10 @@ public AbstractTableColumn(String name, T table, U type) {`
`12`	`12`	`this.type = type;`
`13`	`13`	`}`
`14`	`14`
	`15`	`+ public boolean isPrimaryKey() {`
	`16`	`+ return false;`
	`17`	`+ }`
	`18`	`+`
`15`	`19`	`public String getName() {`
`16`	`20`	`return name;`
`17`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,7 @@ public DatabendColumn(String name, DatabendCompositeDataType columnType, boolean`
`148`	`148`	`this.isNullable = isNullable;`
`149`	`149`	`}`
`150`	`150`
	`151`	`+ @Override`
`151`	`152`	`public boolean isPrimaryKey() {`
`152`	`153`	`return isPrimaryKey;`
`153`	`154`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,7 @@ public DuckDBColumn(String name, DuckDBCompositeDataType columnType, boolean isP`
`132`	`132`	`this.isNullable = isNullable;`
`133`	`133`	`}`
`134`	`134`
	`135`	`+ @Override`
`135`	`136`	`public boolean isPrimaryKey() {`
`136`	`137`	`return isPrimaryKey;`
`137`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ public int getPrecision() {`
`51`	`51`	`return precision;`
`52`	`52`	`}`
`53`	`53`
	`54`	`+ @Override`
`54`	`55`	`public boolean isPrimaryKey() {`
`55`	`56`	`return isPrimaryKey;`
`56`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,7 @@ public int getPrecision() {`
`76`	`76`	`return precision;`
`77`	`77`	`}`
`78`	`78`
	`79`	`+ @Override`
`79`	`80`	`public boolean isPrimaryKey() {`
`80`	`81`	`return isPrimaryKey;`
`81`	`82`	`}`
`@@ -194,10 +195,6 @@ public MySQLEngine getEngine() {`
`194`	`195`	`return engine;`
`195`	`196`	`}`
`196`	`197`
`197`		`- public boolean hasPrimaryKey() {`
`198`		`- return getColumns().stream().anyMatch(c -> c.isPrimaryKey());`
`199`		`- }`
`200`		`-`
`201`	`198`	`}`
`202`	`199`
`203`	`200`	`public static final class MySQLIndex extends TableIndex {`
Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ public int getPrecision() {`
`81`	`81`	`return precision;`
`82`	`82`	`}`
`83`	`83`
	`84`	`+ @Override`
`84`	`85`	`public boolean isPrimaryKey() {`
`85`	`86`	`return isPrimaryKey;`
`86`	`87`	`}`
`@@ -195,10 +196,6 @@ public OceanBaseTable(String tableName, List<OceanBaseColumn> columns, List<Ocea`
`195`	`196`	`super(tableName, columns, indexes, false);`
`196`	`197`	`}`
`197`	`198`
`198`		`- public boolean hasPrimaryKey() {`
`199`		`- return getColumns().stream().anyMatch(c -> c.isPrimaryKey());`
`200`		`- }`
`201`		`-`
`202`	`199`	`}`
`203`	`200`
`204`	`201`	`public static final class OceanBaseIndex extends TableIndex {`
Original file line number	Diff line number	Diff line change
`@@ -453,6 +453,7 @@ public PrestoColumn(String name, PrestoCompositeDataType columnType, boolean isP`
`453`	`453`	`this.isNullable = isNullable;`
`454`	`454`	`}`
`455`	`455`
	`456`	`+ @Override`
`456`	`457`	`public boolean isPrimaryKey() {`
`457`	`458`	`return isPrimaryKey;`
`458`	`459`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,7 @@ public SQLite3Column(String rowId, SQLite3DataType columnType, boolean isInteger`
`78`	`78`	`this.generated = generated;`
`79`	`79`	`}`
`80`	`80`
	`81`	`+ @Override`
`81`	`82`	`public boolean isPrimaryKey() {`
`82`	`83`	`return isPrimaryKey;`
`83`	`84`	`}`