Refactor: Replace .size() == 0 or .length() > 0 etc checks with .isEmpty()

SharmaNishchay · SharmaNishchay · commit 3c9bcb49d16a · 2025-03-09T17:40:24.000+05:30
diff --git a/src/sqlancer/clickhouse/ast/constant/ClickHouseStringConstant.java b/src/sqlancer/clickhouse/ast/constant/ClickHouseStringConstant.java
@@ -32,7 +32,7 @@ public String toString() {
 
     @Override
     public boolean asBooleanNotNull() {
-        return value.length() > 0;
+        return !value.isEmpty();
     }
 
     @Override
diff --git a/src/sqlancer/cnosdb/CnosDBLoggableFactory.java b/src/sqlancer/cnosdb/CnosDBLoggableFactory.java
@@ -19,7 +19,7 @@ protected Loggable createLoggable(String input, String suffix) {
         if (!input.endsWith(";")) {
             completeString += ";";
         }
-        if (suffix != null && suffix.length() != 0) {
+        if (suffix != null && !suffix.isEmpty()) {
             completeString += suffix;
         }
         return new LoggedString(completeString);
diff --git a/src/sqlancer/cnosdb/CnosDBToStringVisitor.java b/src/sqlancer/cnosdb/CnosDBToStringVisitor.java
@@ -137,7 +137,7 @@ public void visit(CnosDBSelect s) {
             sb.append(" WHERE ");
             visit(s.getWhereClause());
         }
-        if (s.getGroupByExpressions().size() > 0) {
+        if (!s.getGroupByExpressions().isEmpty()) {
             sb.append(" GROUP BY ");
             visit(s.getGroupByExpressions());
         }
diff --git a/src/sqlancer/cockroachdb/gen/CockroachDBExpressionGenerator.java b/src/sqlancer/cockroachdb/gen/CockroachDBExpressionGenerator.java
@@ -457,7 +457,7 @@ public String generateUnoptimizedQueryString(CockroachDBSelect select, Cockroach
 
     @Override
     public List<CockroachDBExpression> generateFetchColumns(boolean shouldCreateDummy) {
-        if (shouldCreateDummy || columns.size() == 0) {
+        if (shouldCreateDummy || columns.isEmpty()) {
             return List.of(new CockroachDBColumnReference(new CockroachDBColumn("*", null, false, false)));
         }
         return Randomly.nonEmptySubset(columns).stream().map(c -> new CockroachDBColumnReference(c))
@@ -541,7 +541,7 @@ boolean mutateWhere(CockroachDBSelect select) {
     }
 
     boolean mutateGroupBy(CockroachDBSelect select) {
-        boolean increase = select.getGroupByExpressions().size() > 0;
+        boolean increase = !select.getGroupByExpressions().isEmpty();
         if (increase) {
             select.clearGroupByExpressions();
         } else {
@@ -551,7 +551,7 @@ boolean mutateGroupBy(CockroachDBSelect select) {
     }
 
     boolean mutateHaving(CockroachDBSelect select) {
-        if (select.getGroupByExpressions().size() == 0) {
+        if (select.getGroupByExpressions().isEmpty()) {
             select.setGroupByExpressions(select.getFetchColumns());
             select.setHavingClause(generateExpression(CockroachDBDataType.BOOL.get()));
             return false;
diff --git a/src/sqlancer/cockroachdb/oracle/CockroachDBCERTOracle.java b/src/sqlancer/cockroachdb/oracle/CockroachDBCERTOracle.java
@@ -177,7 +177,7 @@ protected boolean mutateWhere() {
 
     @Override
     protected boolean mutateGroupBy() {
-        boolean increase = select.getGroupByExpressions().size() > 0;
+        boolean increase = !select.getGroupByExpressions().isEmpty();
         if (increase) {
             select.clearGroupByExpressions();
         } else {
@@ -188,7 +188,7 @@ protected boolean mutateGroupBy() {
 
     @Override
     protected boolean mutateHaving() {
-        if (select.getGroupByExpressions().size() == 0) {
+        if (select.getGroupByExpressions().isEmpty()) {
             select.setGroupByExpressions(select.getFetchColumns());
             select.setHavingClause(gen.generateExpression(CockroachDBDataType.BOOL.get()));
             return false;
diff --git a/src/sqlancer/cockroachdb/oracle/tlp/CockroachDBTLPBase.java b/src/sqlancer/cockroachdb/oracle/tlp/CockroachDBTLPBase.java
@@ -56,7 +56,7 @@ public void check() throws SQLException {
 
     List<CockroachDBExpression> generateFetchColumns() {
         List<CockroachDBExpression> columns = new ArrayList<>();
-        if (Randomly.getBoolean() || targetTables.getColumns().size() == 0) {
+        if (Randomly.getBoolean() || targetTables.getColumns().isEmpty()) {
             columns.add(new CockroachDBColumnReference(new CockroachDBColumn("*", null, false, false)));
         } else {
             columns.addAll(Randomly.nonEmptySubset(targetTables.getColumns()).stream()
diff --git a/src/sqlancer/common/log/SQLLoggableFactory.java b/src/sqlancer/common/log/SQLLoggableFactory.java
@@ -16,7 +16,7 @@ protected Loggable createLoggable(String input, String suffix) {
         }
         completeString = completeString.replace("\n", "\\n");
         completeString = completeString.replace("\r", "\\r");
-        if (suffix != null && suffix.length() != 0) {
+        if (suffix != null && !suffix.isEmpty()) {
             completeString += suffix;
         }
         return new LoggedString(completeString);
diff --git a/src/sqlancer/doris/gen/DorisDropViewGenerator.java b/src/sqlancer/doris/gen/DorisDropViewGenerator.java
@@ -11,7 +11,7 @@ private DorisDropViewGenerator() {
     }
 
     public static SQLQueryAdapter dropView(DorisGlobalState globalState) {
-        if (globalState.getSchema().getTables(t -> t.isView()).size() == 0) {
+        if (globalState.getSchema().getTables(t -> t.isView()).isEmpty()) {
             throw new IgnoreMeException();
         }
         StringBuilder sb = new StringBuilder("DROP VIEW ");
diff --git a/src/sqlancer/mariadb/ast/MariaDBStringVisitor.java b/src/sqlancer/mariadb/ast/MariaDBStringVisitor.java
@@ -54,7 +54,7 @@ public void visit(MariaDBSelectStatement s) {
             sb.append(" WHERE ");
             visit(s.getWhereCondition());
         }
-        if (s.getGroupBys().size() != 0) {
+        if (!s.getGroupBys().isEmpty()) {
             sb.append(" GROUP BY ");
             for (i = 0; i < s.getGroupBys().size(); i++) {
                 if (i != 0) {
diff --git a/src/sqlancer/materialize/MaterializeToStringVisitor.java b/src/sqlancer/materialize/MaterializeToStringVisitor.java
@@ -139,7 +139,7 @@ public void visit(MaterializeSelect s) {
             sb.append(" WHERE ");
             visit(s.getWhereClause());
         }
-        if (s.getGroupByExpressions().size() > 0) {
+        if (!s.getGroupByExpressions().isEmpty()) {
             sb.append(" GROUP BY ");
             visit(s.getGroupByExpressions());
         }
diff --git a/src/sqlancer/mysql/MySQLToStringVisitor.java b/src/sqlancer/mysql/MySQLToStringVisitor.java
@@ -59,7 +59,7 @@ public void visit(MySQLSelect s) {
             throw new AssertionError();
         }
         sb.append(s.getModifiers().stream().collect(Collectors.joining(" ")));
-        if (s.getModifiers().size() > 0) {
+        if (!s.getModifiers().isEmpty()) {
             sb.append(" ");
         }
         if (s.getFetchColumns() == null) {
@@ -92,7 +92,7 @@ public void visit(MySQLSelect s) {
             sb.append(" WHERE ");
             visit(whereClause);
         }
-        if (s.getGroupByExpressions() != null && s.getGroupByExpressions().size() > 0) {
+        if (s.getGroupByExpressions() != null && !s.getGroupByExpressions().isEmpty()) {
             sb.append(" ");
             sb.append("GROUP BY ");
             List<MySQLExpression> groupBys = s.getGroupByExpressions();
diff --git a/src/sqlancer/mysql/ast/MySQLBinaryOperation.java b/src/sqlancer/mysql/ast/MySQLBinaryOperation.java
@@ -78,20 +78,20 @@ public MySQLConstant getExpectedValue() {
         /* workaround for https://bugs.mysql.com/bug.php?id=95960 */
         if (leftExpected.isString()) {
             String text = leftExpected.castAsString();
-            while ((text.startsWith(" ") || text.startsWith("\t")) && text.length() > 0) {
+            while ((text.startsWith(" ") || text.startsWith("\t")) && !text.isEmpty()) {
                 text = text.substring(1);
             }
-            if (text.length() > 0 && (text.startsWith("\n") || text.startsWith("."))) {
+            if (!text.isEmpty() && (text.startsWith("\n") || text.startsWith("."))) {
                 throw new IgnoreMeException();
             }
         }
 
         if (rightExpected.isString()) {
             String text = rightExpected.castAsString();
-            while ((text.startsWith(" ") || text.startsWith("\t")) && text.length() > 0) {
+            while ((text.startsWith(" ") || text.startsWith("\t")) && !text.isEmpty()) {
                 text = text.substring(1);
             }
-            if (text.length() > 0 && (text.startsWith("\n") || text.startsWith("."))) {
+            if (!text.isEmpty() && (text.startsWith("\n") || text.startsWith("."))) {
                 throw new IgnoreMeException();
             }
         }
diff --git a/src/sqlancer/mysql/gen/MySQLExpressionGenerator.java b/src/sqlancer/mysql/gen/MySQLExpressionGenerator.java
@@ -301,7 +301,7 @@ boolean mutateWhere(MySQLSelect select) {
     }
 
     boolean mutateGroupBy(MySQLSelect select) {
-        boolean increase = select.getGroupByExpressions().size() > 0;
+        boolean increase = !select.getGroupByExpressions().isEmpty();
         if (increase) {
             select.clearGroupByExpressions();
         } else {
@@ -311,7 +311,7 @@ boolean mutateGroupBy(MySQLSelect select) {
     }
 
     boolean mutateHaving(MySQLSelect select) {
-        if (select.getGroupByExpressions().size() == 0) {
+        if (select.getGroupByExpressions().isEmpty()) {
             select.setGroupByExpressions(select.getFetchColumns());
             select.setHavingClause(generateExpression());
             return false;
diff --git a/src/sqlancer/oceanbase/OceanBaseToStringVisitor.java b/src/sqlancer/oceanbase/OceanBaseToStringVisitor.java
@@ -56,7 +56,7 @@ public void visit(OceanBaseSelect s) {
             throw new AssertionError();
         }
         sb.append(s.getModifiers().stream().collect(Collectors.joining(" ")));
-        if (s.getModifiers().size() > 0) {
+        if (!s.getModifiers().isEmpty()) {
             sb.append(" ");
         }
         if (s.getFetchColumns() == null) {
@@ -85,7 +85,7 @@ public void visit(OceanBaseSelect s) {
             sb.append(" WHERE ");
             visit(whereClause);
         }
-        if (s.getGroupByExpressions() != null && s.getGroupByExpressions().size() > 0) {
+        if (s.getGroupByExpressions() != null && !s.getGroupByExpressions().isEmpty()) {
             sb.append(" ");
             sb.append("GROUP BY ");
             List<OceanBaseExpression> groupBys = s.getGroupByExpressions();
@@ -260,7 +260,7 @@ public void visit(OceanBaseStringExpression op) {
             sb.append(op.getStr());
         } else {
             String str = op.getStr();
-            if (str.length() > 0) {
+            if (!str.isEmpty()) {
                 sb.append(r.getInteger(0, 100000));
             } else {
                 sb.append(r.getInteger(0, 1000000));
diff --git a/src/sqlancer/oceanbase/ast/OceanBaseConstant.java b/src/sqlancer/oceanbase/ast/OceanBaseConstant.java
@@ -194,7 +194,7 @@ public boolean isNull() {
         @Override
         public boolean isEmpty() {
             // "" " "
-            if (value.length() == 0) {
+            if (value.isEmpty()) {
                 return true;
             } else {
                 for (int i = 0; i < value.length(); i++) {
diff --git a/src/sqlancer/postgres/PostgresToStringVisitor.java b/src/sqlancer/postgres/PostgresToStringVisitor.java
@@ -161,7 +161,7 @@ public void visit(PostgresSelect s) {
             sb.append(" WHERE ");
             visit(s.getWhereClause());
         }
-        if (s.getGroupByExpressions().size() > 0) {
+        if (!s.getGroupByExpressions().isEmpty()) {
             sb.append(" GROUP BY ");
             visit(s.getGroupByExpressions());
         }
diff --git a/src/sqlancer/postgres/gen/PostgresExpressionGenerator.java b/src/sqlancer/postgres/gen/PostgresExpressionGenerator.java
@@ -819,7 +819,7 @@ boolean mutateWhere(PostgresSelect select) {
     }
 
     boolean mutateGroupBy(PostgresSelect select) {
-        boolean increase = select.getGroupByExpressions().size() > 0;
+        boolean increase = !select.getGroupByExpressions().isEmpty();
         if (increase) {
             select.clearGroupByExpressions();
         } else {
@@ -829,7 +829,7 @@ boolean mutateGroupBy(PostgresSelect select) {
     }
 
     boolean mutateHaving(PostgresSelect select) {
-        if (select.getGroupByExpressions().size() == 0) {
+        if (select.getGroupByExpressions().isEmpty()) {
             select.setGroupByExpressions(select.getFetchColumns());
             select.setHavingClause(generateExpression(0, PostgresDataType.BOOLEAN));
             return false;
diff --git a/src/sqlancer/sqlite3/SQLite3ToStringVisitor.java b/src/sqlancer/sqlite3/SQLite3ToStringVisitor.java
@@ -139,7 +139,7 @@ public void visit(SQLite3Select s, boolean inner) {
             visit(whereClause);
             sb.append(")");
         }
-        if (s.getGroupByClause().size() > 0) {
+        if (!s.getGroupByClause().isEmpty()) {
             sb.append(" ");
             sb.append("GROUP BY ");
             visit(s.getGroupByClause());
diff --git a/src/sqlancer/tidb/TiDBExpressionGenerator.java b/src/sqlancer/tidb/TiDBExpressionGenerator.java
@@ -318,7 +318,7 @@ boolean mutateWhere(TiDBSelect select) {
     }
 
     boolean mutateHaving(TiDBSelect select) {
-        if (select.getGroupByExpressions().size() == 0) {
+        if (select.getGroupByExpressions().isEmpty()) {
             select.setGroupByExpressions(select.getFetchColumns());
             select.setHavingClause(generateExpression());
             return false;
@@ -367,7 +367,7 @@ boolean mutateLimit(TiDBSelect select) {
     }
 
     private boolean mutateGroupBy(TiDBSelect select) {
-        boolean increase = select.getGroupByExpressions().size() > 0;
+        boolean increase = !select.getGroupByExpressions().isEmpty();
         if (increase) {
             select.clearGroupByExpressions();
             select.clearHavingClause();
diff --git a/src/sqlancer/tidb/gen/TiDBDropViewGenerator.java b/src/sqlancer/tidb/gen/TiDBDropViewGenerator.java
@@ -11,7 +11,7 @@ private TiDBDropViewGenerator() {
     }
 
     public static SQLQueryAdapter dropView(TiDBGlobalState globalState) {
-        if (globalState.getSchema().getTables(t -> t.isView()).size() == 0) {
+        if (globalState.getSchema().getTables(t -> t.isView()).isEmpty()) {
             throw new IgnoreMeException();
         }
         StringBuilder sb = new StringBuilder("DROP VIEW ");
diff --git a/src/sqlancer/tidb/gen/TiDBTableGenerator.java b/src/sqlancer/tidb/gen/TiDBTableGenerator.java
@@ -47,7 +47,7 @@ public SQLQueryAdapter getQuery(TiDBGlobalState globalState) throws SQLException
         StringBuilder sb = new StringBuilder("CREATE TABLE ");
         sb.append(tableName);
 
-        if (Randomly.getBoolean() && globalState.getSchema().getDatabaseTables().size() > 0) {
+        if (Randomly.getBoolean() && !globalState.getSchema().getDatabaseTables().isEmpty()) {
             sb.append(" LIKE ");
             TiDBTable otherTable = globalState.getSchema().getRandomTable();
             sb.append(otherTable.getName());
diff --git a/src/sqlancer/yugabyte/ysql/YSQLToStringVisitor.java b/src/sqlancer/yugabyte/ysql/YSQLToStringVisitor.java
@@ -127,7 +127,7 @@ public void visit(YSQLSelect s) {
             sb.append(" WHERE ");
             visit(s.getWhereClause());
         }
-        if (s.getGroupByExpressions().size() > 0) {
+        if (!s.getGroupByExpressions().isEmpty()) {
             sb.append(" GROUP BY ");
             visit(s.getGroupByExpressions());
         }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public String toString() {`
`32`	`32`
`33`	`33`	`@Override`
`34`	`34`	`public boolean asBooleanNotNull() {`
`35`		`- return value.length() > 0;`
	`35`	`+ return !value.isEmpty();`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ protected Loggable createLoggable(String input, String suffix) {`
`19`	`19`	`if (!input.endsWith(";")) {`
`20`	`20`	`completeString += ";";`
`21`	`21`	`}`
`22`		`- if (suffix != null && suffix.length() != 0) {`
	`22`	`+ if (suffix != null && !suffix.isEmpty()) {`
`23`	`23`	`completeString += suffix;`
`24`	`24`	`}`
`25`	`25`	`return new LoggedString(completeString);`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ public void visit(CnosDBSelect s) {`
`137`	`137`	`sb.append(" WHERE ");`
`138`	`138`	`visit(s.getWhereClause());`
`139`	`139`	`}`
`140`		`- if (s.getGroupByExpressions().size() > 0) {`
	`140`	`+ if (!s.getGroupByExpressions().isEmpty()) {`
`141`	`141`	`sb.append(" GROUP BY ");`
`142`	`142`	`visit(s.getGroupByExpressions());`
`143`	`143`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ protected Loggable createLoggable(String input, String suffix) {`
`16`	`16`	`}`
`17`	`17`	`completeString = completeString.replace("\n", "\\n");`
`18`	`18`	`completeString = completeString.replace("\r", "\\r");`
`19`		`- if (suffix != null && suffix.length() != 0) {`
	`19`	`+ if (suffix != null && !suffix.isEmpty()) {`
`20`	`20`	`completeString += suffix;`
`21`	`21`	`}`
`22`	`22`	`return new LoggedString(completeString);`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ private DorisDropViewGenerator() {`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`public static SQLQueryAdapter dropView(DorisGlobalState globalState) {`
`14`		`- if (globalState.getSchema().getTables(t -> t.isView()).size() == 0) {`
	`14`	`+ if (globalState.getSchema().getTables(t -> t.isView()).isEmpty()) {`
`15`	`15`	`throw new IgnoreMeException();`
`16`	`16`	`}`
`17`	`17`	`StringBuilder sb = new StringBuilder("DROP VIEW ");`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public void visit(MariaDBSelectStatement s) {`
`54`	`54`	`sb.append(" WHERE ");`
`55`	`55`	`visit(s.getWhereCondition());`
`56`	`56`	`}`
`57`		`- if (s.getGroupBys().size() != 0) {`
	`57`	`+ if (!s.getGroupBys().isEmpty()) {`
`58`	`58`	`sb.append(" GROUP BY ");`
`59`	`59`	`for (i = 0; i < s.getGroupBys().size(); i++) {`
`60`	`60`	`if (i != 0) {`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public void visit(MaterializeSelect s) {`
`139`	`139`	`sb.append(" WHERE ");`
`140`	`140`	`visit(s.getWhereClause());`
`141`	`141`	`}`
`142`		`- if (s.getGroupByExpressions().size() > 0) {`
	`142`	`+ if (!s.getGroupByExpressions().isEmpty()) {`
`143`	`143`	`sb.append(" GROUP BY ");`
`144`	`144`	`visit(s.getGroupByExpressions());`
`145`	`145`	`}`