Move to the LLVM backend of emscripten (#356)

lovasoa · web-flow · commit 1e7b28fa8f9e · 2020-03-06T19:18:54.000+01:00
* Update emsdk

* emsdk 1.39.9
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -7,13 +7,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v1
-    - uses: mymindstorm/setup-emsdk@v1
-      with: {version: '1.39.8-fastcomp'}
+    - uses: mymindstorm/setup-emsdk@b6b33c4
+      with: {version: '1.39.9'}
     - uses: actions/cache@v1
       id: cache
       with:
         path: ~/.emscripten_cache
-        key: emscripten-1.39.8-fastcomp
+        key: emscripten-1.39.9
     - name: make
       run: make
     - uses: actions/upload-artifact@master
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,8 +13,7 @@ jobs:
     steps:
       - uses: actions/checkout@v1
       - uses: mymindstorm/setup-emsdk@v1
-        with:
-          version: '1.39.8-fastcomp'
+        with: {version: '1.39.9'}
       - name: make
         run: make
       - name: Create Release
diff --git a/src/api.js b/src/api.js
@@ -875,8 +875,6 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
     @return {Database} The database object. Useful for method chaining
      */
     Database.prototype["create_function"] = function create_function(name, func) {
-        // TODO : add type arguments for compatibility with the llvm backend
-        // https://emscripten.org/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.html#calling-javascript-functions-as-function-pointers-from-c
         var func_ptr;
         function wrapped_func(cx, argc, argv) {
             var result;
