Skip to content

Commit bfe779d

Browse files
author
Brendan Whitfield
committed
updated tests for new lone-response logic
1 parent 0554db1 commit bfe779d

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

tests/test_OBD.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,28 +77,34 @@ def write(cmd):
7777
assert r.raw_data == fromCar
7878
assert r.is_null()
7979

80-
# disregard responses from other ECUs -------------------------------------
80+
# accept responses from other ECUs (when single response) -------------------------------------------------------
8181
fromCar = "48 6B 12 41 23 AB CD 10\r\r"
8282
r = o.query(cmd, force=True)
8383
assert toCar[0] == "0123"
8484
assert r.raw_data == fromCar
85+
assert r.value == "ABCD"
86+
87+
# disregard responses from other ECUs (when multiple responses)-------------------------------------
88+
fromCar = "48 6B 12 41 23 AB CD 10\r\r48 6B 12 41 23 AB CD 10\r\r"
89+
r = o.query(cmd, force=True)
90+
assert toCar[0] == "0123"
91+
assert r.raw_data == fromCar
8592
assert r.is_null()
8693

8794
# filter for ECU 10 -------------------------------------------------------
88-
fromCar = "48 6B 12 41 23 AB CD\r\r 48 6B 10 41 23 AB CD 10\r\r"
95+
fromCar = "48 6B 12 41 23 AB CD 10\r\r 48 6B 10 41 23 AB CD 10\r\r"
8996
r = o.query(cmd, force=True)
9097
assert toCar[0] == "0123"
9198
assert r.raw_data == fromCar
9299
assert r.value == "ABCD"
93100

94101
# ignore multiline responses ----------------------------------------------
95-
fromCar = "48 6B 10 41 23 AB CD\r\r 48 6B 10 41 23 AB CD 10\r\r"
102+
fromCar = "48 6B 10 41 23 AB CD 10\r\r 48 6B 10 41 23 AB CD 10\r\r"
96103
r = o.query(cmd, force=True)
97104
assert toCar[0] == "0123"
98105
assert r.raw_data == fromCar
99106
assert r.is_null()
100107

101108

102-
103109
def test_load_commands():
104110
pass

0 commit comments

Comments
 (0)