wrote tests for command tables

Brendan Whitfield · Brendan Whitfield · commit 1227f34311dc · 2014-11-27T01:35:13.000-05:00
diff --git a/tests/test_Commands.py b/tests/test_Commands.py
@@ -0,0 +1,56 @@
+
+import obd
+from obd.decoders import pid
+
+
+def test_list_integrity():
+	for mode, cmds in enumerate(obd.commands.modes):
+		for pid, cmd in enumerate(cmds):
+
+			# make sure the command tables are in mode & PID order
+			assert mode == cmd.get_mode_int()
+			assert pid == cmd.get_pid_int()
+
+			# make sure all the fields are set
+			assert cmd.name != ""
+			assert cmd.desc != ""
+			assert (mode >= 1) and (mode <= 9)			
+			assert (pid >= 0) and (pid <= 196)
+			assert cmd.bytes >= 0
+			assert hasattr(cmd.decode, '__call__')
+
+
+def test_unique_names():
+	# make sure no two commands have the same name
+	names = {}
+
+	for cmds in obd.commands.modes:
+		for cmd in cmds:
+			assert not names.has_key(cmd.name)
+			names[cmd.name] = True
+
+
+def test_getitem_mode_pid():
+	# ensure that obd.commands[mode][pid] works correctly
+	for cmds in obd.commands.modes:
+		for cmd in cmds:
+			mode = cmd.get_mode_int()
+			pid  = cmd.get_pid_int()
+			assert cmd == obd.commands[mode][pid]
+
+
+def test_getitem_name():
+	# ensure that obd.commands[name] works correctly
+	for cmds in obd.commands.modes:
+		for cmd in cmds:
+			assert cmd == obd.commands[cmd.name]
+
+
+def test_pid_getters():
+	# ensure that all pid getters are found
+	pid_getters = obd.commands.pid_getters()
+
+	for cmds in obd.commands.modes:
+		for cmd in cmds:
+			if cmd.decode == pid:
+				assert cmd in pid_getters
diff --git a/tests/test_OBD.py b/tests/test_OBD.py
@@ -5,6 +5,13 @@
 from obd.decoders import noop
 
 
+def test_is_connected():
+	o = obd.OBD("/dev/null")
+	assert not o.is_connected()
+
+	# todo
+
+
 def test_query():
 	# we don't need an actual serial connection
 	o = obd.OBD("/dev/null")
@@ -26,6 +33,11 @@ def send(cmd):
 
 	# test
 
+	fromCar = "41 23 AB CD\r\r"
+	r = o.query(cmd)             # make sure unsupported commands don't send
+	assert toCar[0] == ""
+	assert r.is_null()
+
 	fromCar = "41 23 AB CD\r\r"  # preset the response
 	r = o.query(cmd, True)       # run
 	assert toCar[0] == "0123"    # verify that the command was sent correctly
@@ -37,7 +49,7 @@ def send(cmd):
 	assert r.raw_data == fromCar
 	assert r.is_null()
 
-	fromCar = "totaly not hex!"
+	fromCar = "totaly not hex!@#$"
 	r = o.query(cmd, True)
 	assert r.raw_data == fromCar
 	assert r.is_null()
@@ -46,3 +58,7 @@ def send(cmd):
 	r = o.query(cmd, True)
 	assert r.raw_data == fromCar
 	assert r.is_null()
+
+
+def test_load_commands():
+	pass
