Skip to content

Exceptions thrown during AbstractApplicationContext.refresh() not being logged right when they are caught [SPR-12010] #16626

Closed

Description

@spring-projects-issues

Juan Velez opened SPR-12010 and commented

During a refresh() is possible that some beans may throw exceptions which causes the catch(BeanException) block to be executed. In this block the exception is not logged right away which may lead to the exception itself never being reported. Consider the case we encountered where we had (unfortunately) a deadlock situation which only happened once the code in the catch(BeanException) was being executed. The end result was that the system came to a stop and there was no report of any failure because the logging of the exception by spring only happens after the exception is re-thrown


Affects: 3.1.3, 4.0.6

Issue Links:

Backported to: 3.2.11

Activity

  1. spring-projects-issues commented on Jul 22, 2014

    @spring-projects-issues
    CollaboratorAuthor

    Juergen Hoeller commented

    Good point. We're logging such an exception before subsequently trying to cancel the refresh attempt now.

    Juergen

  2. added
    status: backportedAn issue that has been backported to maintenance branches
    in: coreIssues in core modules (aop, beans, core, context, expression)
    on Jan 11, 2019
  3. added this to the 4.0.7 milestone on Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

in: coreIssues in core modules (aop, beans, core, context, expression)status: backportedAn issue that has been backported to maintenance branchestype: enhancementA general enhancement

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions