From b92c2947f817faa34af8f02b42e5806346b07da0 Mon Sep 17 00:00:00 2001 From: Bruno Bieth Date: Mon, 1 Feb 2021 16:13:36 +0100 Subject: [PATCH] feat: add `page` & `per_page` to PullRequestParameters --- .../github/v3/prs/requests/PullRequestParameters.java | 11 +++++++++++ .../v3/prs/requests/PullRequestParametersTest.java | 5 ++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/spotify/github/v3/prs/requests/PullRequestParameters.java b/src/main/java/com/spotify/github/v3/prs/requests/PullRequestParameters.java index 14ec3a67..ad1fc455 100644 --- a/src/main/java/com/spotify/github/v3/prs/requests/PullRequestParameters.java +++ b/src/main/java/com/spotify/github/v3/prs/requests/PullRequestParameters.java @@ -58,5 +58,16 @@ public interface PullRequestParameters extends Parameters { */ Optional direction(); + /** + * Results per page (max 100) + */ + @SuppressWarnings("checkstyle:methodname") + Optional per_page(); + + /** + * Page number of the results to fetch. + */ + Optional page(); + /** Serialize declared non-Object methods as key=value joined by & */ } diff --git a/src/test/java/com/spotify/github/v3/prs/requests/PullRequestParametersTest.java b/src/test/java/com/spotify/github/v3/prs/requests/PullRequestParametersTest.java index c00ece8f..c99faec3 100644 --- a/src/test/java/com/spotify/github/v3/prs/requests/PullRequestParametersTest.java +++ b/src/test/java/com/spotify/github/v3/prs/requests/PullRequestParametersTest.java @@ -36,11 +36,14 @@ public void testFullSerialize() { .head("bogus-head") .sort("bogus-sort") .state("bogus-state") + .page(2) + .per_page(5) .build(); assertThat( params.serialize(), is( - "base=bogus-base&direction=bogus-direction&head=bogus-head&sort=bogus-sort&state=bogus-state")); + "base=bogus-base&direction=bogus-direction&head=bogus-head&page=2" + + "&per_page=5&sort=bogus-sort&state=bogus-state")); } }