Add defaults to ToolFilters (#93)

Ickerday · web-flow · commit b85dd7b8a6b8 · 2026-03-20T20:09:49.000+01:00
* Add defaults to ToolFilters

* Add empty case to tool filtering tests

* Rewrite the tool filtering unit test
diff --git a/splunklib/ai/tool_filtering.py b/splunklib/ai/tool_filtering.py
@@ -22,14 +22,14 @@
 class ToolFilters:
     """Allowlists by which Tools are filtered."""
 
-    allowed_names: Sequence[str]
-    allowed_tags: Sequence[str]
+    allowed_names: Sequence[str] | None = None
+    allowed_tags: Sequence[str] | None = None
 
 
 def _is_allowed(tool: Tool, filters: ToolFilters) -> bool:
     return (
-        tool.name in filters.allowed_names
-        or len(set(filters.allowed_tags).intersection(tool.tags or [])) > 0
+        tool.name in (filters.allowed_names or [])
+        or len(set(filters.allowed_tags or []).intersection(tool.tags or [])) > 0
     )
 
 
diff --git a/tests/unit/ai/test_tools.py b/tests/unit/ai/test_tools.py
@@ -49,8 +49,9 @@ async def no_op() -> ToolResult:
 @pytest.mark.parametrize(
     ("allowed_names", "allowed_tags", "initial_tools", "expected_tools"),
     [
-        (["test_tool_1"], [], TEST_TOOLS, [TEST_TOOL_1]),
-        ([], ["test_tag_2"], TEST_TOOLS, [TEST_TOOL_2, TEST_TOOL_4]),
+        (None, None, [], []),
+        (["test_tool_1"], None, TEST_TOOLS, [TEST_TOOL_1]),
+        (None, ["test_tag_2"], TEST_TOOLS, [TEST_TOOL_2, TEST_TOOL_4]),
         (
             ["test_tool_1"],
             ["test_tag_2"],
@@ -61,8 +62,8 @@ async def no_op() -> ToolResult:
     ],
 )
 def test_filtering(
-    allowed_names: Sequence[str],
-    allowed_tags: Sequence[str],
+    allowed_names: Sequence[str] | None,
+    allowed_tags: Sequence[str] | None,
     initial_tools: Sequence[Tool],
     expected_tools: Sequence[Tool],
 ) -> None:
