-
Notifications
You must be signed in to change notification settings - Fork 13
Expand file tree
/
Copy pathtest_splits_synchronizer.py
More file actions
1415 lines (1193 loc) · 59.8 KB
/
test_splits_synchronizer.py
File metadata and controls
1415 lines (1193 loc) · 59.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
"""Split Worker tests."""
import pytest
import os
import json
import copy
import queue
from splitio.util.backoff import Backoff
from splitio.api import APIException
from splitio.api.commons import FetchOptions
from splitio.storage import SplitStorage, RuleBasedSegmentsStorage
from splitio.storage.inmemmory import InMemorySplitStorage, InMemorySplitStorageAsync, InMemoryRuleBasedSegmentStorage, InMemoryRuleBasedSegmentStorageAsync
from splitio.storage import FlagSetsFilter
from splitio.models.splits import Split
from splitio.models.rule_based_segments import RuleBasedSegment
from splitio.sync.split import SplitSynchronizer, SplitSynchronizerAsync, LocalSplitSynchronizer, LocalSplitSynchronizerAsync, LocalhostMode
from splitio.optional.loaders import aiofiles, asyncio
from tests.integration import splits_json, rbsegments_json
splits_raw = [{
'changeNumber': 123,
'trafficTypeName': 'user',
'name': 'some_name',
'trafficAllocation': 100,
'trafficAllocationSeed': 123456,
'seed': 321654,
'status': 'ACTIVE',
'killed': False,
'defaultTreatment': 'off',
'algo': 2,
'conditions': [
{
'partitions': [
{'treatment': 'on', 'size': 50},
{'treatment': 'off', 'size': 50}
],
'contitionType': 'WHITELIST',
'label': 'some_label',
'matcherGroup': {
'matchers': [
{
'matcherType': 'WHITELIST',
'whitelistMatcherData': {
'whitelist': ['k1', 'k2', 'k3']
},
'negate': False,
}
],
'combiner': 'AND'
}
}
],
'sets': ['set1', 'set2']
}]
json_body = {
"ff": {
"t":1675095324253,
"s":-1,
'd': [{
'changeNumber': 123,
'trafficTypeName': 'user',
'name': 'some_name',
'trafficAllocation': 100,
'trafficAllocationSeed': 123456,
'seed': 321654,
'status': 'ACTIVE',
'killed': False,
'defaultTreatment': 'off',
'algo': 2,
'conditions': [
{
'partitions': [
{'treatment': 'on', 'size': 50},
{'treatment': 'off', 'size': 50}
],
'contitionType': 'WHITELIST',
'label': 'some_label',
'matcherGroup': {
'matchers': [
{
'matcherType': 'WHITELIST',
'whitelistMatcherData': {
'whitelist': ['k1', 'k2', 'k3']
},
'negate': False,
}
],
'combiner': 'AND'
}
},
{
"conditionType": "ROLLOUT",
"matcherGroup": {
"combiner": "AND",
"matchers": [
{
"keySelector": {
"trafficType": "user"
},
"matcherType": "IN_RULE_BASED_SEGMENT",
"negate": False,
"userDefinedSegmentMatcherData": {
"segmentName": "sample_rule_based_segment"
}
}
]
},
"partitions": [
{
"treatment": "on",
"size": 100
},
{
"treatment": "off",
"size": 0
}
],
"label": "in rule based segment sample_rule_based_segment"
},
],
'sets': ['set1', 'set2']}]
},
"rbs": {
"t": 1675095324253,
"s": -1,
"d": [
{
"changeNumber": 5,
"name": "sample_rule_based_segment",
"status": "ACTIVE",
"trafficTypeName": "user",
"excluded":{
"keys":["mauro@split.io","gaston@split.io"],
"segments":[]
},
"conditions": [
{
"matcherGroup": {
"combiner": "AND",
"matchers": [
{
"keySelector": {
"trafficType": "user",
"attribute": "email"
},
"matcherType": "ENDS_WITH",
"negate": False,
"whitelistMatcherData": {
"whitelist": [
"@split.io"
]
}
}
]
}
}
]
}
]
}
}
class SplitsSynchronizerTests(object):
"""Split synchronizer test cases."""
splits = copy.deepcopy(splits_raw)
def test_synchronize_splits_error(self, mocker):
"""Test that if fetching splits fails at some_point, the task will continue running."""
storage = mocker.Mock(spec=InMemorySplitStorage)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorage)
api = mocker.Mock()
def run(x, y, c):
raise APIException("something broke")
run._calls = 0
api.fetch_splits.side_effect = run
storage.get_change_number.return_value = -1
rbs_storage.get_change_number.return_value = -1
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
split_synchronizer = SplitSynchronizer(api, storage, rbs_storage)
with pytest.raises(APIException):
split_synchronizer.synchronize_splits(1)
def test_synchronize_splits(self, mocker):
"""Test split sync."""
storage = mocker.Mock(spec=InMemorySplitStorage)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorage)
def change_number_mock():
change_number_mock._calls += 1
if change_number_mock._calls == 1:
return -1
return 123
def rbs_change_number_mock():
rbs_change_number_mock._calls += 1
if rbs_change_number_mock._calls == 1:
return -1
return 123
change_number_mock._calls = 0
rbs_change_number_mock._calls = 0
storage.get_change_number.side_effect = change_number_mock
rbs_storage.get_change_number.side_effect = rbs_change_number_mock
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
api = mocker.Mock()
def get_changes(*args, **kwargs):
get_changes.called += 1
if get_changes.called == 1:
return json_body
else:
return {
"ff": {
"t":123,
"s":123,
'd': []
},
"rbs": {
"t": 5,
"s": 5,
"d": []
}
}
get_changes.called = 0
api.fetch_splits.side_effect = get_changes
split_synchronizer = SplitSynchronizer(api, storage, rbs_storage)
split_synchronizer.synchronize_splits()
assert api.fetch_splits.mock_calls[0][1][0] == -1
assert api.fetch_splits.mock_calls[0][1][2].cache_control_headers == True
assert api.fetch_splits.mock_calls[1][1][0] == 123
assert api.fetch_splits.mock_calls[1][1][1] == 123
assert api.fetch_splits.mock_calls[1][1][2].cache_control_headers == True
inserted_split = storage.update.mock_calls[0][1][0][0]
assert isinstance(inserted_split, Split)
assert inserted_split.name == 'some_name'
inserted_rbs = rbs_storage.update.mock_calls[0][1][0][0]
assert isinstance(inserted_rbs, RuleBasedSegment)
assert inserted_rbs.name == 'sample_rule_based_segment'
def test_not_called_on_till(self, mocker):
"""Test that sync is not called when till is less than previous changenumber"""
storage = mocker.Mock(spec=InMemorySplitStorage)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorage)
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
def change_number_mock():
return 2
storage.get_change_number.side_effect = change_number_mock
rbs_storage.get_change_number.side_effect = change_number_mock
def get_changes(*args, **kwargs):
get_changes.called += 1
return None
get_changes.called = 0
api = mocker.Mock()
api.fetch_splits.side_effect = get_changes
split_synchronizer = SplitSynchronizer(api, storage, rbs_storage)
split_synchronizer.synchronize_splits(1)
assert get_changes.called == 0
def test_synchronize_splits_cdn(self, mocker):
"""Test split sync with bypassing cdn."""
mocker.patch('splitio.sync.split._ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES', new=3)
storage = mocker.Mock(spec=InMemorySplitStorage)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorage)
def change_number_mock():
change_number_mock._calls += 1
if change_number_mock._calls == 1:
return -1
elif change_number_mock._calls >= 2 and change_number_mock._calls <= 3:
return 123
elif change_number_mock._calls <= 7:
return 1234
return 12345 # Return proper cn for CDN Bypass
def rbs_change_number_mock():
rbs_change_number_mock._calls += 1
if rbs_change_number_mock._calls == 1:
return -1
elif change_number_mock._calls >= 2 and change_number_mock._calls <= 3:
return 555
elif change_number_mock._calls <= 9:
return 555
return 666 # Return proper cn for CDN Bypass
change_number_mock._calls = 0
rbs_change_number_mock._calls = 0
storage.get_change_number.side_effect = change_number_mock
rbs_storage.get_change_number.side_effect = rbs_change_number_mock
api = mocker.Mock()
rbs_1 = copy.deepcopy(json_body['rbs']['d'])
def get_changes(*args, **kwargs):
get_changes.called += 1
if get_changes.called == 1:
return { 'ff': { 'd': self.splits, 's': -1, 't': 123 },
'rbs': {"t": 555, "s": -1, "d": rbs_1}}
elif get_changes.called == 2:
return { 'ff': { 'd': [], 's': 123, 't': 123 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called == 3:
return { 'ff': { 'd': [], 's': 123, 't': 1234 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called >= 4 and get_changes.called <= 6:
return { 'ff': { 'd': [], 's': 1234, 't': 1234 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called == 7:
return { 'ff': { 'd': [], 's': 1234, 't': 12345 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called == 8:
return { 'ff': { 'd': [], 's': 12345, 't': 12345 },
'rbs': {"t": 555, "s": 555, "d": []}}
rbs_1[0]['excluded']['keys'] = ['bilal@split.io']
return { 'ff': { 'd': [], 's': 12345, 't': 12345 },
'rbs': {"t": 666, "s": 666, "d": rbs_1}}
get_changes.called = 0
api.fetch_splits.side_effect = get_changes
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
split_synchronizer = SplitSynchronizer(api, storage, rbs_storage)
split_synchronizer._backoff = Backoff(1, 1)
split_synchronizer.synchronize_splits()
assert api.fetch_splits.mock_calls[0][1][0] == -1
assert api.fetch_splits.mock_calls[0][1][2].cache_control_headers == True
assert api.fetch_splits.mock_calls[1][1][0] == 123
assert api.fetch_splits.mock_calls[1][1][2].cache_control_headers == True
split_synchronizer._backoff = Backoff(1, 0.1)
split_synchronizer.synchronize_splits(12345)
assert api.fetch_splits.mock_calls[3][1][0] == 1234
assert api.fetch_splits.mock_calls[3][1][2].cache_control_headers == True
assert len(api.fetch_splits.mock_calls) == 8 # 2 ok + BACKOFF(2 since==till + 2 re-attempts) + CDN(2 since==till)
inserted_split = storage.update.mock_calls[0][1][0][0]
assert isinstance(inserted_split, Split)
assert inserted_split.name == 'some_name'
inserted_rbs = rbs_storage.update.mock_calls[0][1][0][0]
assert inserted_rbs.excluded.get_excluded_keys() == ["mauro@split.io","gaston@split.io"]
split_synchronizer._backoff = Backoff(1, 0.1)
split_synchronizer.synchronize_splits(None, 666)
inserted_rbs = rbs_storage.update.mock_calls[8][1][0][0]
assert inserted_rbs.excluded.get_excluded_keys() == ['bilal@split.io']
def test_sync_flag_sets_with_config_sets(self, mocker):
"""Test split sync with flag sets."""
events_queue = queue.Queue()
storage = InMemorySplitStorage(events_queue, ['set1', 'set2'])
events_queue = queue.Queue()
rbs_storage = InMemoryRuleBasedSegmentStorage(events_queue)
split = copy.deepcopy(self.splits[0])
split['name'] = 'second'
splits1 = [self.splits[0].copy(), split]
splits2 = copy.deepcopy(self.splits)
splits3 = copy.deepcopy(self.splits)
splits4 = copy.deepcopy(self.splits)
api = mocker.Mock()
def get_changes(*args, **kwargs):
get_changes.called += 1
if get_changes.called == 1:
return { 'ff': { 'd': splits1, 's': 123, 't': 123 },
'rbs': {'t': 123, 's': 123, 'd': []}}
elif get_changes.called == 2:
splits2[0]['sets'] = ['set3']
return { 'ff': { 'd': splits2, 's': 124, 't': 124 },
'rbs': {'t': 124, 's': 124, 'd': []}}
elif get_changes.called == 3:
splits3[0]['sets'] = ['set1']
return { 'ff': { 'd': splits3, 's': 12434, 't': 12434 },
'rbs': {'t': 12434, 's': 12434, 'd': []}}
splits4[0]['sets'] = ['set6']
splits4[0]['name'] = 'new_split'
return { 'ff': { 'd': splits4, 's': 12438, 't': 12438 },
'rbs': {'t': 12438, 's': 12438, 'd': []}}
get_changes.called = 0
api.fetch_splits.side_effect = get_changes
split_synchronizer = SplitSynchronizer(api, storage, rbs_storage)
split_synchronizer._backoff = Backoff(1, 1)
split_synchronizer.synchronize_splits()
assert isinstance(storage.get('some_name'), Split)
split_synchronizer.synchronize_splits(124)
assert storage.get('some_name') == None
split_synchronizer.synchronize_splits(12434)
assert isinstance(storage.get('some_name'), Split)
split_synchronizer.synchronize_splits(12438)
assert storage.get('new_name') == None
def test_sync_flag_sets_without_config_sets(self, mocker):
"""Test split sync with flag sets."""
events_queue = queue.Queue()
storage = InMemorySplitStorage(events_queue)
rbs_storage = InMemoryRuleBasedSegmentStorage(events_queue)
split = copy.deepcopy(self.splits[0])
split['name'] = 'second'
splits1 = [self.splits[0].copy(), split]
splits2 = copy.deepcopy(self.splits)
splits3 = copy.deepcopy(self.splits)
splits4 = copy.deepcopy(self.splits)
api = mocker.Mock()
def get_changes(*args, **kwargs):
get_changes.called += 1
if get_changes.called == 1:
return { 'ff': { 'd': splits1, 's': 123, 't': 123 },
'rbs': {"t": 123, "s": 123, "d": []}}
elif get_changes.called == 2:
splits2[0]['sets'] = ['set3']
return { 'ff': { 'd': splits2, 's': 124, 't': 124 },
'rbs': {"t": 124, "s": 124, "d": []}}
elif get_changes.called == 3:
splits3[0]['sets'] = ['set1']
return { 'ff': { 'd': splits3, 's': 12434, 't': 12434 },
'rbs': {"t": 12434, "s": 12434, "d": []}}
splits4[0]['sets'] = ['set6']
splits4[0]['name'] = 'third_split'
return { 'ff': { 'd': splits4, 's': 12438, 't': 12438 },
'rbs': {"t": 12438, "s": 12438, "d": []}}
get_changes.called = 0
api.fetch_splits.side_effect = get_changes
split_synchronizer = SplitSynchronizer(api, storage, rbs_storage)
split_synchronizer._backoff = Backoff(1, 1)
split_synchronizer.synchronize_splits()
assert isinstance(storage.get('some_name'), Split)
split_synchronizer.synchronize_splits(124)
assert isinstance(storage.get('some_name'), Split)
split_synchronizer.synchronize_splits(12434)
assert isinstance(storage.get('some_name'), Split)
split_synchronizer.synchronize_splits(12438)
assert isinstance(storage.get('third_split'), Split)
class SplitsSynchronizerAsyncTests(object):
"""Split synchronizer test cases."""
splits = copy.deepcopy(splits_raw)
@pytest.mark.asyncio
async def test_synchronize_splits_error(self, mocker):
"""Test that if fetching splits fails at some_point, the task will continue running."""
storage = mocker.Mock(spec=InMemorySplitStorageAsync)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorageAsync)
api = mocker.Mock()
async def run(x, y, c):
raise APIException("something broke")
run._calls = 0
api.fetch_splits = run
async def get_change_number(*args):
return -1
storage.get_change_number = get_change_number
rbs_storage.get_change_number = get_change_number
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
split_synchronizer = SplitSynchronizerAsync(api, storage, rbs_storage)
with pytest.raises(APIException):
await split_synchronizer.synchronize_splits(1)
@pytest.mark.asyncio
async def test_synchronize_splits(self, mocker):
"""Test split sync."""
storage = mocker.Mock(spec=InMemorySplitStorageAsync)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorageAsync)
async def change_number_mock():
change_number_mock._calls += 1
if change_number_mock._calls == 1:
return -1
return 123
async def rbs_change_number_mock():
rbs_change_number_mock._calls += 1
if rbs_change_number_mock._calls == 1:
return -1
return 123
change_number_mock._calls = 0
rbs_change_number_mock._calls = 0
storage.get_change_number = change_number_mock
rbs_storage.get_change_number.side_effect = rbs_change_number_mock
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
self.parsed_split = None
async def update(parsed_split, deleted, chanhe_number):
if len(parsed_split) > 0:
self.parsed_split = parsed_split
storage.update = update
self.parsed_rbs = None
async def update(parsed_rbs, deleted, chanhe_number):
if len(parsed_rbs) > 0:
self.parsed_rbs = parsed_rbs
rbs_storage.update = update
self.clear = False
async def clear():
self.clear = True
storage.clear = clear
self.clear2 = False
async def clear():
self.clear2 = True
rbs_storage.clear = clear
api = mocker.Mock()
self.change_number_1 = None
self.fetch_options_1 = None
self.change_number_2 = None
self.fetch_options_2 = None
async def get_changes(change_number, rbs_change_number, fetch_options):
get_changes.called += 1
if get_changes.called == 1:
self.change_number_1 = change_number
self.fetch_options_1 = fetch_options
return json_body
else:
self.change_number_2 = change_number
self.fetch_options_2 = fetch_options
return {
"ff": {
"t":123,
"s":123,
'd': []
},
"rbs": {
"t": 123,
"s": 123,
"d": []
}
}
get_changes.called = 0
api.fetch_splits = get_changes
api.clear_storage.return_value = False
split_synchronizer = SplitSynchronizerAsync(api, storage, rbs_storage)
await split_synchronizer.synchronize_splits()
assert (-1, FetchOptions(True)._cache_control_headers) == (self.change_number_1, self.fetch_options_1._cache_control_headers)
assert (123, FetchOptions(True)._cache_control_headers) == (self.change_number_2, self.fetch_options_2._cache_control_headers)
inserted_split = self.parsed_split[0]
assert isinstance(inserted_split, Split)
assert inserted_split.name == 'some_name'
inserted_rbs = self.parsed_rbs[0]
assert isinstance(inserted_rbs, RuleBasedSegment)
assert inserted_rbs.name == 'sample_rule_based_segment'
@pytest.mark.asyncio
async def test_not_called_on_till(self, mocker):
"""Test that sync is not called when till is less than previous changenumber"""
storage = mocker.Mock(spec=InMemorySplitStorageAsync)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorageAsync)
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
async def change_number_mock():
return 2
storage.get_change_number = change_number_mock
rbs_storage.get_change_number.side_effect = change_number_mock
async def get_changes(*args, **kwargs):
get_changes.called += 1
return None
get_changes.called = 0
api = mocker.Mock()
api.fetch_splits = get_changes
split_synchronizer = SplitSynchronizerAsync(api, storage, rbs_storage)
await split_synchronizer.synchronize_splits(1)
assert get_changes.called == 0
@pytest.mark.asyncio
async def test_synchronize_splits_cdn(self, mocker):
"""Test split sync with bypassing cdn."""
mocker.patch('splitio.sync.split._ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES', new=3)
storage = mocker.Mock(spec=InMemorySplitStorageAsync)
rbs_storage = mocker.Mock(spec=InMemoryRuleBasedSegmentStorageAsync)
async def change_number_mock():
change_number_mock._calls += 1
if change_number_mock._calls == 1:
return -1
elif change_number_mock._calls >= 2 and change_number_mock._calls <= 3:
return 123
elif change_number_mock._calls <= 7:
return 1234
return 12345 # Return proper cn for CDN Bypass
async def rbs_change_number_mock():
rbs_change_number_mock._calls += 1
if rbs_change_number_mock._calls == 1:
return -1
elif change_number_mock._calls >= 2 and change_number_mock._calls <= 3:
return 555
elif change_number_mock._calls <= 9:
return 555
return 666 # Return proper cn for CDN Bypass
change_number_mock._calls = 0
rbs_change_number_mock._calls = 0
storage.get_change_number = change_number_mock
rbs_storage.get_change_number = rbs_change_number_mock
self.parsed_split = None
async def update(parsed_split, deleted, change_number):
if len(parsed_split) > 0:
self.parsed_split = parsed_split
storage.update = update
self.parsed_rbs = None
async def rbs_update(parsed, deleted, change_number):
if len(parsed) > 0:
self.parsed_rbs = parsed
rbs_storage.update = rbs_update
api = mocker.Mock()
self.change_number_1 = None
self.fetch_options_1 = None
self.change_number_2 = None
self.fetch_options_2 = None
self.change_number_3 = None
self.fetch_options_3 = None
rbs_1 = copy.deepcopy(json_body['rbs']['d'])
async def get_changes(change_number, rbs_change_number, fetch_options):
get_changes.called += 1
if get_changes.called == 1:
self.change_number_1 = change_number
self.fetch_options_1 = fetch_options
return { 'ff': { 'd': self.splits, 's': -1, 't': 123 },
'rbs': {"t": 555, "s": -1, "d": rbs_1}}
elif get_changes.called == 2:
self.change_number_2 = change_number
self.fetch_options_2 = fetch_options
return { 'ff': { 'd': [], 's': 123, 't': 123 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called == 3:
return { 'ff': { 'd': [], 's': 123, 't': 1234 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called >= 4 and get_changes.called <= 6:
return { 'ff': { 'd': [], 's': 1234, 't': 1234 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called == 7:
return { 'ff': { 'd': [], 's': 1234, 't': 12345 },
'rbs': {"t": 555, "s": 555, "d": []}}
elif get_changes.called == 8:
self.change_number_3 = change_number
self.fetch_options_3 = fetch_options
return { 'ff': { 'd': [], 's': 12345, 't': 12345 },
'rbs': {"t": 555, "s": 555, "d": []}}
rbs_1[0]['excluded']['keys'] = ['bilal@split.io']
return { 'ff': { 'd': [], 's': 12345, 't': 12345 },
'rbs': {"t": 666, "s": 666, "d": rbs_1}}
get_changes.called = 0
api.fetch_splits = get_changes
class flag_set_filter():
def should_filter():
return False
def intersect(sets):
return True
storage.flag_set_filter = flag_set_filter
storage.flag_set_filter.flag_sets = {}
storage.flag_set_filter.sorted_flag_sets = []
self.clear = False
async def clear():
self.clear = True
storage.clear = clear
self.clear2 = False
async def clear():
self.clear2 = True
rbs_storage.clear = clear
split_synchronizer = SplitSynchronizerAsync(api, storage, rbs_storage)
split_synchronizer._backoff = Backoff(1, 1)
await split_synchronizer.synchronize_splits()
assert (-1, FetchOptions(True).cache_control_headers) == (self.change_number_1, self.fetch_options_1.cache_control_headers)
assert (123, FetchOptions(True).cache_control_headers) == (self.change_number_2, self.fetch_options_2.cache_control_headers)
split_synchronizer._backoff = Backoff(1, 0.1)
await split_synchronizer.synchronize_splits(12345)
assert (12345, True, 1234) == (self.change_number_3, self.fetch_options_3.cache_control_headers, self.fetch_options_3.change_number)
assert get_changes.called == 8 # 2 ok + BACKOFF(2 since==till + 2 re-attempts) + CDN(2 since==till)
inserted_split = self.parsed_split[0]
assert isinstance(inserted_split, Split)
assert inserted_split.name == 'some_name'
inserted_rbs = self.parsed_rbs[0]
assert inserted_rbs.excluded.get_excluded_keys() == ["mauro@split.io","gaston@split.io"]
split_synchronizer._backoff = Backoff(1, 0.1)
await split_synchronizer.synchronize_splits(None, 666)
inserted_rbs = self.parsed_rbs[0]
assert inserted_rbs.excluded.get_excluded_keys() == ['bilal@split.io']
@pytest.mark.asyncio
async def test_sync_flag_sets_with_config_sets(self, mocker):
"""Test split sync with flag sets."""
internal_events_queue = asyncio.Queue()
storage = InMemorySplitStorageAsync(internal_events_queue, ['set1', 'set2'])
rbs_storage = InMemoryRuleBasedSegmentStorageAsync(internal_events_queue)
split = self.splits[0].copy()
split['name'] = 'second'
splits1 = [self.splits[0].copy(), split]
splits2 = self.splits.copy()
splits3 = self.splits.copy()
splits4 = self.splits.copy()
api = mocker.Mock()
async def get_changes(*args, **kwargs):
get_changes.called += 1
if get_changes.called == 1:
return { 'ff': { 'd': splits1, 's': 123, 't': 123 },
'rbs': {'t': 123, 's': 123, 'd': []}}
elif get_changes.called == 2:
splits2[0]['sets'] = ['set3']
return { 'ff': { 'd': splits2, 's': 124, 't': 124 },
'rbs': {'t': 124, 's': 124, 'd': []}}
elif get_changes.called == 3:
splits3[0]['sets'] = ['set1']
return { 'ff': { 'd': splits3, 's': 12434, 't': 12434 },
'rbs': {'t': 12434, 's': 12434, 'd': []}}
splits4[0]['sets'] = ['set6']
splits4[0]['name'] = 'new_split'
return { 'ff': { 'd': splits4, 's': 12438, 't': 12438 },
'rbs': {'t': 12438, 's': 12438, 'd': []}}
get_changes.called = 0
api.fetch_splits = get_changes
split_synchronizer = SplitSynchronizerAsync(api, storage, rbs_storage)
split_synchronizer._backoff = Backoff(1, 1)
await split_synchronizer.synchronize_splits()
assert isinstance(await storage.get('some_name'), Split)
await split_synchronizer.synchronize_splits(124)
assert await storage.get('some_name') == None
await split_synchronizer.synchronize_splits(12434)
assert isinstance(await storage.get('some_name'), Split)
await split_synchronizer.synchronize_splits(12438)
assert await storage.get('new_name') == None
@pytest.mark.asyncio
async def test_sync_flag_sets_without_config_sets(self, mocker):
"""Test split sync with flag sets."""
internal_events_queue = asyncio.Queue()
storage = InMemorySplitStorageAsync(internal_events_queue)
rbs_storage = InMemoryRuleBasedSegmentStorageAsync(internal_events_queue)
split = self.splits[0].copy()
split['name'] = 'second'
splits1 = [self.splits[0].copy(), split]
splits2 = self.splits.copy()
splits3 = self.splits.copy()
splits4 = self.splits.copy()
api = mocker.Mock()
async def get_changes(*args, **kwargs):
get_changes.called += 1
if get_changes.called == 1:
return { 'ff': { 'd': splits1, 's': 123, 't': 123 },
'rbs': {"t": 123, "s": 123, "d": []}}
elif get_changes.called == 2:
splits2[0]['sets'] = ['set3']
return { 'ff': { 'd': splits2, 's': 124, 't': 124 },
'rbs': {"t": 124, "s": 124, "d": []}}
elif get_changes.called == 3:
splits3[0]['sets'] = ['set1']
return { 'ff': { 'd': splits3, 's': 12434, 't': 12434 },
'rbs': {"t": 12434, "s": 12434, "d": []}}
splits4[0]['sets'] = ['set6']
splits4[0]['name'] = 'third_split'
return { 'ff': { 'd': splits4, 's': 12438, 't': 12438 },
'rbs': {"t": 12438, "s": 12438, "d": []}}
get_changes.called = 0
api.fetch_splits.side_effect = get_changes
split_synchronizer = SplitSynchronizerAsync(api, storage, rbs_storage)
split_synchronizer._backoff = Backoff(1, 1)
await split_synchronizer.synchronize_splits()
assert isinstance(await storage.get('new_split'), Split)
await split_synchronizer.synchronize_splits(124)
assert isinstance(await storage.get('new_split'), Split)
await split_synchronizer.synchronize_splits(12434)
assert isinstance(await storage.get('new_split'), Split)
await split_synchronizer.synchronize_splits(12438)
assert isinstance(await storage.get('third_split'), Split)
class LocalSplitsSynchronizerTests(object):
"""Split synchronizer test cases."""
payload = copy.deepcopy(json_body)
def test_synchronize_splits_error(self, mocker):
"""Test that if fetching splits fails at some_point, the task will continue running."""
storage = mocker.Mock(spec=SplitStorage)
rbs_storage = mocker.Mock(spec=RuleBasedSegmentsStorage)
split_synchronizer = LocalSplitSynchronizer("/incorrect_file", storage, rbs_storage)
with pytest.raises(Exception):
split_synchronizer.synchronize_splits(1)
def test_synchronize_splits(self, mocker):
"""Test split sync."""
events_queue = queue.Queue()
storage = InMemorySplitStorage(events_queue)
rbs_storage = InMemoryRuleBasedSegmentStorage(events_queue)
def read_splits_from_json_file(*args, **kwargs):
return self.payload
split_synchronizer = LocalSplitSynchronizer("split.json", storage, rbs_storage, LocalhostMode.JSON)
split_synchronizer._read_feature_flags_from_json_file = read_splits_from_json_file
split_synchronizer.synchronize_splits()
inserted_split = storage.get(self.payload["ff"]["d"][0]['name'])
assert isinstance(inserted_split, Split)
assert inserted_split.name == 'some_name'
# Should sync when changenumber is not changed
self.payload["ff"]["d"][0]['killed'] = True
split_synchronizer.synchronize_splits()
inserted_split = storage.get(self.payload["ff"]["d"][0]['name'])
assert inserted_split.killed
# Should not sync when changenumber is less than stored
self.payload["ff"]["t"] = 122
self.payload["ff"]["d"][0]['killed'] = False
split_synchronizer.synchronize_splits()
inserted_split = storage.get(self.payload["ff"]["d"][0]['name'])
assert inserted_split.killed
# Should sync when changenumber is higher than stored
self.payload["ff"]["t"] = 1675095324999
split_synchronizer._current_json_sha = "-1"
split_synchronizer.synchronize_splits()
inserted_split = storage.get(self.payload["ff"]["d"][0]['name'])
assert inserted_split.killed == False
# Should sync when till is default (-1)
self.payload["ff"]["t"] = -1
split_synchronizer._current_json_sha = "-1"
self.payload["ff"]["d"][0]['killed'] = True
split_synchronizer.synchronize_splits()
inserted_split = storage.get(self.payload["ff"]["d"][0]['name'])
assert inserted_split.killed == True
def test_sync_flag_sets_with_config_sets(self, mocker):
"""Test split sync with flag sets."""
events_queue = queue.Queue()
storage = InMemorySplitStorage(events_queue, ['set1', 'set2'])
rbs_storage = InMemoryRuleBasedSegmentStorage(events_queue)
split = self.payload["ff"]["d"][0].copy()
split['name'] = 'second'
splits1 = [self.payload["ff"]["d"][0].copy(), split]
splits2 = self.payload["ff"]["d"].copy()
splits3 = self.payload["ff"]["d"].copy()
splits4 = self.payload["ff"]["d"].copy()
self.called = 0
def read_feature_flags_from_json_file(*args, **kwargs):
self.called += 1
if self.called == 1:
return {"ff": {"d": splits1, "t": 123, "s": -1}, "rbs": {"d": [], "t": -1, "s": -1}}
elif self.called == 2:
splits2[0]['sets'] = ['set3']
return {"ff": {"d": splits2, "t": 124, "s": -1}, "rbs": {"d": [], "t": -1, "s": -1}}
elif self.called == 3:
splits3[0]['sets'] = ['set1']
return {"ff": {"d": splits3, "t": 12434, "s": -1}, "rbs": {"d": [], "t": -1, "s": -1}}
splits4[0]['sets'] = ['set6']
splits4[0]['name'] = 'new_split'
return {"ff": {"d": splits4, "t": 12438, "s": -1}, "rbs": {"d": [], "t": -1, "s": -1}}
split_synchronizer = LocalSplitSynchronizer("split.json", storage, rbs_storage, LocalhostMode.JSON)
split_synchronizer._read_feature_flags_from_json_file = read_feature_flags_from_json_file
split_synchronizer.synchronize_splits()
assert isinstance(storage.get('some_name'), Split)
split_synchronizer.synchronize_splits(124)
assert storage.get('some_name') == None
split_synchronizer.synchronize_splits(12434)
assert isinstance(storage.get('some_name'), Split)
split_synchronizer.synchronize_splits(12438)
assert storage.get('new_name') == None
def test_sync_flag_sets_without_config_sets(self, mocker):
"""Test split sync with flag sets."""
events_queue = queue.Queue()
storage = InMemorySplitStorage(events_queue)
rbs_storage = InMemoryRuleBasedSegmentStorage(events_queue)
split = self.payload["ff"]["d"][0].copy()
split['name'] = 'second'
splits1 = [self.payload["ff"]["d"][0].copy(), split]
splits2 = self.payload["ff"]["d"].copy()
splits3 = self.payload["ff"]["d"].copy()