Fix tests

EmilianoSanchez · EmilianoSanchez · commit ea660749d0ea · 2025-04-01T18:10:14.000-03:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up nodejs
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 'lts/*'
           cache: 'npm'
diff --git a/src/storages/__tests__/KeyBuilder.spec.ts b/src/storages/__tests__/KeyBuilder.spec.ts
@@ -105,17 +105,22 @@ test('KEYS / latency and exception keys (telemetry)', () => {
 
 test('getStorageHash', () => {
   expect(getStorageHash({
-    core: { authorizationKey: '<fake-token-rfc>' },
+    core: { authorizationKey: 'sdk-key' },
     sync: { __splitFiltersValidation: { queryString: '&names=p1__split,p2__split' }, flagSpecVersion: '1.3' }
-  } as ISettings)).toBe('2ce5cc38');
+  } as ISettings)).toBe('d700da23');
 
   expect(getStorageHash({
-    core: { authorizationKey: '<fake-token-rfc>' },
+    core: { authorizationKey: 'sdk-key' },
     sync: { __splitFiltersValidation: { queryString: '&names=p2__split,p3__split' }, flagSpecVersion: '1.3' }
-  } as ISettings)).toBe('e65079c6');
+  } as ISettings)).toBe('8c8a8789');
 
   expect(getStorageHash({
-    core: { authorizationKey: '<fake-token-rfc>' },
+    core: { authorizationKey: 'aaaabbbbcccc1234' },
     sync: { __splitFiltersValidation: { queryString: null }, flagSpecVersion: '1.3' }
-  } as ISettings)).toBe('193e6f3f');
+  } as ISettings)).toBe('dc1f9817');
+
+  expect(getStorageHash({
+    core: { authorizationKey: 'another-sdk-key' },
+    sync: { __splitFiltersValidation: { queryString: null }, flagSpecVersion: '1.3' }
+  } as ISettings)).toBe('45c6ba5d');
 });
diff --git a/src/storages/inLocalStorage/__tests__/validateCache.spec.ts b/src/storages/inLocalStorage/__tests__/validateCache.spec.ts
@@ -6,7 +6,7 @@ import { SplitsCacheInLocal } from '../SplitsCacheInLocal';
 import { nearlyEqual } from '../../../__tests__/testUtils';
 import { MySegmentsCacheInLocal } from '../MySegmentsCacheInLocal';
 
-const FULL_SETTINGS_HASH = '404832b3';
+const FULL_SETTINGS_HASH = 'dc1f9817';
 
 describe('validateCache', () => {
   const keys = new KeyBuilderCS('SPLITIO', 'user');
@@ -77,15 +77,15 @@ describe('validateCache', () => {
     localStorage.setItem(keys.buildSplitsTillKey(), '1');
     localStorage.setItem(keys.buildHashKey(), FULL_SETTINGS_HASH);
 
-    expect(validateCache({}, { ...fullSettings, core: { ...fullSettings.core, authorizationKey: 'another' } }, keys, splits, segments, largeSegments)).toBe(false);
+    expect(validateCache({}, { ...fullSettings, core: { ...fullSettings.core, authorizationKey: 'another-sdk-key' } }, keys, splits, segments, largeSegments)).toBe(false);
 
     expect(logSpy).toHaveBeenCalledWith('storage:localstorage: SDK key, flags filter criteria, or flags spec version has changed. Cleaning up cache');
 
     expect(splits.clear).toHaveBeenCalledTimes(1);
     expect(segments.clear).toHaveBeenCalledTimes(1);
     expect(largeSegments.clear).toHaveBeenCalledTimes(1);
 
-    expect(localStorage.getItem(keys.buildHashKey())).toBe('aa4877c2');
+    expect(localStorage.getItem(keys.buildHashKey())).toBe('45c6ba5d');
     expect(nearlyEqual(parseInt(localStorage.getItem(keys.buildLastClear()) as string), Date.now())).toBe(true);
   });
 
diff --git a/src/utils/settingsValidation/__tests__/settings.mocks.ts b/src/utils/settingsValidation/__tests__/settings.mocks.ts
@@ -1,6 +1,7 @@
 import { InMemoryStorageCSFactory } from '../../../storages/inMemory/InMemoryStorageCS';
 import { ISettings } from '../../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
+import { FLAG_SPEC_VERSION } from '../../constants';
 
 export const settingsWithKey = {
   core: {
@@ -67,7 +68,7 @@ export const fullSettings: ISettings = {
       groupedFilters: { bySet: [], byName: [], byPrefix: [] },
     },
     enabled: true,
-    flagSpecVersion: '1.3'
+    flagSpecVersion: FLAG_SPEC_VERSION
   },
   version: 'jest',
   runtime: {
